Use std::terminate rather than throwing in a noexcept function

Summary: Because MSVC isn't happy about it and generates a warning with a lot of context.

Reviewed By: yfeldblum

Differential Revision: D4242688

fbshipit-source-id: b1e26c9e3b58e7bac0e00ab8959358010fa610e8

diff --git a/folly/ScopeGuard.h b/folly/ScopeGuard.h
index 26531cd87c9e626c836299bbbafbd58148a159ed..2c71c5b9ac3db76ae07c3e2f5e79e5fd6cdd568b 100644 (file)
--- a/folly/ScopeGuard.h
+++ b/folly/ScopeGuard.h
@@ -83,7 +83,7 @@ class ScopeGuardImplBase {
       function();
     } catch (...) {
       warnAboutToCrash();
-      throw;
+      std::terminate();
     }
   }