(folly) have Try::moveFromTry take an lvalue

Summary: This is a case of having to say what you're doing twice, and it's unnecessary.
This change should not break anything as calling `std::move(lvalue)` where an
lvalue reference is expected will just be superfluous.

Reviewed By: @jsedgwick

Differential Revision: D2534944

fb-gh-sync-id: fdcd168f369d95b0f28abe23b401b4321f51fc36

diff --git a/folly/experimental/fibers/FiberManager-inl.h b/folly/experimental/fibers/FiberManager-inl.h
index 5b57c8552f22e4a688955e846019aed53a0de096..8df38576d28b38b949ca8b16de99f78d4478ca7d 100644 (file)
--- a/folly/experimental/fibers/FiberManager-inl.h
+++ b/folly/experimental/fibers/FiberManager-inl.h
@@ -519,7 +519,7 @@ inline await(F&& func) {
       func(Promise<Result>(result, baton));
     });
 
-  return folly::moveFromTry(std::move(result));
+  return folly::moveFromTry(result);
 }
 
 }}

diff --git a/folly/futures/Try-inl.h b/folly/futures/Try-inl.h
index 05f384a826b75640539abc69e34f913e604f6ddf..c6673cb8c3cc60bb59119922dd86e3a4b9d3799b 100644 (file)
--- a/folly/futures/Try-inl.h
+++ b/folly/futures/Try-inl.h
@@ -131,11 +131,11 @@ void Try<void>::throwIfFailed() const {
 }
 
 template <typename T>
-inline T moveFromTry(Try<T>&& t) {
+inline T moveFromTry(Try<T>& t) {
   return std::move(t.value());
 }
 
-inline void moveFromTry(Try<void>&& t) {
+inline void moveFromTry(Try<void>& t) {
   return t.value();
 }
 

diff --git a/folly/futures/Try.h b/folly/futures/Try.h
index e5e38afbbf42275fe4397ac6c0c423eea480f8b3..beec20a24d8dbc8b1c9b88b155afd8710671b8dd 100644 (file)
--- a/folly/futures/Try.h
+++ b/folly/futures/Try.h
@@ -350,14 +350,14 @@ class Try<void> {
  * @returns value contained in t
  */
 template <typename T>
-T moveFromTry(Try<T>&& t);
+T moveFromTry(Try<T>& t);
 
 /*
  * Throws if try contained an exception.
  *
  * @param t Try to move from
  */
-void moveFromTry(Try<void>&& t);
+void moveFromTry(Try<void>& t);
 
 /*
  * @param f a function to execute and capture the result of (value or exception)