Ensure LogWriter::writeMessage(std::string&&) is in the overload set of ImmediateFile...
authorChristopher Dykes <cdykes@fb.com>
Thu, 15 Jun 2017 23:53:09 +0000 (16:53 -0700)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Fri, 16 Jun 2017 00:05:33 +0000 (17:05 -0700)
Summary: As MSVC correctly warns via C4266, the overload sets of functions in base classes are not part of the overload set in derived classes where you've declared an overload (or override) unless you've explicitly imported it.

Reviewed By: simpkins

Differential Revision: D5260056

fbshipit-source-id: bbbeeea3c13201a3a6eba6e62cfa5a49a9470d43

folly/experimental/logging/ImmediateFileWriter.h

index 8f49c1fc11f2c667c86e55f28007f405328ab368..a029e73ff4bf660e3c3c1bbd7c2817e9a605b782 100644 (file)
@@ -46,6 +46,7 @@ class ImmediateFileWriter : public LogWriter {
    */
   explicit ImmediateFileWriter(folly::File&& file);
 
+  using LogWriter::writeMessage;
   void writeMessage(folly::StringPiece buffer) override;
 
  private: