Reverted commit D3927397
authorEric Niebler <eniebler@fb.com>
Thu, 20 Oct 2016 23:57:29 +0000 (16:57 -0700)
committerFacebook Github Bot <facebook-github-bot-bot@fb.com>
Fri, 21 Oct 2016 00:09:15 +0000 (17:09 -0700)
commitfbf4e10c59b331540e8a2668f436ea210a11c22a
tree843468b90751f6279260aa22028c1e12e77df4d6
parentcbec2f20f4a6ca636edd54c0a931ca019621c92d
Reverted commit D3927397

Summary: Someone debugged a runtime crash and traced it back to code like: `vector<fbstring>{{"this", "that"}}`. Presumably the user thought they were passing an initializer list of strings to the vector constructor. Instead, they constructed a single fbstring with two char pointers pointing into //different// strings. With the appropriate fbstring constructors, we can flag this as invalid at compile-time.

Reviewed By: yfeldblum

Differential Revision: D3927397

fbshipit-source-id: ab61e1e8498ec99592a2a7726eaf1cb6324f1455
folly/FBString.h
folly/test/FBStringTest.cpp