(Wangle) Possibly undefined behavior in collect
authorHannes Roth <hannesr@fb.com>
Wed, 24 Jun 2015 15:55:44 +0000 (08:55 -0700)
committerSara Golemon <sgolemon@fb.com>
Wed, 24 Jun 2015 16:41:05 +0000 (09:41 -0700)
commitfa33147273be70b6c796fc83c086897ac06d6a40
treef1b2414bccdbfba84e68c284932508b45019c72b
parentcc89faa334e87cd29359f59e8737583cbfced74b
(Wangle) Possibly undefined behavior in collect

Summary: Not sure if this is really undefined behavior or whether UBSAN is just super paranoid. Will try to read up on it later.

I also changed some other `std::atomic` initialization to always follow the same pattern, let me know if I should revert those. I couldn't resist, OCD kicked in.

idonthaveocd

Reviewed By: @fugalh

Differential Revision: D2181074
folly/futures/Future-inl.h
folly/futures/detail/Core.h