Schedule destroyInstances only when first singleton is created
authorAndrii Grynenko <andrii@fb.com>
Tue, 14 Oct 2014 03:08:15 +0000 (20:08 -0700)
committerdcsommer <dcsommer@fb.com>
Fri, 17 Oct 2014 18:43:57 +0000 (11:43 -0700)
commite5e3fde0cc5e35b87bec8714b0a7e6987a3d3975
tree51e85e7282c671d493dc5f6d38c2a8752810aa39
parentca4b4d09d7a0dde45ae12072ad8965a4cd8c7b68
Schedule destroyInstances only when first singleton is created

Summary:
Right now destroyInstances is scheduled when SingletonVault is requested. This may change singleton destruction order (folly::Singleton-managed vs unmanaged singletons) when new singleton is registered with folly::Singleton (no matter if it is even used).
This diff changes it to be more stable.

Test Plan: servicerouter unittests

Reviewed By: chip@fb.com

Subscribers: njormrod, mshneer

FB internal diff: D1615213

Tasks: 5353022
folly/experimental/Singleton.cpp
folly/experimental/Singleton.h