Don't shadow locals, parameters or fields
authorChristopher Dykes <cdykes@fb.com>
Fri, 9 Dec 2016 01:37:20 +0000 (17:37 -0800)
committerFacebook Github Bot <facebook-github-bot-bot@fb.com>
Fri, 9 Dec 2016 18:03:50 +0000 (10:03 -0800)
commitd5c1c7940fc29aadbd8bb8e8d1990add57a7b4f3
tree84a91e8556fd74b78d68f07c9bf928636cc3fc6a
parent43d3a315bbd54cb187021897b566ffb53290a44b
Don't shadow locals, parameters or fields

Summary:
This accounts for the places that were triggering warnings 4456, 4457, and 4458, which are all related to shadowing names, be they locals, parameters, or even types.
This doesn't deal with 4459, which is specifically for shadowing global variables, because folly/gen defines globals by the name of `count`, `min`, `max` and a few other similar names.

Reviewed By: meyering

Differential Revision: D4296781

fbshipit-source-id: a2e625095e2c65a53a9226b000aaf0ca95a3a393
folly/Synchronized.h
folly/experimental/test/FutureDAGTest.cpp
folly/experimental/test/StringKeyedTest.cpp
folly/io/async/test/AsyncSSLSocketTest.h
folly/io/async/test/AsyncSocketTest.h
folly/test/BitsTest.cpp
folly/test/ConcurrentSkipListTest.cpp
folly/test/ConvTest.cpp
folly/test/FBVectorTest.cpp
folly/test/FormatTest.cpp