folly: avoid new warnings from -Winconsistent-missing-override
authorJim Meyering <meyering@fb.com>
Fri, 13 Feb 2015 18:36:27 +0000 (10:36 -0800)
committerAlecs King <int@fb.com>
Tue, 3 Mar 2015 03:19:57 +0000 (19:19 -0800)
commitccb229d557f1d137473bd256739b379ffdd139e8
tree1f0496025929ace91f1dc8e66e793690d8bdcbbf
parent09430395fd7dea427c75af131b08bba8c5136535
folly: avoid new warnings from -Winconsistent-missing-override

Summary:
Upgrading to clang:dev (clang >3.6) brought in some new warnings.
This change address all of the issues exposed by the new
-Winconsistent-missing-override, usually by simply adding the
missing "override" keyword.  However, in
folly/wangle/channel/test/MockChannelHandler.h, I chose
to ignore those warnings for the mocked functions.
* folly/futures/test/ViaTest.cpp: Add missing "override"(s).
* folly/io/async/AsyncSSLSocket.h: Likewise.
* folly/io/async/AsyncSocket.h: Likewise.
* folly/io/async/EventBase.h: Likewise.
* folly/test/ExceptionWrapperTest.cpp: Likewise.
* folly/wangle/channel/AsyncSocketHandler.h: Likewise.
* folly/wangle/channel/test/MockChannelHandler.h: Ignore
the new warning for these functions.

Test Plan:
Run these commands and note there are fewer errors than before:
fbconfig --clang --with-project-version=clang:dev -r folly && fbmake dbgo

Reviewed By: hans@fb.com

Subscribers: trunkagent, fugalh, folly-diffs@, jsedgwick, yfeldblum

FB internal diff: D1848330

Tasks: 6244745

Signature: t1:1848330:1423858909:b167ca220d6c9fe036d3adca08cf3053a7a9de16
folly/futures/test/ViaTest.cpp
folly/io/async/AsyncSSLSocket.h
folly/io/async/AsyncSocket.h
folly/io/async/EventBase.h
folly/test/ExceptionWrapperTest.cpp
folly/wangle/channel/AsyncSocketHandler.h
folly/wangle/channel/test/MockChannelHandler.h