Remove constructor version attribute on OS X
authorJosh Watzman <jwatzman@fb.com>
Wed, 13 Aug 2014 22:05:12 +0000 (15:05 -0700)
committerSara Golemon <sgolemon@fb.com>
Thu, 14 Aug 2014 18:49:04 +0000 (11:49 -0700)
commitbe419a8edc10bc8a6b21bac0efc7ac9a0d88107b
tree61e519f30a2ba70a163510fdadd4f8ece1c836ee
parent747f8a8ecd2513c43b605591147f68b52b5276d1
Remove constructor version attribute on OS X

Summary:
OS X doesn't support this -- it requires support at the linker
level which OS X just doesn't have. Reasonable OS X compilers will yell
about it, but even the ones that don't are just silently dropping it
on the floor.

So I'm not sure what //we// can do other than just silently dropping
this on the floor too and hoping that everything works.

Test Plan:
HHVM build on OS X gets ever so slightly further (runs into
other issues). HHVM build in fbcode still seems to build folly okay
(didn't wait for it to finish fully).

Fixes https://github.com/facebook/folly/issues/78

Reviewed By: tudorb@fb.com

FB internal diff: D1487191

Blame Revision: rFBCODE502be7cb0fda306ddc33b9c5ad7a53b0cfbdc893
folly/VersionCheck.h