Fix infinite recursion in sorted_vector_{set|map}::insert(const value_type&)
authorChristopher Dykes <cdykes@fb.com>
Fri, 17 Jun 2016 01:12:47 +0000 (18:12 -0700)
committerFacebook Github Bot 9 <facebook-github-bot-9-bot@fb.com>
Fri, 17 Jun 2016 01:23:22 +0000 (18:23 -0700)
commitb57cfc00ce7e280fb89a421fc2402cfcc14337b7
treee3d66475ae9716410eff618752b38644f66fca3e
parent0f2aacae3d558f5cf54751b170c4e50d5483cc29
Fix infinite recursion in sorted_vector_{set|map}::insert(const value_type&)

Summary:
We were calling ourself, which MSVC correctly identified:
```
warning C4717: 'folly::sorted_vector_set<int,`anonymous namespace'::less_invert<int>,std::allocator<int>,void>::insert': recursive on all control paths, function will cause runtime stack overflow
```

Just add an explicit `std::move` in to solve the problem.

Reviewed By: yfeldblum

Differential Revision: D3447922

fbshipit-source-id: 803f79510b3dbfeea32a9629238448f69f5b78dc
folly/sorted_vector_types.h