fix detachPipeline/attachPipeline ordering
authorJames Sedgwick <jsedgwick@fb.com>
Mon, 27 Apr 2015 19:12:53 +0000 (12:12 -0700)
committerAndrii Grynenko <andrii@fb.com>
Wed, 29 Apr 2015 22:56:41 +0000 (15:56 -0700)
commit9eed30ddfdcc53b0d17fa72299ea96cde16cc52b
treef1f5047b2bc91b464947ce72940d17ea95a9d3e2
parent03ec96f3b1ba35a8a55e1b89394e863d2936eca9
fix detachPipeline/attachPipeline ordering

Summary:
detachPipeline always goes bottom to top
attachPipeline always goes top to bottom
now we can attachReadCallback in AsyncSocketHandler::attachPipeline()

not sure of the implications for TAsyncTransportHandler... looks like Cpp2Channel still wants to attach/detach cb manually

Test Plan: unit

Reviewed By: davejwatson@fb.com

Subscribers: fugalh, folly-diffs@, jsedgwick, yfeldblum, chalfant

FB internal diff: D2023982

Tasks: 6836580

Signature: t1:2023982:1430157500:e09a4103550a3e5721effaa1b28ac5bed071fa67
folly/wangle/channel/AsyncSocketHandler.h
folly/wangle/channel/HandlerContext.h
folly/wangle/channel/Pipeline.h
folly/wangle/channel/StaticPipeline.h
folly/wangle/channel/test/PipelineTest.cpp
folly/wangle/service/ServiceTest.cpp