SSL cleanup: moving some OpenSSL definitions to new dir folly/io/async/ssl
authorAnirudh Ramachandran <avr@fb.com>
Wed, 9 Mar 2016 02:09:22 +0000 (18:09 -0800)
committerFacebook Github Bot 1 <facebook-github-bot-1-bot@fb.com>
Wed, 9 Mar 2016 02:20:19 +0000 (18:20 -0800)
commit4700a31c198bf9d5a6bb58eb24fd97941f59d7ec
treefab539ca4d4161f490474b7e8b58e45f26dcd0b1
parente756d07cd35714d7528444321ea5145b41f5ae0f
SSL cleanup: moving some OpenSSL definitions to new dir folly/io/async/ssl

Summary:SSLContext and AsyncSSLSocket are growing with a lot of code that is
OpenSSL-specific, and it may be good to refactor some of these before it gets
out of hand.

This is also useful to reduce complexity as we some additional features such as ServerHello parsing and TLS Cached Info (D2936570)

Main changes:
 * Created a subdirectory folly/io/async/ssl to refactor code from folly/io/async. We may want to consider moving this out of folly/io/async
 * Moved OpenSSLPtrTypes.h to folly/io/async/ssl/OpenSSLPtrTypes.h
 * Moved 'OpenSSLUtils' from SSLContext to separate file OpenSSLUtils.{h,cpp}
 * Moved TLSExtensions and ClientHelloInfo from AsyncSSLSocket to TLSDefinitions.h

Reviewed By: siyengar

Differential Revision: D2978707

fb-gh-sync-id: a21f02947aeffccc447da2124a91cc99315df1c7
shipit-source-id: a21f02947aeffccc447da2124a91cc99315df1c7
12 files changed:
folly/Makefile.am
folly/io/async/AsyncSSLSocket.cpp
folly/io/async/AsyncSSLSocket.h
folly/io/async/AsyncTransport.h
folly/io/async/OpenSSLPtrTypes.h [deleted file]
folly/io/async/SSLContext.cpp
folly/io/async/SSLContext.h
folly/io/async/ssl/OpenSSLPtrTypes.h [new file with mode: 0644]
folly/io/async/ssl/OpenSSLUtils.cpp [new file with mode: 0644]
folly/io/async/ssl/OpenSSLUtils.h [new file with mode: 0644]
folly/io/async/ssl/TLSDefinitions.h [new file with mode: 0644]
folly/io/async/test/AsyncSSLSocketTest.cpp