Fix clang folly::to failure
authorTom Conerly <tconerly@fb.com>
Tue, 18 Feb 2014 07:10:21 +0000 (23:10 -0800)
committerDave Watson <davejwatson@fb.com>
Fri, 28 Feb 2014 22:00:27 +0000 (14:00 -0800)
commit22059a230a11a010d2939cdfc3e4a933b0410e32
treebb19fae596428f159f8c65302691476930b96752
parenta88bcd70b7a8a3e485a9fa575d62c12adf0fa95a
Fix clang folly::to failure

Summary:
Converting an enum class to a string fails with clang.
Adfinder clang build failure is http://ci-fbcode.fb.com:8080/builders/project/builds/146520/steps/build/logs/stdio
Our version of clang supports std::underlying_type so use that implementation instead.

Test Plan:
fbconfig -r folly && fbmake runtests (only failure is folly/experimental/symbolizer/test:symbolizer_test which failed before this diff)
fbconfig --clang folly/test:conv_test && fbmake runtests (fbconfig -r --clang folly fails and fbconfig --clang folly/test && fbmake has some unrelated compile errors)
Build adfinder with clang

Reviewed By: delong.j@fb.com

FB internal diff: D1178770
folly/Conv.h
folly/test/ConvTest.cpp