(Wangle) Clean up move constructors
authorHannes Roth <hannesr@fb.com>
Thu, 19 Feb 2015 21:10:26 +0000 (13:10 -0800)
committerAlecs King <int@fb.com>
Tue, 3 Mar 2015 03:25:18 +0000 (19:25 -0800)
commit0fd618d490aa1bf59d1b75e81b7615561e20c46c
tree4bf40c55d4610568953fd8146f495491fbf7e09a
parent37dd79a6f610efbb8932b2d2ed52339ed4fe7baf
(Wangle) Clean up move constructors

Summary:
These were doing more assignments than necessary.
1) We don't need to set `core_` to `nullptr` and then immediately
overwrite it with `other.core_`.
2) Don't need to swap the booleans (this was actually an unitialized
memory access).

Test Plan: Ran all the tests.

Reviewed By: hans@fb.com

Subscribers: trunkagent, folly-diffs@, jsedgwick, yfeldblum

FB internal diff: D1852386

Signature: t1:1852386:1424375154:25997209e76ccd16169125597e868932a5143ffb
folly/futures/Future-inl.h
folly/futures/Future.h
folly/futures/Promise-inl.h
folly/futures/Promise.h