X-Git-Url: http://plrg.eecs.uci.edu/git/?p=folly.git;a=blobdiff_plain;f=folly%2Fexperimental%2FDynamicParser.cpp;h=6e07ff71f1c0891c807efd764561389cf14b4892;hp=18dd25fd1b5baab04ca6412e9f9c13618cf29ec7;hb=5277a636b62a8f9c80756012de9bae80358ee30e;hpb=f3f4bcfb67d95e56887204081c94141aae4c89bc diff --git a/folly/experimental/DynamicParser.cpp b/folly/experimental/DynamicParser.cpp index 18dd25fd..6e07ff71 100644 --- a/folly/experimental/DynamicParser.cpp +++ b/folly/experimental/DynamicParser.cpp @@ -1,5 +1,5 @@ /* - * Copyright 2016 Facebook, Inc. + * Copyright 2016-present Facebook, Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -42,7 +42,7 @@ folly::dynamic& insertAtKey( "Unsupported key type ", key.typeName(), " of ", detail::toPseudoJson(key) ); } -} // anonymous namespace +} // namespace void DynamicParser::reportError( const folly::dynamic* lookup_k, @@ -96,7 +96,6 @@ void DynamicParser::reportError( break; // Continue parsing case OnError::THROW: stack_.throwErrors(); // Package releaseErrors() into an exception. - LOG(FATAL) << "Not reached"; // silence lint false positive default: LOG(FATAL) << "Bad onError_: " << static_cast(onError_); } @@ -118,14 +117,11 @@ void DynamicParser::ParserStack::Pop::operator()() noexcept { } } -folly::ScopeGuardImpl -DynamicParser::ParserStack::push( +DynamicParser::ParserStack::PopGuard DynamicParser::ParserStack::push( const folly::dynamic& k, const folly::dynamic& v) noexcept { // Save the previous state of the parser. - folly::ScopeGuardImpl guard( - DynamicParser::ParserStack::Pop(this) - ); + DynamicParser::ParserStack::PopGuard guard{this}; key_ = &k; value_ = &v; // We create errors_ sub-objects lazily to keep the result small. @@ -188,6 +184,6 @@ std::string toPseudoJson(const folly::dynamic& d) { ss << d; return ss.str(); } -} // namespace detail +} // namespace detail -} // namespace folly +} // namespace folly