/*
- * Copyright 2014 Facebook, Inc.
+ * Copyright 2017 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* limitations under the License.
*/
-#include "folly/Uri.h"
+#include <folly/Uri.h>
+#include <folly/portability/GTest.h>
#include <boost/algorithm/string.hpp>
#include <glog/logging.h>
-#include <gtest/gtest.h>
+#include <map>
using namespace folly;
-namespace {
-
-} // namespace
-
TEST(Uri, Simple) {
{
fbstring s("http://www.facebook.com/hello/world?query#fragment");
EXPECT_EQ("/etc/motd", u.path());
EXPECT_EQ("", u.query());
EXPECT_EQ("", u.fragment());
- EXPECT_EQ("file:///etc/motd", u.fbstr());
+ EXPECT_EQ("file:/etc/motd", u.fbstr());
}
{
EXPECT_EQ(s, u.fbstr());
}
+ {
+ // test query parameters
+ fbstring s("http://localhost?&key1=foo&key2=&key3&=bar&=bar=&");
+ Uri u(s);
+ auto paramsList = u.getQueryParams();
+ std::map<fbstring, fbstring> params;
+ for (auto& param : paramsList) {
+ params[param.first] = param.second;
+ }
+ EXPECT_EQ(3, params.size());
+ EXPECT_EQ("foo", params["key1"]);
+ EXPECT_NE(params.end(), params.find("key2"));
+ EXPECT_EQ("", params["key2"]);
+ EXPECT_NE(params.end(), params.find("key3"));
+ EXPECT_EQ("", params["key3"]);
+ }
+
+ {
+ // test query parameters
+ fbstring s("http://localhost?&&&&&&&&&&&&&&&");
+ Uri u(s);
+ auto params = u.getQueryParams();
+ EXPECT_TRUE(params.empty());
+ }
+
+ {
+ // test query parameters
+ fbstring s("http://localhost?&=invalid_key&key2&key3=foo");
+ Uri u(s);
+ auto paramsList = u.getQueryParams();
+ std::map<fbstring, fbstring> params;
+ for (auto& param : paramsList) {
+ params[param.first] = param.second;
+ }
+ EXPECT_EQ(2, params.size());
+ EXPECT_NE(params.end(), params.find("key2"));
+ EXPECT_EQ("", params["key2"]);
+ EXPECT_EQ("foo", params["key3"]);
+ }
+
+ {
+ // test query parameters
+ fbstring s("http://localhost?&key1=====&&=key2&key3=");
+ Uri u(s);
+ auto paramsList = u.getQueryParams();
+ std::map<fbstring, fbstring> params;
+ for (auto& param : paramsList) {
+ params[param.first] = param.second;
+ }
+ EXPECT_EQ(1, params.size());
+ EXPECT_NE(params.end(), params.find("key3"));
+ EXPECT_EQ("", params["key3"]);
+ }
+
+ {
+ // test query parameters
+ fbstring s("http://localhost?key1=foo=bar&key2=foobar&");
+ Uri u(s);
+ auto paramsList = u.getQueryParams();
+ std::map<fbstring, fbstring> params;
+ for (auto& param : paramsList) {
+ params[param.first] = param.second;
+ }
+ EXPECT_EQ(1, params.size());
+ EXPECT_EQ("foobar", params["key2"]);
+ }
+
{
fbstring s("2http://www.facebook.com");
try {
Uri u(s);
CHECK(false) << "Control should not have reached here";
- } catch (const std::invalid_argument& ex) {
+ } catch (const std::invalid_argument&) {
// success
}
}
try {
Uri u(s);
CHECK(false) << "Control should not have reached here";
- } catch (const std::invalid_argument& ex) {
+ } catch (const std::invalid_argument&) {
// success
}
}
try {
Uri u(s);
CHECK(false) << "Control should not have reached here";
- } catch (const std::invalid_argument& ex) {
+ } catch (const std::invalid_argument&) {
// success
}
}
try {
Uri u(s);
CHECK(false) << "Control should not have reached here";
- } catch (const std::invalid_argument& ex) {
+ } catch (const std::invalid_argument&) {
// success
}
}
+
+ // No authority (no "//") is valid
+ {
+ fbstring s("this:is/a/valid/uri");
+ Uri u(s);
+ EXPECT_EQ("this", u.scheme());
+ EXPECT_EQ("is/a/valid/uri", u.path());
+ EXPECT_EQ(s, u.fbstr());
+ }
+ {
+ fbstring s("this:is:another:valid:uri");
+ Uri u(s);
+ EXPECT_EQ("this", u.scheme());
+ EXPECT_EQ("is:another:valid:uri", u.path());
+ EXPECT_EQ(s, u.fbstr());
+ }
+ {
+ fbstring s("this:is@another:valid:uri");
+ Uri u(s);
+ EXPECT_EQ("this", u.scheme());
+ EXPECT_EQ("is@another:valid:uri", u.path());
+ EXPECT_EQ(s, u.fbstr());
+ }
}