#include <folly/io/async/EventBase.h>
-#include <folly/ThreadName.h>
-#include <folly/io/async/NotificationQueue.h>
-#include <folly/portability/Unistd.h>
-
-#include <condition_variable>
#include <fcntl.h>
+
+#include <memory>
#include <mutex>
-#include <pthread.h>
+#include <thread>
+
+#include <folly/Baton.h>
+#include <folly/Memory.h>
+#include <folly/io/async/NotificationQueue.h>
+#include <folly/io/async/VirtualEventBase.h>
+#include <folly/portability/Unistd.h>
+#include <folly/system/ThreadName.h>
namespace folly {
class EventBase::FunctionRunner
: public NotificationQueue<EventBase::Func>::Consumer {
public:
- void messageAvailable(Func&& msg) override {
+ void messageAvailable(Func&& msg) noexcept override {
// In libevent2, internal events do not break the loop.
// Most users would expect loop(), followed by runInEventBaseThread(),
// to break the loop and check if it should exit or not.
// wake up the loop. We can ignore these messages.
return;
}
-
- // The function should never throw an exception, because we have no
- // way of knowing what sort of error handling to perform.
- //
- // If it does throw, log a message and abort the program.
- try {
- msg();
- } catch (const std::exception& ex) {
- LOG(ERROR) << "runInEventBaseThread() function threw a "
- << typeid(ex).name() << " exception: " << ex.what();
- abort();
- } catch (...) {
- LOG(ERROR) << "runInEventBaseThread() function threw an exception";
- abort();
- }
+ msg();
}
};
, queue_(nullptr)
, fnRunner_(nullptr)
, maxLatency_(0)
- , avgLoopTime_(std::chrono::milliseconds(2000000))
+ , avgLoopTime_(std::chrono::seconds(2))
, maxLatencyLoopTime_(avgLoopTime_)
, enableTimeMeasurement_(enableTimeMeasurement)
, nextLoopCnt_(uint64_t(-40)) // Early wrap-around so bugs will manifest soon
, latestLoopCnt_(nextLoopCnt_)
- , startWork_(0)
+ , startWork_()
, observer_(nullptr)
, observerSampleCount_(0)
, executionObserver_(nullptr) {
// The value 'current_base' (libevent 1) or
// 'event_global_current_base_' (libevent 2) is filled in by event_set(),
// allowing examination of its value without an explicit reference here.
- // If ev.ev_base is NULL, then event_init() must be called, otherwise
+ // If ev.ev_base is nullptr, then event_init() must be called, otherwise
// call event_base_new().
event_set(&ev, 0, 0, nullptr, nullptr);
if (!ev.ev_base) {
}
VLOG(5) << "EventBase(): Created.";
initNotificationQueue();
- RequestContext::saveContext();
}
// takes ownership of the event_base
, queue_(nullptr)
, fnRunner_(nullptr)
, maxLatency_(0)
- , avgLoopTime_(std::chrono::milliseconds(2000000))
+ , avgLoopTime_(std::chrono::seconds(2))
, maxLatencyLoopTime_(avgLoopTime_)
, enableTimeMeasurement_(enableTimeMeasurement)
, nextLoopCnt_(uint64_t(-40)) // Early wrap-around so bugs will manifest soon
, latestLoopCnt_(nextLoopCnt_)
- , startWork_(0)
+ , startWork_()
, observer_(nullptr)
, observerSampleCount_(0)
, executionObserver_(nullptr) {
throw std::invalid_argument("EventBase(): event base cannot be nullptr");
}
initNotificationQueue();
- RequestContext::saveContext();
}
EventBase::~EventBase() {
+ std::future<void> virtualEventBaseDestroyFuture;
+ if (virtualEventBase_) {
+ virtualEventBaseDestroyFuture = virtualEventBase_->destroy();
+ }
+
// Keep looping until all keep-alive handles are released. Each keep-alive
// handle signals that some external code will still schedule some work on
// this EventBase (so it's not safe to destroy it).
loopOnce();
}
+ if (virtualEventBaseDestroyFuture.valid()) {
+ virtualEventBaseDestroyFuture.get();
+ }
+
// Call all destruction callbacks, before we start cleaning up our state.
while (!onDestructionCallbacks_.empty()) {
LoopCallback* callback = &onDestructionCallbacks_.front();
clearCobTimeouts();
- DCHECK_EQ(0, runBeforeLoopCallbacks_.size());
+ DCHECK_EQ(0u, runBeforeLoopCallbacks_.size());
(void)runLoopCallbacks();
event_base_free(evb_);
}
- {
- std::lock_guard<std::mutex> lock(localStorageMutex_);
- for (auto storage : localStorageToDtor_) {
- storage->onEventBaseDestruction(*this);
- }
+ for (auto storage : localStorageToDtor_) {
+ storage->onEventBaseDestruction(*this);
}
+
VLOG(5) << "EventBase(): Destroyed.";
}
fnRunner_->setMaxReadAtOnce(maxAtOnce);
}
+void EventBase::checkIsInEventBaseThread() const {
+ auto evbTid = loopThread_.load(std::memory_order_relaxed);
+ if (evbTid == std::thread::id()) {
+ return;
+ }
+
+ // Using getThreadName(evbTid) instead of name_ will work also if
+ // the thread name is set outside of EventBase (and name_ is empty).
+ auto curTid = std::this_thread::get_id();
+ CHECK(evbTid == curTid)
+ << "This logic must be executed in the event base thread. "
+ << "Event base thread name: \""
+ << folly::getThreadName(evbTid).value_or("")
+ << "\", current thread name: \""
+ << folly::getThreadName(curTid).value_or("") << "\"";
+}
+
// Set smoothing coefficient for loop load average; input is # of milliseconds
// for exp(-1) decay.
-void EventBase::setLoadAvgMsec(uint32_t ms) {
+void EventBase::setLoadAvgMsec(std::chrono::milliseconds ms) {
assert(enableTimeMeasurement_);
std::chrono::microseconds us = std::chrono::milliseconds(ms);
- if (ms > 0) {
+ if (ms > std::chrono::milliseconds::zero()) {
maxLatencyLoopTime_.setTimeInterval(us);
avgLoopTime_.setTimeInterval(us);
} else {
void EventBase::waitUntilRunning() {
while (!isRunning()) {
- sched_yield();
+ std::this_thread::yield();
}
}
// time-measurement variables.
std::chrono::steady_clock::time_point prev;
- int64_t idleStart = 0;
- int64_t busy;
- int64_t idle;
+ std::chrono::steady_clock::time_point idleStart = {};
+ std::chrono::microseconds busy;
+ std::chrono::microseconds idle;
- loopThread_.store(pthread_self(), std::memory_order_release);
+ loopThread_.store(std::this_thread::get_id(), std::memory_order_release);
if (!name_.empty()) {
setThreadName(name_);
if (enableTimeMeasurement_) {
prev = std::chrono::steady_clock::now();
- idleStart = std::chrono::duration_cast<std::chrono::microseconds>(
- std::chrono::steady_clock::now().time_since_epoch()).count();
+ idleStart = std::chrono::steady_clock::now();
}
while (!stop_.load(std::memory_order_acquire)) {
if (enableTimeMeasurement_) {
busy = std::chrono::duration_cast<std::chrono::microseconds>(
- std::chrono::steady_clock::now().time_since_epoch()).count() -
- startWork_;
- idle = startWork_ - idleStart;
+ std::chrono::steady_clock::now() - startWork_);
+ idle = std::chrono::duration_cast<std::chrono::microseconds>(
+ startWork_ - idleStart);
avgLoopTime_.addSample(std::chrono::microseconds(idle),
std::chrono::microseconds(busy));
if (observer_) {
if (observerSampleCount_++ == observer_->getSampleRate()) {
observerSampleCount_ = 0;
- observer_->loopSample(busy, idle);
+ observer_->loopSample(busy.count(), idle.count());
}
}
- VLOG(11) << "EventBase " << this << " did not timeout "
- " loop time guess: " << busy + idle <<
- " idle time: " << idle <<
- " busy time: " << busy <<
+ VLOG(11) << "EventBase " << this << " did not timeout " <<
+ " loop time guess: " << (busy + idle).count() <<
+ " idle time: " << idle.count() <<
+ " busy time: " << busy.count() <<
" avgLoopTime: " << avgLoopTime_.get() <<
" maxLatencyLoopTime: " << maxLatencyLoopTime_.get() <<
- " maxLatency_: " << maxLatency_ <<
+ " maxLatency_: " << maxLatency_.count() << "us" <<
" notificationQueueSize: " << getNotificationQueueSize() <<
- " nothingHandledYet(): "<< nothingHandledYet();
+ " nothingHandledYet(): " << nothingHandledYet();
// see if our average loop time has exceeded our limit
- if ((maxLatency_ > 0) &&
- (maxLatencyLoopTime_.get() > double(maxLatency_))) {
+ if ((maxLatency_ > std::chrono::microseconds::zero()) &&
+ (maxLatencyLoopTime_.get() > double(maxLatency_.count()))) {
maxLatencyCob_();
// back off temporarily -- don't keep spamming maxLatencyCob_
// if we're only a bit over the limit
}
// Our loop run did real work; reset the idle timer
- idleStart = std::chrono::duration_cast<std::chrono::microseconds>(
- std::chrono::steady_clock::now().time_since_epoch()).count();
+ idleStart = std::chrono::steady_clock::now();
} else {
VLOG(11) << "EventBase " << this << " did not timeout";
}
}
if (enableTimeMeasurement_) {
- VLOG(5) << "EventBase " << this << " loop time: " <<
+ VLOG(11) << "EventBase " << this << " loop time: " <<
getTimeDelta(&prev).count();
}
loopKeepAliveCountAtomic_.exchange(0, std::memory_order_relaxed);
}
DCHECK_GE(loopKeepAliveCount_, 0);
+
return loopKeepAliveCount_;
}
void EventBase::applyLoopKeepAlive() {
- if (loopKeepAliveActive_ && loopKeepAliveCount() == 0) {
+ auto keepAliveCount = loopKeepAliveCount();
+ // Make sure default VirtualEventBase won't hold EventBase::loop() forever.
+ if (virtualEventBase_ && virtualEventBase_->keepAliveCount() == 1) {
+ --keepAliveCount;
+ }
+
+ if (loopKeepAliveActive_ && keepAliveCount == 0) {
// Restore the notification queue internal flag
fnRunner_->stopConsuming();
fnRunner_->startConsumingInternal(this, queue_.get());
loopKeepAliveActive_ = false;
- } else if (!loopKeepAliveActive_ && loopKeepAliveCount() > 0) {
+ } else if (!loopKeepAliveActive_ && keepAliveCount > 0) {
// Update the notification queue event to treat it as a normal
// (non-internal) event. The notification queue event always remains
// installed, and the main loop won't exit with it installed.
if (nothingHandledYet()) {
latestLoopCnt_ = nextLoopCnt_;
// set the time
- startWork_ = std::chrono::duration_cast<std::chrono::microseconds>(
- std::chrono::steady_clock::now().time_since_epoch())
- .count();
+ startWork_ = std::chrono::steady_clock::now();
VLOG(11) << "EventBase " << this << " " << __PRETTY_FUNCTION__
- << " (loop) startWork_ " << startWork_;
+ << " (loop) startWork_ " << startWork_.time_since_epoch().count();
}
}
}
void EventBase::runInLoop(LoopCallback* callback, bool thisIteration) {
- DCHECK(isInEventBaseThread());
+ dcheckIsInEventBaseThread();
callback->cancelLoopCallback();
callback->context_ = RequestContext::saveContext();
if (runOnceCallbacks_ != nullptr && thisIteration) {
}
void EventBase::runInLoop(Func cob, bool thisIteration) {
- DCHECK(isInEventBaseThread());
+ dcheckIsInEventBaseThread();
auto wrapper = new FunctionLoopCallback(std::move(cob));
wrapper->context_ = RequestContext::saveContext();
if (runOnceCallbacks_ != nullptr && thisIteration) {
}
void EventBase::runBeforeLoop(LoopCallback* callback) {
- DCHECK(isInEventBaseThread());
+ dcheckIsInEventBaseThread();
callback->cancelLoopCallback();
runBeforeLoopCallbacks_.push_back(*callback);
}
if (inRunningEventBaseThread()) {
runInLoop(std::move(fn));
return true;
-
}
try {
return true;
}
-bool EventBase::runInEventBaseThreadAndWait(FuncRef fn) {
+bool EventBase::runInEventBaseThreadAndWait(Func fn) {
if (inRunningEventBaseThread()) {
LOG(ERROR) << "EventBase " << this << ": Waiting in the event loop is not "
<< "allowed";
return false;
}
- bool ready = false;
- std::mutex m;
- std::condition_variable cv;
- runInEventBaseThread([&] {
- SCOPE_EXIT {
- std::unique_lock<std::mutex> l(m);
- ready = true;
- cv.notify_one();
- // We cannot release the lock before notify_one, because a spurious
- // wakeup in the waiting thread may lead to cv and m going out of scope
- // prematurely.
- };
- fn();
+ Baton<> ready;
+ runInEventBaseThread([&ready, fn = std::move(fn)]() mutable {
+ SCOPE_EXIT {
+ ready.post();
+ };
+ // A trick to force the stored functor to be executed and then destructed
+ // before posting the baton and waking the waiting thread.
+ copy(std::move(fn))();
});
- std::unique_lock<std::mutex> l(m);
- cv.wait(l, [&] { return ready; });
+ ready.wait();
return true;
}
-bool EventBase::runImmediatelyOrRunInEventBaseThreadAndWait(FuncRef fn) {
+bool EventBase::runImmediatelyOrRunInEventBaseThreadAndWait(Func fn) {
if (isInEventBaseThread()) {
fn();
return true;
while (!currentCallbacks.empty()) {
LoopCallback* callback = ¤tCallbacks.front();
currentCallbacks.pop_front();
- folly::RequestContextScopeGuard rctx(callback->context_);
+ folly::RequestContextScopeGuard rctx(std::move(callback->context_));
callback->runLoopCallback();
}
void EventBase::initNotificationQueue() {
// Infinite size queue
- queue_.reset(new NotificationQueue<Func>());
+ queue_ = std::make_unique<NotificationQueue<Func>>();
// We allocate fnRunner_ separately, rather than declaring it directly
// as a member of EventBase solely so that we don't need to include
// NotificationQueue.h from EventBase.h
- fnRunner_.reset(new FunctionRunner());
+ fnRunner_ = std::make_unique<FunctionRunner>();
// Mark this as an internal event, so event_base_loop() will return if
// there are no other events besides this one installed.
bool EventBase::scheduleTimeout(AsyncTimeout* obj,
TimeoutManager::timeout_type timeout) {
- assert(isInEventBaseThread());
+ dcheckIsInEventBaseThread();
// Set up the timeval and add the event
struct timeval tv;
tv.tv_sec = long(timeout.count() / 1000LL);
}
void EventBase::cancelTimeout(AsyncTimeout* obj) {
- assert(isInEventBaseThread());
+ dcheckIsInEventBaseThread();
struct event* ev = obj->getEvent();
if (EventUtil::isEventRegistered(ev)) {
event_del(ev);
}
void EventBase::setName(const std::string& name) {
- assert(isInEventBaseThread());
+ dcheckIsInEventBaseThread();
name_ = name;
if (isRunning()) {
}
const std::string& EventBase::getName() {
- assert(isInEventBaseThread());
+ dcheckIsInEventBaseThread();
return name_;
}
const char* EventBase::getLibeventVersion() { return event_get_version(); }
const char* EventBase::getLibeventMethod() { return event_get_method(); }
-} // folly
+VirtualEventBase& EventBase::getVirtualEventBase() {
+ folly::call_once(virtualEventBaseInitFlag_, [&] {
+ virtualEventBase_ = std::make_unique<VirtualEventBase>(*this);
+ });
+
+ return *virtualEventBase_;
+}
+
+} // namespace folly
projects / folly.git / blobdiff