Swap a few APIs to reduce sign and implicit truncations required to work with it

[folly.git] / folly / detail / CacheLocality.cpp

diff --git a/folly/detail/CacheLocality.cpp b/folly/detail/CacheLocality.cpp
index 7b9f7e9d81a5d02d400cab808e70672f5036ecc4..09da2871592999375cfa38f3b29227347678da4e 100644 (file)
--- a/folly/detail/CacheLocality.cpp
+++ b/folly/detail/CacheLocality.cpp
@@ -156,11 +156,12 @@ CacheLocality CacheLocality::readFromSysfsTree(
               // a sub-optimal ordering, but it won't crash
               auto& lhsEquiv = equivClassesByCpu[lhs];
               auto& rhsEquiv = equivClassesByCpu[rhs];
-              for (int i = int(std::min(lhsEquiv.size(), rhsEquiv.size())) - 1;
+              for (ssize_t i = ssize_t(std::min(lhsEquiv.size(), rhsEquiv.size())) - 1;
                    i >= 0;
                    --i) {
-                if (lhsEquiv[i] != rhsEquiv[i]) {
-                  return lhsEquiv[i] < rhsEquiv[i];
+                auto idx = size_t(i);
+                if (lhsEquiv[idx] != rhsEquiv[idx]) {
+                  return lhsEquiv[idx] < rhsEquiv[idx];
                 }
               }