Mark constructing an Unexpected as cold

[folly.git] / folly / Expected.h

diff --git a/folly/Expected.h b/folly/Expected.h
index f15010dfe821600c58c1221e6739870b743af1f5..2705f33533e7e95fc43b191b9611f74e9f9f422e 100644 (file)
--- a/folly/Expected.h
+++ b/folly/Expected.h
@@ -31,6 +31,7 @@
 
 #include <glog/logging.h>
 
 
 #include <glog/logging.h>
 

+#include <folly/CppAttributes.h>

 #include <folly/Likely.h>
 #include <folly/Optional.h>
 #include <folly/Portability.h>
 #include <folly/Likely.h>
 #include <folly/Optional.h>
 #include <folly/Portability.h>


@@ -711,8 +712,10 @@ class Unexpected final {
   Unexpected(Unexpected&&) = default;
   Unexpected& operator=(const Unexpected&) = default;
   Unexpected& operator=(Unexpected&&) = default;
   Unexpected(Unexpected&&) = default;
   Unexpected& operator=(const Unexpected&) = default;
   Unexpected& operator=(Unexpected&&) = default;

-  constexpr /* implicit */ Unexpected(const Error& err) : error_(err) {}
-  constexpr /* implicit */ Unexpected(Error&& err) : error_(std::move(err)) {}
+  FOLLY_COLD constexpr /* implicit */ Unexpected(const Error& err)
+      : error_(err) {}
+  FOLLY_COLD constexpr /* implicit */ Unexpected(Error&& err)
+      : error_(std::move(err)) {}

 
   template <class Other FOLLY_REQUIRES_TRAILING(
       std::is_constructible<Error, Other&&>::value)>
 
   template <class Other FOLLY_REQUIRES_TRAILING(
       std::is_constructible<Error, Other&&>::value)>