From: Tomasz Figa Date: Thu, 8 Sep 2016 09:52:00 +0000 (+0900) Subject: CHROMIUM: drm/rockchip: Fix the call to drm_gem_put_pages() X-Git-Tag: firefly_0821_release~1140 X-Git-Url: http://plrg.eecs.uci.edu/git/?p=firefly-linux-kernel-4.4.55.git;a=commitdiff_plain;h=909a224e0c038fb9a99353dc9ef8ad5cc67b1f4a CHROMIUM: drm/rockchip: Fix the call to drm_gem_put_pages() When freeing the buffer we don't have any means of determining if the buffer was read or written, so we must assume both and pass true for both arguments of drm_gem_put_pages(). Let's fix the code which currently passes false. BUG=chrome-os-partner:56378 TEST=while true; do backlight_dbus_tool --set --percent=0 && sleep 8 && backlight_dbus_tool --set --percent=100 && sleep 3 ; done Change-Id: I7da2fd81e7e728e0ef242837b70819c4a3aee7bf Signed-off-by: Tomasz Figa Reviewed-on: https://chromium-review.googlesource.com/382934 Reviewed-by: Daniel Kurtz Signed-off-by: Randy Li --- diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c index dbe08906f90b..9d544d1ba547 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c @@ -115,7 +115,7 @@ static void rockchip_gem_put_pages(struct rockchip_gem_object *rk_obj) { sg_free_table(rk_obj->sgt); kfree(rk_obj->sgt); - drm_gem_put_pages(&rk_obj->base, rk_obj->pages, false, false); + drm_gem_put_pages(&rk_obj->base, rk_obj->pages, true, true); } static int rockchip_gem_alloc_iommu(struct rockchip_gem_object *rk_obj,