[PARISC] fix panic on prefetch(NULL) on PA7300LC
authorJames Bottomley <JBottomley@Parallels.com>
Wed, 16 May 2012 10:10:27 +0000 (11:10 +0100)
committerJames Bottomley <JBottomley@Parallels.com>
Wed, 16 May 2012 12:15:21 +0000 (13:15 +0100)
Due to an errata, the PA7300LC generates a TLB miss interruption even on the
prefetch instruction.  This means that prefetch(NULL), which is supposed to be
a nop on linux actually generates a NULL deref fault.  Fix this by testing the
address of prefetch against NULL before doing the prefetch.

Cc: stable@vger.kernel.org
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
arch/parisc/include/asm/prefetch.h

index c5edc60c059f08d0d7b610bdf9793a56db7af0f8..1ee7c82672c1c8791f995e5a61c6f0f30bbcf4c7 100644 (file)
 #define ARCH_HAS_PREFETCH
 static inline void prefetch(const void *addr)
 {
-       __asm__("ldw 0(%0), %%r0" : : "r" (addr));
+       __asm__(
+#ifndef CONFIG_PA20
+               /* Need to avoid prefetch of NULL on PA7300LC */
+               "       extrw,u,= %0,31,32,%%r0\n"
+#endif
+               "       ldw 0(%0), %%r0" : : "r" (addr));
 }
 
 /* LDD is a PA2.0 addition. */