SCSI: dual scan thread bug fix
authorJames Bottomley <JBottomley@Parallels.com>
Tue, 21 Jan 2014 15:01:41 +0000 (07:01 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 May 2014 04:52:11 +0000 (21:52 -0700)
commite623c2cdb5b9151e1ca8c846e2814977ba4dfcac
tree51d1d4484bb87179982bd44d872359b60d49dc8e
parentc3c8d397fef461c0b3a273f68abf9adffc85aa3a
SCSI: dual scan thread bug fix

commit f2495e228fce9f9cec84367547813cbb0d6db15a upstream.

In the highly unusual case where two threads are running concurrently through
the scanning code scanning the same target, we run into the situation where
one may allocate the target while the other is still using it.  In this case,
because the reap checks for STARGET_CREATED and kills the target without
reference counting, the second thread will do the wrong thing on reap.

Fix this by reference counting even creates and doing the STARGET_CREATED
check in the final put.

Tested-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/scsi_scan.c