ceph: fix error handling in ceph_read_iter
authorNikolay Borisov <kernel@kyup.com>
Mon, 10 Oct 2016 12:38:18 +0000 (15:38 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Oct 2016 07:01:35 +0000 (03:01 -0400)
commite382e130d45a9f95c8da77bc8bca1464ae9c6cae
tree74ccde9eade17430904aed8f2dd17c497e653b3f
parent08cd19c602145b75e2782831e1822f6fe7f560c9
ceph: fix error handling in ceph_read_iter

commit 0d7718f666be181fda1ba2d08f137d87c1419347 upstream.

In case __ceph_do_getattr returns an error and the retry_op in
ceph_read_iter is not READ_INLINE, then it's possible to invoke
__free_page on a page which is NULL, this naturally leads to a crash.
This can happen when, for example, a process waiting on a MDS reply
receives sigterm.

Fix this by explicitly checking whether the page is set or not.

Signed-off-by: Nikolay Borisov <kernel@kyup.com>
Reviewed-by: Yan, Zheng <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ceph/file.c