i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()
authorBrian Norris <briannorris@chromium.org>
Wed, 10 Aug 2016 20:37:18 +0000 (13:37 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 7 Sep 2016 06:32:43 +0000 (08:32 +0200)
commitd489412c69e3ff624413c516cfb7bea18eed6a6c
tree36b9cc7a52129436401ea0d2e8c84577d5bf6b73
parentd91c348e4c3a011849e309cb76a6fdc714935ea4
i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()

commit 4d01d88019261d05ec3bff5f1a6013393faa3b9e upstream.

cros_ec_cmd_xfer returns success status if the command transport
completes successfully, but the execution result is incorrectly ignored.
In many cases, the execution result is assumed to be successful, leading
to ignored errors and operating on uninitialized data.

We've recently introduced the cros_ec_cmd_xfer_status() helper to avoid these
problems. Let's use it.

[Regarding the 'Fixes' tag; there is significant refactoring since the driver's
introduction, but the underlying logical error exists throughout I believe]

Fixes: 9d230c9e4f4e ("i2c: ChromeOS EC tunnel driver")
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/i2c/busses/i2c-cros-ec-tunnel.c