netfilter: nfnetlink_log: work around uninitialized variable warning
authorArnd Bergmann <arnd@arndb.de>
Tue, 10 Nov 2015 12:08:15 +0000 (13:08 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Tue, 10 Nov 2015 22:46:36 +0000 (23:46 +0100)
commitc872a2d9e3627829591736ddd8e8710a0afb2f95
tree4ace90eaa55873ad5b4db8cc11f97b84cac87d5b
parentc255cb2ed3c7960b2c68f45de1dc0ac2197c8f78
netfilter: nfnetlink_log: work around uninitialized variable warning

After a recent (correct) change, gcc started warning about the use
of the 'flags' variable in nfulnl_recv_config()

net/netfilter/nfnetlink_log.c: In function 'nfulnl_recv_config':
net/netfilter/nfnetlink_log.c:320:14: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
net/netfilter/nfnetlink_log.c:828:6: note: 'flags' was declared here

The warning first shows up in ARM s3c2410_defconfig with gcc-4.3 or
higher (including 5.2.1, which is the latest version I checked) I
tried working around it by rearranging the code but had no success
with that.

As a last resort, this initializes the variable to zero, which shuts
up the warning, but means that we don't get a warning if the code
is ever changed in a way that actually causes the variable to be
used without first being written.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 8cbc870829ec ("netfilter: nfnetlink_log: validate dependencies to avoid breaking atomicity")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nfnetlink_log.c