sched: hmp: fix spinlock recursion in active migration
authorKevin Hilman <khilman@linaro.org>
Wed, 8 Apr 2015 21:32:07 +0000 (14:32 -0700)
committerJon Medhurst <tixy@linaro.org>
Tue, 14 Apr 2015 11:08:16 +0000 (12:08 +0100)
commitc1f0c1f51bf7b9111de27c3cdbea9b647351bf7b
tree5b20b095079b0578b249a0e721858f83ed2fe4bf
parente482d95c1d1888f34cc3f7e6778806cfda6174ff
sched: hmp: fix spinlock recursion in active migration

Commit cd5c2cc93d3d (hmp: Remove potential for task_struct access
race) introduced a put_task_struct() to prevent races, but in doing so
introduced potential spinlock recursion.  (This change was further
consolidated in commit 0baa5811bacf -- sched: hmp: unify active
migration code.)

Unfortunately, the put_task_struct() is done while the runqueue
spinlock is held, but put_task_struct() can also cause a reschedule
causing the runqueue lock to be acquired recursively.

To fix, move the put_task_struct() outside the runqueue spinlock.

Reported-by: Victor Lixin <victor.lixin@hisilicon.com>
Cc: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Cc: Liviu Dudau <Liviu.Dudau@arm.com>
Signed-off-by: Kevin Hilman <khilman@linaro.org>
Reviewed-by: Jon Medhurst <tixy@linaro.org>
Reviewed-by: Alex Shi <alex.shi@linaro.org>
Reviewed-by: Chris Redpath <chris.redpath@arm.com>
Signed-off-by: Jon Medhurst <tixy@linaro.org>
kernel/sched/fair.c