ASoC: sun4i-codec: return error code instead of NULL when create_card fails
authorChen-Yu Tsai <wens@csie.org>
Mon, 31 Oct 2016 06:42:09 +0000 (14:42 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 18 Nov 2016 09:48:37 +0000 (10:48 +0100)
commitae5b8dbfe6be87a736f1b41d737d70f6b2182cae
treec6b45ae155854f424395173765297fedb961ca76
parent125e84726d7c61cf10c5eb1b2e6c6df4b3fb3924
ASoC: sun4i-codec: return error code instead of NULL when create_card fails

commit 85915b63ad8b796848f431b66c9ba5e356e722e5 upstream.

When sun4i_codec_create_card fails, we do not assign a proper error
code to the return value. The return value would be 0 from the previous
function call, or we would have bailed out sooner. This would confuse
the driver core into thinking the device probe succeeded, when in fact
it didn't, leaving various devres based resources lingering.

Make the create_card function pass back a meaningful error code, and
assign it to the return value.

Fixes: 45fb6b6f2aa3 ("ASoC: sunxi: add support for the on-chip codec on
      early Allwinner SoCs")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/soc/sunxi/sun4i-codec.c