ALSA: firewire-tascam: accessing to user space outside spinlock
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Wed, 31 Aug 2016 11:15:32 +0000 (20:15 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 15 Sep 2016 06:27:53 +0000 (08:27 +0200)
commitad3bccfd7d6c0d9b263977492f2f712f1859b5b2
treeee362f7a0ce929dfc43aa5c6d9ced1bf8fca0286
parent9947ec2c04d30412a06e45a4af03f28c2d76d1f6
ALSA: firewire-tascam: accessing to user space outside spinlock

commit 04b2d9c9c319277ad4fbbb71855c256a9f4d5f98 upstream.

In hwdep interface of firewire-tascam driver, accessing to user space is
in a critical section with disabled local interrupt. Depending on
architecture, accessing to user space can cause page fault exception. Then
local processor stores machine status and handle the synchronous event. A
handler corresponding to the event can call task scheduler to wait for
preparing pages. In a case of usage of single core processor, the state to
disable local interrupt is worse because it doesn't handle usual interrupts
from hardware.

This commit fixes this bug, by performing the accessing outside spinlock.

Reported-by: Vaishali Thakkar <vaishali.thakkar@oracle.com>
Fixes: e5e0c3dd257b('ALSA: firewire-tascam: add hwdep interface')
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/firewire/tascam/tascam-hwdep.c