ubi: fastmap: Fix add_vol() return value test in ubi_attach_fastmap()
authorBoris Brezillon <boris.brezillon@free-electrons.com>
Fri, 28 Oct 2016 09:08:44 +0000 (11:08 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Nov 2016 15:36:37 +0000 (16:36 +0100)
commit69e14ce88389d9164e1e1c163af9f6c297cd1dfd
tree8f03ac15fce7255c2cbd8eee30a8c51f5e823738
parent91e1f7b0eb252ce8f88d69227ef5f52f9efb2aae
ubi: fastmap: Fix add_vol() return value test in ubi_attach_fastmap()

commit 40b6e61ac72e99672e47cdb99c8d7d226004169b upstream.

Commit e96a8a3bb671 ("UBI: Fastmap: Do not add vol if it already
exists") introduced a bug by changing the possible error codes returned
by add_vol():
- this function no longer returns NULL in case of allocation failure
  but return ERR_PTR(-ENOMEM)
- when a duplicate entry in the volume RB tree is found it returns
  ERR_PTR(-EEXIST) instead of ERR_PTR(-EINVAL)

Fix the tests done on add_vol() return val to match this new behavior.

Fixes: e96a8a3bb671 ("UBI: Fastmap: Do not add vol if it already exists")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Acked-by: Sheng Yong <shengyong1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mtd/ubi/fastmap.c