ipv4: Don't do expensive useless work during inetdev destroy.
authorDavid S. Miller <davem@davemloft.net>
Mon, 14 Mar 2016 03:28:00 +0000 (23:28 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Apr 2016 06:42:03 +0000 (15:42 +0900)
commit54789759917f127cfadcca730f44ea67d557a9b0
tree939e0f0561270b3e38772bb348e91d075599c0c0
parentacbea202fbba11c52df2fd4040c19bb796fd37fa
ipv4: Don't do expensive useless work during inetdev destroy.

[ Upstream commit fbd40ea0180a2d328c5adc61414dc8bab9335ce2 ]

When an inetdev is destroyed, every address assigned to the interface
is removed.  And in this scenerio we do two pointless things which can
be very expensive if the number of assigned interfaces is large:

1) Address promotion.  We are deleting all addresses, so there is no
   point in doing this.

2) A full nf conntrack table purge for every address.  We only need to
   do this once, as is already caught by the existing
   masq_dev_notifier so masq_inet_event() can skip this.

Reported-by: Solar Designer <solar@openwall.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Tested-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/devinet.c
net/ipv4/fib_frontend.c
net/ipv4/netfilter/nf_nat_masquerade_ipv4.c