tmpfs: clear S_ISGID when setting posix ACLs
authorGu Zheng <guzheng1@huawei.com>
Mon, 9 Jan 2017 01:34:48 +0000 (09:34 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Jan 2017 07:23:47 +0000 (08:23 +0100)
commit36672b8b99e2cf2ab0587f08a19f394f8f65a861
tree07ebe8e8bc6550367ea6bd298ca538a2160417e5
parent39d7c9ce35a1279bf84f81fe6dc351b5c6271a34
tmpfs: clear S_ISGID when setting posix ACLs

commit 497de07d89c1410d76a15bec2bb41f24a2a89f31 upstream.

This change was missed the tmpfs modification in In CVE-2016-7097
commit 073931017b49 ("posix_acl: Clear SGID bit when setting
file permissions")
It can test by xfstest generic/375, which failed to clear
setgid bit in the following test case on tmpfs:

  touch $testfile
  chown 100:100 $testfile
  chmod 2755 $testfile
  _runas -u 100 -g 101 -- setfacl -m u::rwx,g::rwx,o::rwx $testfile

Signed-off-by: Gu Zheng <guzheng1@huawei.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Cc: Brad Spengler <spender@grsecurity.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/posix_acl.c