irqchip: gic: use dmb ishst instead of dsb when raising a softirq
authorWill Deacon <will.deacon@arm.com>
Thu, 20 Feb 2014 17:42:07 +0000 (17:42 +0000)
committerChristoffer Dall <christoffer.dall@linaro.org>
Thu, 2 Oct 2014 07:30:43 +0000 (09:30 +0200)
commit32fd049c3a74b9f88c1adcc5f04becb9f55c9db1
treec51b4d9ab176c271eab4f6a1a8c756b557cc1980
parentbd09b6492478715ef4ee191e9bd75a4ac98294a2
irqchip: gic: use dmb ishst instead of dsb when raising a softirq

When sending an SGI to another CPU, we require a barrier to ensure that
any pending stores to normal memory are made visible to the recipient
before the interrupt arrives.

Rather than use a vanilla dsb() (which will soon cause an assembly error
on arm64) before the writel_relaxed, we can instead use dsb(ishst),
since we just need to ensure that any pending normal writes are visible
within the inner-shareable domain before we poke the GIC.

With this observation, we can then further weaken the barrier to a
dmb(ishst), since other CPUs in the inner-shareable domain must observe
the write to the distributor before the SGI is generated.

Cc: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
(cherry picked from commit 8adbf57fc4294588e9785069215d445a98e6c23a)
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
drivers/irqchip/irq-gic.c