ovl: Fix info leak in ovl_lookup_temp()
authorRichard Weinberger <richard@nod.at>
Fri, 16 Sep 2016 09:45:24 +0000 (11:45 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Oct 2016 07:01:30 +0000 (03:01 -0400)
commit0a5600d83fa5a251c91459779d5311a005e4c5b3
treefdb05eeb394ef3dbd0cda4dbdc57f8105e87103f
parent2add76a428bc6b9e4506d9caa4f8ced9b8bdcb70
ovl: Fix info leak in ovl_lookup_temp()

commit 6a45b3628ce4dcf7498b39c87d475bab6e2a9b24 upstream.

The function uses the memory address of a struct dentry as unique id.
While the address-based directory entry is only visible to root it is IMHO
still worth fixing since the temporary name does not have to be a kernel
address.  It can be any unique number.  Replace it by an atomic integer
which is allowed to wrap around.

Signed-off-by: Richard Weinberger <richard@nod.at>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: e9be9d5e76e3 ("overlay filesystem")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/overlayfs/dir.c