sunrpc/cache: drop reference when sunrpc_cache_pipe_upcall() detects a race
authorNeilBrown <neilb@suse.com>
Fri, 4 Mar 2016 06:20:13 +0000 (17:20 +1100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 May 2016 21:48:54 +0000 (14:48 -0700)
commit03d86237007729b006808e8eab90e96a565deee4
treece21a440ba7dbe8138ee8258f8683818e6c1df4d
parent1f5c4e0cb83cde427f1b8b95aa9a2a42e249fd53
sunrpc/cache: drop reference when sunrpc_cache_pipe_upcall() detects a race

commit a6ab1e8126d205238defbb55d23661a3a5c6a0d8 upstream.

sunrpc_cache_pipe_upcall() can detect a race if CACHE_PENDING is no longer
set.  In this case it aborts the queuing of the upcall.
However it has already taken a new counted reference on "h" and
doesn't "put" it, even though it frees the data structure holding the reference.

So let's delay the "cache_get" until we know we need it.

Fixes: f9e1aedc6c79 ("sunrpc/cache: remove races with queuing an upcall.")
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/sunrpc/cache.c