Merge tag 'mfd-3.5-1' of git://git.kernel.org/pub/scm/linux/kernel/git/sameo/mfd-2.6
[firefly-linux-kernel-4.4.55.git] / drivers / regulator / tps65910-regulator.c
index 852b05b20de902677f9843abc5a76676f2c87399..6bf864b4bdf67e8ddd860ed16fe0e7248e65318b 100644 (file)
 #include <linux/platform_device.h>
 #include <linux/regulator/driver.h>
 #include <linux/regulator/machine.h>
-#include <linux/delay.h>
 #include <linux/slab.h>
 #include <linux/gpio.h>
 #include <linux/mfd/tps65910.h>
+#include <linux/regulator/of_regulator.h>
 
 #define TPS65910_SUPPLY_STATE_ENABLED  0x1
 #define EXT_SLEEP_CONTROL (TPS65910_SLEEP_CONTROL_EXT_INPUT_EN1 |      \
                        TPS65910_SLEEP_CONTROL_EXT_INPUT_EN3 |          \
                        TPS65911_SLEEP_CONTROL_EXT_INPUT_SLEEP)
 
-/* supported VIO voltages in milivolts */
+/* supported VIO voltages in millivolts */
 static const u16 VIO_VSEL_table[] = {
        1500, 1800, 2500, 3300,
 };
 
 /* VSEL tables for TPS65910 specific LDOs and dcdc's */
 
-/* supported VDD3 voltages in milivolts */
+/* supported VDD3 voltages in millivolts */
 static const u16 VDD3_VSEL_table[] = {
        5000,
 };
 
-/* supported VDIG1 voltages in milivolts */
+/* supported VDIG1 voltages in millivolts */
 static const u16 VDIG1_VSEL_table[] = {
        1200, 1500, 1800, 2700,
 };
 
-/* supported VDIG2 voltages in milivolts */
+/* supported VDIG2 voltages in millivolts */
 static const u16 VDIG2_VSEL_table[] = {
        1000, 1100, 1200, 1800,
 };
 
-/* supported VPLL voltages in milivolts */
+/* supported VPLL voltages in millivolts */
 static const u16 VPLL_VSEL_table[] = {
        1000, 1100, 1800, 2500,
 };
 
-/* supported VDAC voltages in milivolts */
+/* supported VDAC voltages in millivolts */
 static const u16 VDAC_VSEL_table[] = {
        1800, 2600, 2800, 2850,
 };
 
-/* supported VAUX1 voltages in milivolts */
+/* supported VAUX1 voltages in millivolts */
 static const u16 VAUX1_VSEL_table[] = {
        1800, 2500, 2800, 2850,
 };
 
-/* supported VAUX2 voltages in milivolts */
+/* supported VAUX2 voltages in millivolts */
 static const u16 VAUX2_VSEL_table[] = {
        1800, 2800, 2900, 3300,
 };
 
-/* supported VAUX33 voltages in milivolts */
+/* supported VAUX33 voltages in millivolts */
 static const u16 VAUX33_VSEL_table[] = {
        1800, 2000, 2800, 3300,
 };
 
-/* supported VMMC voltages in milivolts */
+/* supported VMMC voltages in millivolts */
 static const u16 VMMC_VSEL_table[] = {
        1800, 2800, 3000, 3300,
 };
@@ -94,11 +94,11 @@ struct tps_info {
 
 static struct tps_info tps65910_regs[] = {
        {
-               .name = "VRTC",
+               .name = "vrtc",
                .enable_time_us = 2200,
        },
        {
-               .name = "VIO",
+               .name = "vio",
                .min_uV = 1500000,
                .max_uV = 3300000,
                .n_voltages = ARRAY_SIZE(VIO_VSEL_table),
@@ -106,19 +106,19 @@ static struct tps_info tps65910_regs[] = {
                .enable_time_us = 350,
        },
        {
-               .name = "VDD1",
+               .name = "vdd1",
                .min_uV = 600000,
                .max_uV = 4500000,
                .enable_time_us = 350,
        },
        {
-               .name = "VDD2",
+               .name = "vdd2",
                .min_uV = 600000,
                .max_uV = 4500000,
                .enable_time_us = 350,
        },
        {
-               .name = "VDD3",
+               .name = "vdd3",
                .min_uV = 5000000,
                .max_uV = 5000000,
                .n_voltages = ARRAY_SIZE(VDD3_VSEL_table),
@@ -126,7 +126,7 @@ static struct tps_info tps65910_regs[] = {
                .enable_time_us = 200,
        },
        {
-               .name = "VDIG1",
+               .name = "vdig1",
                .min_uV = 1200000,
                .max_uV = 2700000,
                .n_voltages = ARRAY_SIZE(VDIG1_VSEL_table),
@@ -134,7 +134,7 @@ static struct tps_info tps65910_regs[] = {
                .enable_time_us = 100,
        },
        {
-               .name = "VDIG2",
+               .name = "vdig2",
                .min_uV = 1000000,
                .max_uV = 1800000,
                .n_voltages = ARRAY_SIZE(VDIG2_VSEL_table),
@@ -142,7 +142,7 @@ static struct tps_info tps65910_regs[] = {
                .enable_time_us = 100,
        },
        {
-               .name = "VPLL",
+               .name = "vpll",
                .min_uV = 1000000,
                .max_uV = 2500000,
                .n_voltages = ARRAY_SIZE(VPLL_VSEL_table),
@@ -150,7 +150,7 @@ static struct tps_info tps65910_regs[] = {
                .enable_time_us = 100,
        },
        {
-               .name = "VDAC",
+               .name = "vdac",
                .min_uV = 1800000,
                .max_uV = 2850000,
                .n_voltages = ARRAY_SIZE(VDAC_VSEL_table),
@@ -158,7 +158,7 @@ static struct tps_info tps65910_regs[] = {
                .enable_time_us = 100,
        },
        {
-               .name = "VAUX1",
+               .name = "vaux1",
                .min_uV = 1800000,
                .max_uV = 2850000,
                .n_voltages = ARRAY_SIZE(VAUX1_VSEL_table),
@@ -166,7 +166,7 @@ static struct tps_info tps65910_regs[] = {
                .enable_time_us = 100,
        },
        {
-               .name = "VAUX2",
+               .name = "vaux2",
                .min_uV = 1800000,
                .max_uV = 3300000,
                .n_voltages = ARRAY_SIZE(VAUX2_VSEL_table),
@@ -174,7 +174,7 @@ static struct tps_info tps65910_regs[] = {
                .enable_time_us = 100,
        },
        {
-               .name = "VAUX33",
+               .name = "vaux33",
                .min_uV = 1800000,
                .max_uV = 3300000,
                .n_voltages = ARRAY_SIZE(VAUX33_VSEL_table),
@@ -182,7 +182,7 @@ static struct tps_info tps65910_regs[] = {
                .enable_time_us = 100,
        },
        {
-               .name = "VMMC",
+               .name = "vmmc",
                .min_uV = 1800000,
                .max_uV = 3300000,
                .n_voltages = ARRAY_SIZE(VMMC_VSEL_table),
@@ -193,11 +193,11 @@ static struct tps_info tps65910_regs[] = {
 
 static struct tps_info tps65911_regs[] = {
        {
-               .name = "VRTC",
+               .name = "vrtc",
                .enable_time_us = 2200,
        },
        {
-               .name = "VIO",
+               .name = "vio",
                .min_uV = 1500000,
                .max_uV = 3300000,
                .n_voltages = ARRAY_SIZE(VIO_VSEL_table),
@@ -205,77 +205,77 @@ static struct tps_info tps65911_regs[] = {
                .enable_time_us = 350,
        },
        {
-               .name = "VDD1",
+               .name = "vdd1",
                .min_uV = 600000,
                .max_uV = 4500000,
                .n_voltages = 73,
                .enable_time_us = 350,
        },
        {
-               .name = "VDD2",
+               .name = "vdd2",
                .min_uV = 600000,
                .max_uV = 4500000,
                .n_voltages = 73,
                .enable_time_us = 350,
        },
        {
-               .name = "VDDCTRL",
+               .name = "vddctrl",
                .min_uV = 600000,
                .max_uV = 1400000,
                .n_voltages = 65,
                .enable_time_us = 900,
        },
        {
-               .name = "LDO1",
+               .name = "ldo1",
                .min_uV = 1000000,
                .max_uV = 3300000,
                .n_voltages = 47,
                .enable_time_us = 420,
        },
        {
-               .name = "LDO2",
+               .name = "ldo2",
                .min_uV = 1000000,
                .max_uV = 3300000,
                .n_voltages = 47,
                .enable_time_us = 420,
        },
        {
-               .name = "LDO3",
+               .name = "ldo3",
                .min_uV = 1000000,
                .max_uV = 3300000,
                .n_voltages = 24,
                .enable_time_us = 230,
        },
        {
-               .name = "LDO4",
+               .name = "ldo4",
                .min_uV = 1000000,
                .max_uV = 3300000,
                .n_voltages = 47,
                .enable_time_us = 230,
        },
        {
-               .name = "LDO5",
+               .name = "ldo5",
                .min_uV = 1000000,
                .max_uV = 3300000,
                .n_voltages = 24,
                .enable_time_us = 230,
        },
        {
-               .name = "LDO6",
+               .name = "ldo6",
                .min_uV = 1000000,
                .max_uV = 3300000,
                .n_voltages = 24,
                .enable_time_us = 230,
        },
        {
-               .name = "LDO7",
+               .name = "ldo7",
                .min_uV = 1000000,
                .max_uV = 3300000,
                .n_voltages = 24,
                .enable_time_us = 230,
        },
        {
-               .name = "LDO8",
+               .name = "ldo8",
                .min_uV = 1000000,
                .max_uV = 3300000,
                .n_voltages = 24,
@@ -462,48 +462,6 @@ static int tps65911_get_ctrl_register(int id)
        }
 }
 
-static int tps65910_is_enabled(struct regulator_dev *dev)
-{
-       struct tps65910_reg *pmic = rdev_get_drvdata(dev);
-       int reg, value, id = rdev_get_id(dev);
-
-       reg = pmic->get_ctrl_reg(id);
-       if (reg < 0)
-               return reg;
-
-       value = tps65910_reg_read_locked(pmic, reg);
-       if (value < 0)
-               return value;
-
-       return value & TPS65910_SUPPLY_STATE_ENABLED;
-}
-
-static int tps65910_enable(struct regulator_dev *dev)
-{
-       struct tps65910_reg *pmic = rdev_get_drvdata(dev);
-       struct tps65910 *mfd = pmic->mfd;
-       int reg, id = rdev_get_id(dev);
-
-       reg = pmic->get_ctrl_reg(id);
-       if (reg < 0)
-               return reg;
-
-       return tps65910_reg_set_bits(mfd, reg, TPS65910_SUPPLY_STATE_ENABLED);
-}
-
-static int tps65910_disable(struct regulator_dev *dev)
-{
-       struct tps65910_reg *pmic = rdev_get_drvdata(dev);
-       struct tps65910 *mfd = pmic->mfd;
-       int reg, id = rdev_get_id(dev);
-
-       reg = pmic->get_ctrl_reg(id);
-       if (reg < 0)
-               return reg;
-
-       return tps65910_reg_clear_bits(mfd, reg, TPS65910_SUPPLY_STATE_ENABLED);
-}
-
 static int tps65910_enable_time(struct regulator_dev *dev)
 {
        struct tps65910_reg *pmic = rdev_get_drvdata(dev);
@@ -616,10 +574,10 @@ static int tps65910_get_voltage_dcdc_sel(struct regulator_dev *dev)
        return -EINVAL;
 }
 
-static int tps65910_get_voltage(struct regulator_dev *dev)
+static int tps65910_get_voltage_sel(struct regulator_dev *dev)
 {
        struct tps65910_reg *pmic = rdev_get_drvdata(dev);
-       int reg, value, id = rdev_get_id(dev), voltage = 0;
+       int reg, value, id = rdev_get_id(dev);
 
        reg = pmic->get_ctrl_reg(id);
        if (reg < 0)
@@ -646,9 +604,7 @@ static int tps65910_get_voltage(struct regulator_dev *dev)
                return -EINVAL;
        }
 
-       voltage = pmic->info[id]->voltage_table[value] * 1000;
-
-       return voltage;
+       return value;
 }
 
 static int tps65910_get_voltage_vdd3(struct regulator_dev *dev)
@@ -656,10 +612,10 @@ static int tps65910_get_voltage_vdd3(struct regulator_dev *dev)
        return 5 * 1000 * 1000;
 }
 
-static int tps65911_get_voltage(struct regulator_dev *dev)
+static int tps65911_get_voltage_sel(struct regulator_dev *dev)
 {
        struct tps65910_reg *pmic = rdev_get_drvdata(dev);
-       int step_mv, id = rdev_get_id(dev);
+       int id = rdev_get_id(dev);
        u8 value, reg;
 
        reg = pmic->get_ctrl_reg(id);
@@ -672,13 +628,6 @@ static int tps65911_get_voltage(struct regulator_dev *dev)
        case TPS65911_REG_LDO4:
                value &= LDO1_SEL_MASK;
                value >>= LDO_SEL_SHIFT;
-               /* The first 5 values of the selector correspond to 1V */
-               if (value < 5)
-                       value = 0;
-               else
-                       value -= 4;
-
-               step_mv = 50;
                break;
        case TPS65911_REG_LDO3:
        case TPS65911_REG_LDO5:
@@ -687,23 +636,16 @@ static int tps65911_get_voltage(struct regulator_dev *dev)
        case TPS65911_REG_LDO8:
                value &= LDO3_SEL_MASK;
                value >>= LDO_SEL_SHIFT;
-               /* The first 3 values of the selector correspond to 1V */
-               if (value < 3)
-                       value = 0;
-               else
-                       value -= 2;
-
-               step_mv = 100;
                break;
        case TPS65910_REG_VIO:
                value &= LDO_SEL_MASK;
                value >>= LDO_SEL_SHIFT;
-               return pmic->info[id]->voltage_table[value] * 1000;
+               break;
        default:
                return -EINVAL;
        }
 
-       return (LDO_MIN_VOLT + value * step_mv) * 1000;
+       return value;
 }
 
 static int tps65910_set_voltage_dcdc_sel(struct regulator_dev *dev,
@@ -909,9 +851,9 @@ static int tps65910_set_voltage_dcdc_time_sel(struct regulator_dev *dev,
 
 /* Regulator ops (except VRTC) */
 static struct regulator_ops tps65910_ops_dcdc = {
-       .is_enabled             = tps65910_is_enabled,
-       .enable                 = tps65910_enable,
-       .disable                = tps65910_disable,
+       .is_enabled             = regulator_is_enabled_regmap,
+       .enable                 = regulator_enable_regmap,
+       .disable                = regulator_disable_regmap,
        .enable_time            = tps65910_enable_time,
        .set_mode               = tps65910_set_mode,
        .get_mode               = tps65910_get_mode,
@@ -922,9 +864,9 @@ static struct regulator_ops tps65910_ops_dcdc = {
 };
 
 static struct regulator_ops tps65910_ops_vdd3 = {
-       .is_enabled             = tps65910_is_enabled,
-       .enable                 = tps65910_enable,
-       .disable                = tps65910_disable,
+       .is_enabled             = regulator_is_enabled_regmap,
+       .enable                 = regulator_enable_regmap,
+       .disable                = regulator_disable_regmap,
        .enable_time            = tps65910_enable_time,
        .set_mode               = tps65910_set_mode,
        .get_mode               = tps65910_get_mode,
@@ -933,25 +875,25 @@ static struct regulator_ops tps65910_ops_vdd3 = {
 };
 
 static struct regulator_ops tps65910_ops = {
-       .is_enabled             = tps65910_is_enabled,
-       .enable                 = tps65910_enable,
-       .disable                = tps65910_disable,
+       .is_enabled             = regulator_is_enabled_regmap,
+       .enable                 = regulator_enable_regmap,
+       .disable                = regulator_disable_regmap,
        .enable_time            = tps65910_enable_time,
        .set_mode               = tps65910_set_mode,
        .get_mode               = tps65910_get_mode,
-       .get_voltage            = tps65910_get_voltage,
+       .get_voltage_sel        = tps65910_get_voltage_sel,
        .set_voltage_sel        = tps65910_set_voltage_sel,
        .list_voltage           = tps65910_list_voltage,
 };
 
 static struct regulator_ops tps65911_ops = {
-       .is_enabled             = tps65910_is_enabled,
-       .enable                 = tps65910_enable,
-       .disable                = tps65910_disable,
+       .is_enabled             = regulator_is_enabled_regmap,
+       .enable                 = regulator_enable_regmap,
+       .disable                = regulator_disable_regmap,
        .enable_time            = tps65910_enable_time,
        .set_mode               = tps65910_set_mode,
        .get_mode               = tps65910_get_mode,
-       .get_voltage            = tps65911_get_voltage,
+       .get_voltage_sel        = tps65911_get_voltage_sel,
        .set_voltage_sel        = tps65911_set_voltage_sel,
        .list_voltage           = tps65911_list_voltage,
 };
@@ -1090,23 +1032,141 @@ static int tps65910_set_ext_sleep_config(struct tps65910_reg *pmic,
        return ret;
 }
 
+#ifdef CONFIG_OF
+
+static struct of_regulator_match tps65910_matches[] = {
+       { .name = "vrtc",       .driver_data = (void *) &tps65910_regs[0] },
+       { .name = "vio",        .driver_data = (void *) &tps65910_regs[1] },
+       { .name = "vdd1",       .driver_data = (void *) &tps65910_regs[2] },
+       { .name = "vdd2",       .driver_data = (void *) &tps65910_regs[3] },
+       { .name = "vdd3",       .driver_data = (void *) &tps65910_regs[4] },
+       { .name = "vdig1",      .driver_data = (void *) &tps65910_regs[5] },
+       { .name = "vdig2",      .driver_data = (void *) &tps65910_regs[6] },
+       { .name = "vpll",       .driver_data = (void *) &tps65910_regs[7] },
+       { .name = "vdac",       .driver_data = (void *) &tps65910_regs[8] },
+       { .name = "vaux1",      .driver_data = (void *) &tps65910_regs[9] },
+       { .name = "vaux2",      .driver_data = (void *) &tps65910_regs[10] },
+       { .name = "vaux33",     .driver_data = (void *) &tps65910_regs[11] },
+       { .name = "vmmc",       .driver_data = (void *) &tps65910_regs[12] },
+};
+
+static struct of_regulator_match tps65911_matches[] = {
+       { .name = "vrtc",       .driver_data = (void *) &tps65911_regs[0] },
+       { .name = "vio",        .driver_data = (void *) &tps65911_regs[1] },
+       { .name = "vdd1",       .driver_data = (void *) &tps65911_regs[2] },
+       { .name = "vdd2",       .driver_data = (void *) &tps65911_regs[3] },
+       { .name = "vddctrl",    .driver_data = (void *) &tps65911_regs[4] },
+       { .name = "ldo1",       .driver_data = (void *) &tps65911_regs[5] },
+       { .name = "ldo2",       .driver_data = (void *) &tps65911_regs[6] },
+       { .name = "ldo3",       .driver_data = (void *) &tps65911_regs[7] },
+       { .name = "ldo4",       .driver_data = (void *) &tps65911_regs[8] },
+       { .name = "ldo5",       .driver_data = (void *) &tps65911_regs[9] },
+       { .name = "ldo6",       .driver_data = (void *) &tps65911_regs[10] },
+       { .name = "ldo7",       .driver_data = (void *) &tps65911_regs[11] },
+       { .name = "ldo8",       .driver_data = (void *) &tps65911_regs[12] },
+};
+
+static struct tps65910_board *tps65910_parse_dt_reg_data(
+               struct platform_device *pdev,
+               struct of_regulator_match **tps65910_reg_matches)
+{
+       struct tps65910_board *pmic_plat_data;
+       struct tps65910 *tps65910 = dev_get_drvdata(pdev->dev.parent);
+       struct device_node *np = pdev->dev.parent->of_node;
+       struct device_node *regulators;
+       struct of_regulator_match *matches;
+       unsigned int prop;
+       int idx = 0, ret, count;
+
+       pmic_plat_data = devm_kzalloc(&pdev->dev, sizeof(*pmic_plat_data),
+                                       GFP_KERNEL);
+
+       if (!pmic_plat_data) {
+               dev_err(&pdev->dev, "Failure to alloc pdata for regulators.\n");
+               return NULL;
+       }
+
+       regulators = of_find_node_by_name(np, "regulators");
+       if (!regulators) {
+               dev_err(&pdev->dev, "regulator node not found\n");
+               return NULL;
+       }
+
+       switch (tps65910_chip_id(tps65910)) {
+       case TPS65910:
+               count = ARRAY_SIZE(tps65910_matches);
+               matches = tps65910_matches;
+               break;
+       case TPS65911:
+               count = ARRAY_SIZE(tps65911_matches);
+               matches = tps65911_matches;
+               break;
+       default:
+               dev_err(&pdev->dev, "Invalid tps chip version\n");
+               return NULL;
+       }
+
+       ret = of_regulator_match(pdev->dev.parent, regulators, matches, count);
+       if (ret < 0) {
+               dev_err(&pdev->dev, "Error parsing regulator init data: %d\n",
+                       ret);
+               return NULL;
+       }
+
+       *tps65910_reg_matches = matches;
+
+       for (idx = 0; idx < count; idx++) {
+               if (!matches[idx].init_data || !matches[idx].of_node)
+                       continue;
+
+               pmic_plat_data->tps65910_pmic_init_data[idx] =
+                                                       matches[idx].init_data;
+
+               ret = of_property_read_u32(matches[idx].of_node,
+                               "ti,regulator-ext-sleep-control", &prop);
+               if (!ret)
+                       pmic_plat_data->regulator_ext_sleep_control[idx] = prop;
+       }
+
+       return pmic_plat_data;
+}
+#else
+static inline struct tps65910_board *tps65910_parse_dt_reg_data(
+                       struct platform_device *pdev,
+                       struct of_regulator_match **tps65910_reg_matches)
+{
+       *tps65910_reg_matches = NULL;
+       return 0;
+}
+#endif
+
 static __devinit int tps65910_probe(struct platform_device *pdev)
 {
        struct tps65910 *tps65910 = dev_get_drvdata(pdev->dev.parent);
+       struct regulator_config config = { };
        struct tps_info *info;
        struct regulator_init_data *reg_data;
        struct regulator_dev *rdev;
        struct tps65910_reg *pmic;
        struct tps65910_board *pmic_plat_data;
+       struct of_regulator_match *tps65910_reg_matches = NULL;
        int i, err;
 
        pmic_plat_data = dev_get_platdata(tps65910->dev);
-       if (!pmic_plat_data)
+       if (!pmic_plat_data && tps65910->dev->of_node)
+               pmic_plat_data = tps65910_parse_dt_reg_data(pdev,
+                                               &tps65910_reg_matches);
+
+       if (!pmic_plat_data) {
+               dev_err(&pdev->dev, "Platform data not found\n");
                return -EINVAL;
+       }
 
-       pmic = kzalloc(sizeof(*pmic), GFP_KERNEL);
-       if (!pmic)
+       pmic = devm_kzalloc(&pdev->dev, sizeof(*pmic), GFP_KERNEL);
+       if (!pmic) {
+               dev_err(&pdev->dev, "Memory allocation failed for pmic\n");
                return -ENOMEM;
+       }
 
        mutex_init(&pmic->mutex);
        pmic->mfd = tps65910;
@@ -1130,30 +1190,29 @@ static __devinit int tps65910_probe(struct platform_device *pdev)
                info = tps65911_regs;
                break;
        default:
-               pr_err("Invalid tps chip version\n");
-               kfree(pmic);
+               dev_err(&pdev->dev, "Invalid tps chip version\n");
                return -ENODEV;
        }
 
-       pmic->desc = kcalloc(pmic->num_regulators,
+       pmic->desc = devm_kzalloc(&pdev->dev, pmic->num_regulators *
                        sizeof(struct regulator_desc), GFP_KERNEL);
        if (!pmic->desc) {
-               err = -ENOMEM;
-               goto err_free_pmic;
+               dev_err(&pdev->dev, "Memory alloc fails for desc\n");
+               return -ENOMEM;
        }
 
-       pmic->info = kcalloc(pmic->num_regulators,
+       pmic->info = devm_kzalloc(&pdev->dev, pmic->num_regulators *
                        sizeof(struct tps_info *), GFP_KERNEL);
        if (!pmic->info) {
-               err = -ENOMEM;
-               goto err_free_desc;
+               dev_err(&pdev->dev, "Memory alloc fails for info\n");
+               return -ENOMEM;
        }
 
-       pmic->rdev = kcalloc(pmic->num_regulators,
+       pmic->rdev = devm_kzalloc(&pdev->dev, pmic->num_regulators *
                        sizeof(struct regulator_dev *), GFP_KERNEL);
        if (!pmic->rdev) {
-               err = -ENOMEM;
-               goto err_free_info;
+               dev_err(&pdev->dev, "Memory alloc fails for rdev\n");
+               return -ENOMEM;
        }
 
        for (i = 0; i < pmic->num_regulators && i < TPS65910_NUM_REGS;
@@ -1201,9 +1260,18 @@ static __devinit int tps65910_probe(struct platform_device *pdev)
 
                pmic->desc[i].type = REGULATOR_VOLTAGE;
                pmic->desc[i].owner = THIS_MODULE;
+               pmic->desc[i].enable_reg = pmic->get_ctrl_reg(i);
+               pmic->desc[i].enable_mask = TPS65910_SUPPLY_STATE_ENABLED;
+
+               config.dev = tps65910->dev;
+               config.init_data = reg_data;
+               config.driver_data = pmic;
+               config.regmap = tps65910->regmap;
+
+               if (tps65910_reg_matches)
+                       config.of_node = tps65910_reg_matches[i].of_node;
 
-               rdev = regulator_register(&pmic->desc[i],
-                               tps65910->dev, reg_data, pmic, NULL);
+               rdev = regulator_register(&pmic->desc[i], &config);
                if (IS_ERR(rdev)) {
                        dev_err(tps65910->dev,
                                "failed to register %s regulator\n",
@@ -1220,13 +1288,6 @@ static __devinit int tps65910_probe(struct platform_device *pdev)
 err_unregister_regulator:
        while (--i >= 0)
                regulator_unregister(pmic->rdev[i]);
-       kfree(pmic->rdev);
-err_free_info:
-       kfree(pmic->info);
-err_free_desc:
-       kfree(pmic->desc);
-err_free_pmic:
-       kfree(pmic);
        return err;
 }
 
@@ -1238,10 +1299,6 @@ static int __devexit tps65910_remove(struct platform_device *pdev)
        for (i = 0; i < pmic->num_regulators; i++)
                regulator_unregister(pmic->rdev[i]);
 
-       kfree(pmic->rdev);
-       kfree(pmic->info);
-       kfree(pmic->desc);
-       kfree(pmic);
        return 0;
 }