drivers/gpu/drm/rockchip/rockchip_vop_reg.c

   1 /*
   2  * Copyright (C) Fuzhou Rockchip Electronics Co.Ltd
   3  * Author:Mark Yao <mark.yao@rock-chips.com>
   4  *
   5  * This software is licensed under the terms of the GNU General Public
   6  * License version 2, as published by the Free Software Foundation, and
   7  * may be copied, distributed, and modified under those terms.
   8  *
   9  * This program is distributed in the hope that it will be useful,
  10  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  11  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  12  * GNU General Public License for more details.
  13  */
  14
  15 #include <drm/drmP.h>
  16
  17 #include <linux/kernel.h>
  18 #include <linux/component.h>
  19
  20 #include "rockchip_drm_vop.h"
  21 #include "rockchip_vop_reg.h"
  22
  23 #define VOP_REG_VER_MASK(off, _mask, s, _write_mask, _major, \
  24                          _begin_minor, _end_minor) \
  25                 {.offset = off, \
  26                  .mask = _mask, \
  27                  .shift = s, \
  28                  .write_mask = _write_mask, \
  29                  .major = _major, \
  30                  .begin_minor = _begin_minor, \
  31                  .end_minor = _end_minor,}
  32
  33 #define VOP_REG(off, _mask, s) \
  34                 VOP_REG_VER_MASK(off, _mask, s, false, 0, 0, -1)
  35
  36 #define VOP_REG_MASK(off, _mask, s) \
  37                 VOP_REG_VER_MASK(off, _mask, s, true, 0, 0, -1)
  38
  39 #define VOP_REG_VER(off, _mask, s, _major, _begin_minor, _end_minor) \
  40                 VOP_REG_VER_MASK(off, _mask, s, false, \
  41                                  _major, _begin_minor, _end_minor)
  42
  43
  44 static const uint32_t formats_win_full[] = {
  45         DRM_FORMAT_XRGB8888,
  46         DRM_FORMAT_ARGB8888,
  47         DRM_FORMAT_XBGR8888,
  48         DRM_FORMAT_ABGR8888,
  49         DRM_FORMAT_RGB888,
  50         DRM_FORMAT_BGR888,
  51         DRM_FORMAT_RGB565,
  52         DRM_FORMAT_BGR565,
  53         DRM_FORMAT_NV12,
  54         DRM_FORMAT_NV16,
  55         DRM_FORMAT_NV24,
  56         DRM_FORMAT_NV12_10,
  57         DRM_FORMAT_NV16_10,
  58         DRM_FORMAT_NV24_10,
  59 };
  60
  61 static const uint32_t formats_win_lite[] = {
  62         DRM_FORMAT_XRGB8888,
  63         DRM_FORMAT_ARGB8888,
  64         DRM_FORMAT_XBGR8888,
  65         DRM_FORMAT_ABGR8888,
  66         DRM_FORMAT_RGB888,
  67         DRM_FORMAT_BGR888,
  68         DRM_FORMAT_RGB565,
  69         DRM_FORMAT_BGR565,
  70 };
  71
  72 static const struct vop_scl_extension rk3288_win_full_scl_ext = {
  73         .cbcr_vsd_mode = VOP_REG(RK3288_WIN0_CTRL1, 0x1, 31),
  74         .cbcr_vsu_mode = VOP_REG(RK3288_WIN0_CTRL1, 0x1, 30),
  75         .cbcr_hsd_mode = VOP_REG(RK3288_WIN0_CTRL1, 0x3, 28),
  76         .cbcr_ver_scl_mode = VOP_REG(RK3288_WIN0_CTRL1, 0x3, 26),
  77         .cbcr_hor_scl_mode = VOP_REG(RK3288_WIN0_CTRL1, 0x3, 24),
  78         .yrgb_vsd_mode = VOP_REG(RK3288_WIN0_CTRL1, 0x1, 23),
  79         .yrgb_vsu_mode = VOP_REG(RK3288_WIN0_CTRL1, 0x1, 22),
  80         .yrgb_hsd_mode = VOP_REG(RK3288_WIN0_CTRL1, 0x3, 20),
  81         .yrgb_ver_scl_mode = VOP_REG(RK3288_WIN0_CTRL1, 0x3, 18),
  82         .yrgb_hor_scl_mode = VOP_REG(RK3288_WIN0_CTRL1, 0x3, 16),
  83         .line_load_mode = VOP_REG(RK3288_WIN0_CTRL1, 0x1, 15),
  84         .cbcr_axi_gather_num = VOP_REG(RK3288_WIN0_CTRL1, 0x7, 12),
  85         .yrgb_axi_gather_num = VOP_REG(RK3288_WIN0_CTRL1, 0xf, 8),
  86         .vsd_cbcr_gt2 = VOP_REG(RK3288_WIN0_CTRL1, 0x1, 7),
  87         .vsd_cbcr_gt4 = VOP_REG(RK3288_WIN0_CTRL1, 0x1, 6),
  88         .vsd_yrgb_gt2 = VOP_REG(RK3288_WIN0_CTRL1, 0x1, 5),
  89         .vsd_yrgb_gt4 = VOP_REG(RK3288_WIN0_CTRL1, 0x1, 4),
  90         .bic_coe_sel = VOP_REG(RK3288_WIN0_CTRL1, 0x3, 2),
  91         .cbcr_axi_gather_en = VOP_REG(RK3288_WIN0_CTRL1, 0x1, 1),
  92         .yrgb_axi_gather_en = VOP_REG(RK3288_WIN0_CTRL1, 0x1, 0),
  93         .lb_mode = VOP_REG(RK3288_WIN0_CTRL0, 0x7, 5),
  94 };
  95
  96 static const struct vop_scl_regs rk3288_win_full_scl = {
  97         .ext = &rk3288_win_full_scl_ext,
  98         .scale_yrgb_x = VOP_REG(RK3288_WIN0_SCL_FACTOR_YRGB, 0xffff, 0x0),
  99         .scale_yrgb_y = VOP_REG(RK3288_WIN0_SCL_FACTOR_YRGB, 0xffff, 16),
 100         .scale_cbcr_x = VOP_REG(RK3288_WIN0_SCL_FACTOR_CBR, 0xffff, 0x0),
 101         .scale_cbcr_y = VOP_REG(RK3288_WIN0_SCL_FACTOR_CBR, 0xffff, 16),
 102 };
 103
 104 static const struct vop_win_phy rk3288_win01_data = {
 105         .scl = &rk3288_win_full_scl,
 106         .data_formats = formats_win_full,
 107         .nformats = ARRAY_SIZE(formats_win_full),
 108         .enable = VOP_REG(RK3288_WIN0_CTRL0, 0x1, 0),
 109         .format = VOP_REG(RK3288_WIN0_CTRL0, 0x7, 1),
 110         .fmt_10 = VOP_REG(RK3288_WIN0_CTRL0, 0x7, 4),
 111         .rb_swap = VOP_REG(RK3288_WIN0_CTRL0, 0x1, 12),
 112         .xmirror = VOP_REG_VER(RK3368_WIN0_CTRL0, 0x1, 21, 3, 2, -1),
 113         .ymirror = VOP_REG_VER(RK3368_WIN0_CTRL0, 0x1, 22, 3, 2, -1),
 114         .act_info = VOP_REG(RK3288_WIN0_ACT_INFO, 0x1fff1fff, 0),
 115         .dsp_info = VOP_REG(RK3288_WIN0_DSP_INFO, 0x0fff0fff, 0),
 116         .dsp_st = VOP_REG(RK3288_WIN0_DSP_ST, 0x1fff1fff, 0),
 117         .yrgb_mst = VOP_REG(RK3288_WIN0_YRGB_MST, 0xffffffff, 0),
 118         .uv_mst = VOP_REG(RK3288_WIN0_CBR_MST, 0xffffffff, 0),
 119         .yrgb_vir = VOP_REG(RK3288_WIN0_VIR, 0x3fff, 0),
 120         .uv_vir = VOP_REG(RK3288_WIN0_VIR, 0x3fff, 16),
 121         .src_alpha_ctl = VOP_REG(RK3288_WIN0_SRC_ALPHA_CTRL, 0xffffffff, 0),
 122         .dst_alpha_ctl = VOP_REG(RK3288_WIN0_DST_ALPHA_CTRL, 0xffffffff, 0),
 123 };
 124
 125 static const struct vop_win_phy rk3288_win23_data = {
 126         .data_formats = formats_win_lite,
 127         .nformats = ARRAY_SIZE(formats_win_lite),
 128         .gate = VOP_REG(RK3288_WIN2_CTRL0, 0x1, 0),
 129         .enable = VOP_REG(RK3288_WIN2_CTRL0, 0x1, 4),
 130         .format = VOP_REG(RK3288_WIN2_CTRL0, 0x7, 1),
 131         .rb_swap = VOP_REG(RK3288_WIN2_CTRL0, 0x1, 12),
 132         .dsp_info = VOP_REG(RK3288_WIN2_DSP_INFO0, 0x0fff0fff, 0),
 133         .dsp_st = VOP_REG(RK3288_WIN2_DSP_ST0, 0x1fff1fff, 0),
 134         .yrgb_mst = VOP_REG(RK3288_WIN2_MST0, 0xffffffff, 0),
 135         .yrgb_vir = VOP_REG(RK3288_WIN2_VIR0_1, 0x1fff, 0),
 136         .src_alpha_ctl = VOP_REG(RK3288_WIN2_SRC_ALPHA_CTRL, 0xff, 0),
 137         .dst_alpha_ctl = VOP_REG(RK3288_WIN2_DST_ALPHA_CTRL, 0xff, 0),
 138 };
 139
 140 static const struct vop_win_phy rk3288_area1_data = {
 141         .enable = VOP_REG(RK3288_WIN2_CTRL0, 0x1, 5),
 142         .dsp_info = VOP_REG(RK3288_WIN2_DSP_INFO1, 0x0fff0fff, 0),
 143         .dsp_st = VOP_REG(RK3288_WIN2_DSP_ST1, 0x1fff1fff, 0),
 144         .yrgb_mst = VOP_REG(RK3288_WIN2_MST1, 0xffffffff, 0),
 145         .yrgb_vir = VOP_REG(RK3288_WIN2_VIR0_1, 0x1fff, 16),
 146 };
 147
 148 static const struct vop_win_phy rk3288_area2_data = {
 149         .enable = VOP_REG(RK3288_WIN2_CTRL0, 0x1, 6),
 150         .dsp_info = VOP_REG(RK3288_WIN2_DSP_INFO2, 0x0fff0fff, 0),
 151         .dsp_st = VOP_REG(RK3288_WIN2_DSP_ST2, 0x1fff1fff, 0),
 152         .yrgb_mst = VOP_REG(RK3288_WIN2_MST2, 0xffffffff, 0),
 153         .yrgb_vir = VOP_REG(RK3288_WIN2_VIR2_3, 0x1fff, 0),
 154 };
 155
 156 static const struct vop_win_phy rk3288_area3_data = {
 157         .enable = VOP_REG(RK3288_WIN2_CTRL0, 0x1, 7),
 158         .dsp_info = VOP_REG(RK3288_WIN2_DSP_INFO3, 0x0fff0fff, 0),
 159         .dsp_st = VOP_REG(RK3288_WIN2_DSP_ST3, 0x1fff1fff, 0),
 160         .yrgb_mst = VOP_REG(RK3288_WIN2_MST3, 0xffffffff, 0),
 161         .yrgb_vir = VOP_REG(RK3288_WIN2_VIR2_3, 0x1fff, 16),
 162 };
 163
 164 static const struct vop_win_phy *rk3288_area_data[] = {
 165         &rk3288_area1_data,
 166         &rk3288_area2_data,
 167         &rk3288_area3_data
 168 };
 169
 170 static const struct vop_ctrl rk3288_ctrl_data = {
 171         .standby = VOP_REG(RK3288_SYS_CTRL, 0x1, 22),
 172         .htotal_pw = VOP_REG(RK3288_DSP_HTOTAL_HS_END, 0x1fff1fff, 0),
 173         .hact_st_end = VOP_REG(RK3288_DSP_HACT_ST_END, 0x1fff1fff, 0),
 174         .vtotal_pw = VOP_REG(RK3288_DSP_VTOTAL_VS_END, 0x1fff1fff, 0),
 175         .vact_st_end = VOP_REG(RK3288_DSP_VACT_ST_END, 0x1fff1fff, 0),
 176         .vact_st_end_f1 = VOP_REG(RK3288_DSP_VACT_ST_END_F1, 0x1fff1fff, 0),
 177         .vs_st_end_f1 = VOP_REG(RK3288_DSP_VS_ST_END_F1, 0x1fff1fff, 0),
 178         .hpost_st_end = VOP_REG(RK3288_POST_DSP_HACT_INFO, 0x1fff1fff, 0),
 179         .vpost_st_end = VOP_REG(RK3288_POST_DSP_VACT_INFO, 0x1fff1fff, 0),
 180         .vpost_st_end_f1 = VOP_REG(RK3288_POST_DSP_VACT_INFO_F1, 0x1fff1fff, 0),
 181         .post_scl_factor = VOP_REG(RK3288_POST_SCL_FACTOR_YRGB, 0xffffffff, 0),
 182         .post_scl_ctrl = VOP_REG(RK3288_POST_SCL_CTRL, 0x3, 0),
 183
 184         .dsp_interlace = VOP_REG(RK3288_DSP_CTRL0, 0x1, 10),
 185         .auto_gate_en = VOP_REG(RK3288_SYS_CTRL, 0x1, 23),
 186         .dsp_layer_sel = VOP_REG(RK3288_DSP_CTRL1, 0xff, 8),
 187         .post_lb_mode = VOP_REG_VER(RK3288_SYS_CTRL, 0x1, 18, 3, 2, -1),
 188         .global_regdone_en = VOP_REG_VER(RK3288_SYS_CTRL, 0x1, 11, 3, 2, -1),
 189         .overlay_mode = VOP_REG_VER(RK3288_SYS_CTRL, 0x1, 16, 3, 2, -1),
 190         .core_dclk_div = VOP_REG_VER(RK3399_DSP_CTRL0, 0x1, 4, 3, 4, -1),
 191         .p2i_en = VOP_REG_VER(RK3399_DSP_CTRL0, 0x1, 5, 3, 4, -1),
 192         .dp_en = VOP_REG(RK3399_SYS_CTRL, 0x1, 11),
 193         .rgb_en = VOP_REG(RK3288_SYS_CTRL, 0x1, 12),
 194         .hdmi_en = VOP_REG(RK3288_SYS_CTRL, 0x1, 13),
 195         .edp_en = VOP_REG(RK3288_SYS_CTRL, 0x1, 14),
 196         .mipi_en = VOP_REG(RK3288_SYS_CTRL, 0x1, 15),
 197         .pin_pol = VOP_REG_VER(RK3288_DSP_CTRL0, 0xf, 4, 3, 0, 1),
 198         .dp_pin_pol = VOP_REG_VER(RK3368_DSP_CTRL1, 0xf, 16, 3, 2, -1),
 199         .rgb_pin_pol = VOP_REG_VER(RK3368_DSP_CTRL1, 0xf, 16, 3, 2, -1),
 200         .hdmi_pin_pol = VOP_REG_VER(RK3368_DSP_CTRL1, 0xf, 20, 3, 2, -1),
 201         .edp_pin_pol = VOP_REG_VER(RK3368_DSP_CTRL1, 0xf, 24, 3, 2, -1),
 202         .mipi_pin_pol = VOP_REG_VER(RK3368_DSP_CTRL1, 0xf, 28, 3, 2, -1),
 203
 204         .dither_down = VOP_REG(RK3288_DSP_CTRL1, 0xf, 1),
 205         .dither_up = VOP_REG(RK3288_DSP_CTRL1, 0x1, 6),
 206
 207         .dsp_data_swap = VOP_REG(RK3288_DSP_CTRL0, 0x1f, 12),
 208         .dsp_ccir656_avg = VOP_REG(RK3288_DSP_CTRL0, 0x1, 20),
 209         .dsp_blank = VOP_REG(RK3288_DSP_CTRL0, 0x3, 18),
 210         .dsp_lut_en = VOP_REG(RK3288_DSP_CTRL1, 0x1, 0),
 211         .out_mode = VOP_REG(RK3288_DSP_CTRL0, 0xf, 0),
 212
 213         .afbdc_rstn = VOP_REG(RK3399_AFBCD0_CTRL, 0x1, 3),
 214         .afbdc_en = VOP_REG(RK3399_AFBCD0_CTRL, 0x1, 0),
 215         .afbdc_sel = VOP_REG(RK3399_AFBCD0_CTRL, 0x3, 1),
 216         .afbdc_format = VOP_REG(RK3399_AFBCD0_CTRL, 0x1f, 16),
 217         .afbdc_hreg_block_split = VOP_REG(RK3399_AFBCD0_CTRL, 0x1, 21),
 218         .afbdc_hdr_ptr = VOP_REG(RK3399_AFBCD0_HDR_PTR, 0xffffffff, 0),
 219         .afbdc_pic_size = VOP_REG(RK3399_AFBCD0_PIC_SIZE, 0xffffffff, 0),
 220
 221         .xmirror = VOP_REG(RK3288_DSP_CTRL0, 0x1, 22),
 222         .ymirror = VOP_REG(RK3288_DSP_CTRL0, 0x1, 23),
 223
 224         .dsp_background = VOP_REG(RK3288_DSP_BG, 0xffffffff, 0),
 225
 226         .cfg_done = VOP_REG(RK3288_REG_CFG_DONE, 0x1, 0),
 227 };
 228
 229 /*
 230  * Note: rk3288 has a dedicated 'cursor' window, however, that window requires
 231  * special support to get alpha blending working.  For now, just use overlay
 232  * window 3 for the drm cursor.
 233  *
 234  */
 235 static const struct vop_win_data rk3288_vop_win_data[] = {
 236         { .base = 0x00, .phy = &rk3288_win01_data,
 237           .type = DRM_PLANE_TYPE_PRIMARY },
 238         { .base = 0x40, .phy = &rk3288_win01_data,
 239           .type = DRM_PLANE_TYPE_OVERLAY },
 240         { .base = 0x00, .phy = &rk3288_win23_data,
 241           .type = DRM_PLANE_TYPE_OVERLAY,
 242           .area = rk3288_area_data,
 243           .area_size = ARRAY_SIZE(rk3288_area_data), },
 244         { .base = 0x50, .phy = &rk3288_win23_data,
 245           .type = DRM_PLANE_TYPE_CURSOR,
 246           .area = rk3288_area_data,
 247           .area_size = ARRAY_SIZE(rk3288_area_data), },
 248 };
 249
 250 static const int rk3288_vop_intrs[] = {
 251         DSP_HOLD_VALID_INTR,
 252         FS_INTR,
 253         LINE_FLAG_INTR,
 254         BUS_ERROR_INTR,
 255 };
 256
 257 static const struct vop_intr rk3288_vop_intr = {
 258         .intrs = rk3288_vop_intrs,
 259         .nintrs = ARRAY_SIZE(rk3288_vop_intrs),
 260         .line_flag_num[0] = VOP_REG(RK3288_INTR_CTRL0, 0x1fff, 12),
 261         .status = VOP_REG(RK3288_INTR_CTRL0, 0xf, 0),
 262         .enable = VOP_REG(RK3288_INTR_CTRL0, 0xf, 4),
 263         .clear = VOP_REG(RK3288_INTR_CTRL0, 0xf, 8),
 264 };
 265
 266 static const struct vop_data rk3288_vop = {
 267         .version = VOP_VERSION(3, 1),
 268         .feature = VOP_FEATURE_OUTPUT_10BIT,
 269         .max_input = {4096, 8192},
 270         /*
 271          * TODO: rk3288 have two vop, big one support 3840x2160,
 272          * little one only support 2560x1600.
 273          * Now force use 3840x2160.
 274          */
 275         .max_output = {3840, 2160},
 276         .intr = &rk3288_vop_intr,
 277         .ctrl = &rk3288_ctrl_data,
 278         .win = rk3288_vop_win_data,
 279         .win_size = ARRAY_SIZE(rk3288_vop_win_data),
 280 };
 281
 282 static const int rk3368_vop_intrs[] = {
 283         FS_INTR,
 284         FS_NEW_INTR,
 285         ADDR_SAME_INTR,
 286         LINE_FLAG_INTR,
 287         LINE_FLAG1_INTR,
 288         BUS_ERROR_INTR,
 289         WIN0_EMPTY_INTR,
 290         WIN1_EMPTY_INTR,
 291         WIN2_EMPTY_INTR,
 292         WIN3_EMPTY_INTR,
 293         HWC_EMPTY_INTR,
 294         POST_BUF_EMPTY_INTR,
 295         PWM_GEN_INTR,
 296         DSP_HOLD_VALID_INTR,
 297 };
 298
 299 static const struct vop_intr rk3368_vop_intr = {
 300         .intrs = rk3368_vop_intrs,
 301         .nintrs = ARRAY_SIZE(rk3368_vop_intrs),
 302         .line_flag_num[0] = VOP_REG(RK3368_LINE_FLAG, 0xffff, 0),
 303         .line_flag_num[1] = VOP_REG(RK3368_LINE_FLAG, 0xffff, 16),
 304         .status = VOP_REG_MASK(RK3368_INTR_STATUS, 0x3fff, 0),
 305         .enable = VOP_REG_MASK(RK3368_INTR_EN, 0x3fff, 0),
 306         .clear = VOP_REG_MASK(RK3368_INTR_CLEAR, 0x3fff, 0),
 307 };
 308
 309 static const struct vop_win_phy rk3368_win23_data = {
 310         .data_formats = formats_win_lite,
 311         .nformats = ARRAY_SIZE(formats_win_lite),
 312         .gate = VOP_REG(RK3368_WIN2_CTRL0, 0x1, 0),
 313         .enable = VOP_REG(RK3368_WIN2_CTRL0, 0x1, 4),
 314         .format = VOP_REG(RK3368_WIN2_CTRL0, 0x3, 5),
 315         .ymirror = VOP_REG(RK3368_WIN2_CTRL1, 0x1, 15),
 316         .rb_swap = VOP_REG(RK3368_WIN2_CTRL0, 0x1, 20),
 317         .dsp_info = VOP_REG(RK3368_WIN2_DSP_INFO0, 0x0fff0fff, 0),
 318         .dsp_st = VOP_REG(RK3368_WIN2_DSP_ST0, 0x1fff1fff, 0),
 319         .yrgb_mst = VOP_REG(RK3368_WIN2_MST0, 0xffffffff, 0),
 320         .yrgb_vir = VOP_REG(RK3368_WIN2_VIR0_1, 0x1fff, 0),
 321         .src_alpha_ctl = VOP_REG(RK3368_WIN2_SRC_ALPHA_CTRL, 0xff, 0),
 322         .dst_alpha_ctl = VOP_REG(RK3368_WIN2_DST_ALPHA_CTRL, 0xff, 0),
 323 };
 324
 325 static const struct vop_win_phy rk3368_area1_data = {
 326         .enable = VOP_REG(RK3368_WIN2_CTRL0, 0x1, 8),
 327         .format = VOP_REG(RK3368_WIN2_CTRL0, 0x3, 9),
 328         .rb_swap = VOP_REG(RK3368_WIN2_CTRL0, 0x1, 23),
 329         .dsp_info = VOP_REG(RK3368_WIN2_DSP_INFO1, 0x0fff0fff, 0),
 330         .dsp_st = VOP_REG(RK3368_WIN2_DSP_ST1, 0x1fff1fff, 0),
 331         .yrgb_mst = VOP_REG(RK3368_WIN2_MST1, 0xffffffff, 0),
 332         .yrgb_vir = VOP_REG(RK3368_WIN2_VIR0_1, 0x1fff, 16),
 333 };
 334
 335 static const struct vop_win_phy rk3368_area2_data = {
 336         .enable = VOP_REG(RK3368_WIN2_CTRL0, 0x1, 12),
 337         .format = VOP_REG(RK3368_WIN2_CTRL0, 0x3, 13),
 338         .rb_swap = VOP_REG(RK3368_WIN2_CTRL0, 0x1, 26),
 339         .dsp_info = VOP_REG(RK3368_WIN2_DSP_INFO2, 0x0fff0fff, 0),
 340         .dsp_st = VOP_REG(RK3368_WIN2_DSP_ST2, 0x1fff1fff, 0),
 341         .yrgb_mst = VOP_REG(RK3368_WIN2_MST2, 0xffffffff, 0),
 342         .yrgb_vir = VOP_REG(RK3368_WIN2_VIR2_3, 0x1fff, 0),
 343 };
 344
 345 static const struct vop_win_phy rk3368_area3_data = {
 346         .enable = VOP_REG(RK3368_WIN2_CTRL0, 0x1, 16),
 347         .format = VOP_REG(RK3368_WIN2_CTRL0, 0x3, 17),
 348         .rb_swap = VOP_REG(RK3368_WIN2_CTRL0, 0x1, 29),
 349         .dsp_info = VOP_REG(RK3368_WIN2_DSP_INFO3, 0x0fff0fff, 0),
 350         .dsp_st = VOP_REG(RK3368_WIN2_DSP_ST3, 0x1fff1fff, 0),
 351         .yrgb_mst = VOP_REG(RK3368_WIN2_MST3, 0xffffffff, 0),
 352         .yrgb_vir = VOP_REG(RK3368_WIN2_VIR2_3, 0x1fff, 16),
 353 };
 354
 355 static const struct vop_win_phy *rk3368_area_data[] = {
 356         &rk3368_area1_data,
 357         &rk3368_area2_data,
 358         &rk3368_area3_data
 359 };
 360
 361 static const struct vop_win_data rk3368_vop_win_data[] = {
 362         { .base = 0x00, .phy = &rk3288_win01_data,
 363           .type = DRM_PLANE_TYPE_PRIMARY },
 364         { .base = 0x40, .phy = &rk3288_win01_data,
 365           .type = DRM_PLANE_TYPE_OVERLAY },
 366         { .base = 0x00, .phy = &rk3368_win23_data,
 367           .type = DRM_PLANE_TYPE_OVERLAY,
 368           .area = rk3368_area_data,
 369           .area_size = ARRAY_SIZE(rk3368_area_data), },
 370         { .base = 0x50, .phy = &rk3368_win23_data,
 371           .type = DRM_PLANE_TYPE_CURSOR,
 372           .area = rk3368_area_data,
 373           .area_size = ARRAY_SIZE(rk3368_area_data), },
 374 };
 375
 376 static const struct vop_data rk3368_vop = {
 377         .version = VOP_VERSION(3, 2),
 378         .feature = VOP_FEATURE_OUTPUT_10BIT,
 379         .max_input = {4096, 8192},
 380         .max_output = {4096, 2160},
 381         .intr = &rk3368_vop_intr,
 382         .ctrl = &rk3288_ctrl_data,
 383         .win = rk3368_vop_win_data,
 384         .win_size = ARRAY_SIZE(rk3368_vop_win_data),
 385 };
 386
 387 static const struct vop_intr rk3366_vop_intr = {
 388         .intrs = rk3368_vop_intrs,
 389         .nintrs = ARRAY_SIZE(rk3368_vop_intrs),
 390         .line_flag_num[0] = VOP_REG(RK3366_LINE_FLAG, 0xffff, 0),
 391         .line_flag_num[1] = VOP_REG(RK3366_LINE_FLAG, 0xffff, 16),
 392         .status = VOP_REG_MASK(RK3366_INTR_STATUS0, 0xffff, 0),
 393         .enable = VOP_REG_MASK(RK3366_INTR_EN0, 0xffff, 0),
 394         .clear = VOP_REG_MASK(RK3366_INTR_CLEAR0, 0xffff, 0),
 395 };
 396
 397 static const struct vop_data rk3366_vop = {
 398         .version = VOP_VERSION(3, 4),
 399         .feature = VOP_FEATURE_OUTPUT_10BIT,
 400         .max_input = {4096, 8192},
 401         .max_output = {4096, 2160},
 402         .intr = &rk3366_vop_intr,
 403         .ctrl = &rk3288_ctrl_data,
 404         .win = rk3368_vop_win_data,
 405         .win_size = ARRAY_SIZE(rk3368_vop_win_data),
 406 };
 407
 408 static const uint32_t vop_csc_y2r_bt601[] = {
 409         0x00000400, 0x0400059c, 0xfd25fea0, 0x07170400,
 410         0x00000000, 0xfffecab4, 0x00087932, 0xfff1d4f2,
 411 };
 412
 413 static const uint32_t vop_csc_y2r_bt601_12_235[] = {
 414         0x000004a8, 0x04a80662, 0xfcbffe6f, 0x081204a8,
 415         0x00000000, 0xfff2134e, 0x00087b58, 0xffeeb4b0,
 416 };
 417
 418 static const uint32_t vop_csc_r2y_bt601[] = {
 419         0x02590132, 0xff530075, 0x0200fead, 0xfe530200,
 420         0x0000ffad, 0x00000200, 0x00080200, 0x00080200,
 421 };
 422
 423 static const uint32_t vop_csc_r2y_bt601_12_235[] = {
 424         0x02040107, 0xff680064, 0x01c2fed6, 0xffb7fe87,
 425         0x0000ffb7, 0x00010200, 0x00080200, 0x00080200,
 426 };
 427
 428 static const uint32_t vop_csc_y2r_bt709[] = {
 429         0x000004a8, 0x04a8072c, 0xfddeff26, 0x087304a8,
 430         0x00000000, 0xfff08077, 0x0004cfed, 0xffedf1b8,
 431 };
 432
 433 static const uint32_t vop_csc_r2y_bt709[] = {
 434         0x027500bb, 0xff99003f, 0x01c2fea5, 0xfe6801c2,
 435         0xffd7fe68, 0x00010200, 0x00080200, 0x00080200,
 436 };
 437
 438 static const uint32_t vop_csc_y2r_bt2020[] = {
 439         0x000004a8, 0x04a806b6, 0xfd66ff40, 0x089004a8,
 440         0x00000000, 0xfff16bfc, 0x00058ae9, 0xffedb828,
 441 };
 442
 443 static const uint32_t vop_csc_r2y_bt2020[] = {
 444         0x025300e6, 0xff830034, 0x01c1febd, 0xfe6401c1,
 445         0x0000ffdc, 0x00010200, 0x00080200, 0x00080200,
 446 };
 447
 448 static const uint32_t vop_csc_r2r_bt709_to_bt2020[] = {
 449         0xfda606a4, 0xff80ffb5, 0xfff80488, 0xff99ffed,
 450         0x0000047a, 0x00000200, 0x00000200, 0x00000200,
 451 };
 452
 453 static const uint32_t vop_csc_r2r_bt2020_to_bt709[] = {
 454         0x01510282, 0x0047002c, 0x000c03ae, 0x005a0011,
 455         0x00000394, 0x00000200, 0x00000200, 0x00000200,
 456 };
 457
 458 static const struct vop_csc_table rk3399_csc_table = {
 459         .y2r_bt601              = vop_csc_y2r_bt601,
 460         .y2r_bt601_12_235       = vop_csc_y2r_bt601_12_235,
 461         .r2y_bt601              = vop_csc_r2y_bt601,
 462         .r2y_bt601_12_235       = vop_csc_r2y_bt601_12_235,
 463
 464         .y2r_bt709              = vop_csc_y2r_bt709,
 465         .r2y_bt709              = vop_csc_r2y_bt709,
 466
 467         .y2r_bt2020             = vop_csc_y2r_bt2020,
 468         .r2y_bt2020             = vop_csc_r2y_bt2020,
 469
 470         .r2r_bt709_to_bt2020    = vop_csc_r2r_bt709_to_bt2020,
 471         .r2r_bt2020_to_bt709    = vop_csc_r2r_bt2020_to_bt709,
 472 };
 473
 474 static const struct vop_csc rk3399_win0_csc = {
 475         .r2r_en = VOP_REG(RK3399_YUV2YUV_WIN, 0x1, 0),
 476         .y2r_en = VOP_REG(RK3399_YUV2YUV_WIN, 0x1, 1),
 477         .r2y_en = VOP_REG(RK3399_YUV2YUV_WIN, 0x1, 2),
 478         .y2r_offset = RK3399_WIN0_YUV2YUV_Y2R,
 479         .r2r_offset = RK3399_WIN0_YUV2YUV_3X3,
 480         .r2y_offset = RK3399_WIN0_YUV2YUV_R2Y,
 481 };
 482
 483 static const struct vop_csc rk3399_win1_csc = {
 484         .r2r_en = VOP_REG(RK3399_YUV2YUV_WIN, 0x1, 8),
 485         .y2r_en = VOP_REG(RK3399_YUV2YUV_WIN, 0x1, 9),
 486         .r2y_en = VOP_REG(RK3399_YUV2YUV_WIN, 0x1, 10),
 487         .y2r_offset = RK3399_WIN1_YUV2YUV_Y2R,
 488         .r2r_offset = RK3399_WIN1_YUV2YUV_3X3,
 489         .r2y_offset = RK3399_WIN1_YUV2YUV_R2Y,
 490 };
 491
 492 static const struct vop_win_data rk3399_vop_win_data[] = {
 493         { .base = 0x00, .phy = &rk3288_win01_data, .csc = &rk3399_win0_csc,
 494           .type = DRM_PLANE_TYPE_PRIMARY },
 495         { .base = 0x40, .phy = &rk3288_win01_data, .csc = &rk3399_win1_csc,
 496           .type = DRM_PLANE_TYPE_OVERLAY },
 497         { .base = 0x00, .phy = &rk3368_win23_data,
 498           .type = DRM_PLANE_TYPE_OVERLAY,
 499           .area = rk3368_area_data,
 500           .area_size = ARRAY_SIZE(rk3368_area_data), },
 501         { .base = 0x50, .phy = &rk3368_win23_data,
 502           .type = DRM_PLANE_TYPE_CURSOR,
 503           .area = rk3368_area_data,
 504           .area_size = ARRAY_SIZE(rk3368_area_data), },
 505 };
 506
 507 static const struct vop_data rk3399_vop_big = {
 508         .version = VOP_VERSION(3, 5),
 509         .csc_table = &rk3399_csc_table,
 510         .feature = VOP_FEATURE_OUTPUT_10BIT | VOP_FEATURE_AFBDC,
 511         .max_input = {4096, 8192},
 512         .max_output = {4096, 2160},
 513         .intr = &rk3366_vop_intr,
 514         .ctrl = &rk3288_ctrl_data,
 515         .win = rk3399_vop_win_data,
 516         .win_size = ARRAY_SIZE(rk3399_vop_win_data),
 517 };
 518
 519 static const struct vop_win_data rk3399_vop_lit_win_data[] = {
 520         { .base = 0x00, .phy = &rk3288_win01_data, .csc = &rk3399_win0_csc,
 521           .type = DRM_PLANE_TYPE_PRIMARY },
 522         { .phy = NULL },
 523         { .base = 0x00, .phy = &rk3368_win23_data,
 524           .type = DRM_PLANE_TYPE_CURSOR,
 525           .area = rk3368_area_data,
 526           .area_size = ARRAY_SIZE(rk3368_area_data), },
 527         { .phy = NULL },
 528 };
 529
 530
 531 static const struct vop_data rk3399_vop_lit = {
 532         .version = VOP_VERSION(3, 6),
 533         .csc_table = &rk3399_csc_table,
 534         .max_input = {4096, 8192},
 535         .max_output = {2560, 1600},
 536         .intr = &rk3366_vop_intr,
 537         .ctrl = &rk3288_ctrl_data,
 538         .win = rk3399_vop_lit_win_data,
 539         .win_size = ARRAY_SIZE(rk3399_vop_lit_win_data),
 540 };
 541
 542 static const struct vop_data rk322x_vop = {
 543         .version = VOP_VERSION(3, 7),
 544         .feature = VOP_FEATURE_OUTPUT_10BIT,
 545         .max_input = {4096, 8192},
 546         .max_output = {4096, 2160},
 547         .intr = &rk3366_vop_intr,
 548         .ctrl = &rk3288_ctrl_data,
 549         .win = rk3368_vop_win_data,
 550         .win_size = ARRAY_SIZE(rk3368_vop_win_data),
 551 };
 552
 553 static const struct vop_ctrl rk3328_ctrl_data = {
 554         .standby = VOP_REG(RK3328_SYS_CTRL, 0x1, 22),
 555         .auto_gate_en = VOP_REG(RK3328_SYS_CTRL, 0x1, 23),
 556         .htotal_pw = VOP_REG(RK3328_DSP_HTOTAL_HS_END, 0x1fff1fff, 0),
 557         .hact_st_end = VOP_REG(RK3328_DSP_HACT_ST_END, 0x1fff1fff, 0),
 558         .vtotal_pw = VOP_REG(RK3328_DSP_VTOTAL_VS_END, 0x1fff1fff, 0),
 559         .vact_st_end = VOP_REG(RK3328_DSP_VACT_ST_END, 0x1fff1fff, 0),
 560         .vact_st_end_f1 = VOP_REG(RK3328_DSP_VACT_ST_END_F1, 0x1fff1fff, 0),
 561         .vs_st_end_f1 = VOP_REG(RK3328_DSP_VS_ST_END_F1, 0x1fff1fff, 0),
 562         .hpost_st_end = VOP_REG(RK3328_POST_DSP_HACT_INFO, 0x1fff1fff, 0),
 563         .vpost_st_end = VOP_REG(RK3328_POST_DSP_VACT_INFO, 0x1fff1fff, 0),
 564         .vpost_st_end_f1 = VOP_REG(RK3328_POST_DSP_VACT_INFO_F1, 0x1fff1fff, 0),
 565         .dsp_interlace = VOP_REG(RK3328_DSP_CTRL0, 0x1, 10),
 566         .dsp_layer_sel = VOP_REG(RK3328_DSP_CTRL1, 0xff, 8),
 567         .post_lb_mode = VOP_REG(RK3328_SYS_CTRL, 0x1, 18),
 568         .global_regdone_en = VOP_REG(RK3328_SYS_CTRL, 0x1, 11),
 569         .overlay_mode = VOP_REG(RK3328_SYS_CTRL, 0x1, 16),
 570         .core_dclk_div = VOP_REG(RK3328_DSP_CTRL0, 0x1, 4),
 571         .p2i_en = VOP_REG(RK3328_DSP_CTRL0, 0x1, 5),
 572         .rgb_en = VOP_REG(RK3328_SYS_CTRL, 0x1, 12),
 573         .hdmi_en = VOP_REG(RK3328_SYS_CTRL, 0x1, 13),
 574         .edp_en = VOP_REG(RK3328_SYS_CTRL, 0x1, 14),
 575         .mipi_en = VOP_REG(RK3328_SYS_CTRL, 0x1, 15),
 576         .rgb_pin_pol = VOP_REG(RK3328_DSP_CTRL1, 0xf, 16),
 577         .hdmi_pin_pol = VOP_REG(RK3328_DSP_CTRL1, 0xf, 20),
 578         .edp_pin_pol = VOP_REG(RK3328_DSP_CTRL1, 0xf, 24),
 579         .mipi_pin_pol = VOP_REG(RK3328_DSP_CTRL1, 0xf, 28),
 580
 581         .dither_down = VOP_REG(RK3328_DSP_CTRL1, 0xf, 1),
 582         .dither_up = VOP_REG(RK3328_DSP_CTRL1, 0x1, 6),
 583
 584         .dsp_data_swap = VOP_REG(RK3328_DSP_CTRL0, 0x1f, 12),
 585         .dsp_ccir656_avg = VOP_REG(RK3328_DSP_CTRL0, 0x1, 20),
 586         .dsp_blank = VOP_REG(RK3328_DSP_CTRL0, 0x3, 18),
 587         .dsp_lut_en = VOP_REG(RK3328_DSP_CTRL1, 0x1, 0),
 588         .out_mode = VOP_REG(RK3328_DSP_CTRL0, 0xf, 0),
 589
 590         .xmirror = VOP_REG(RK3328_DSP_CTRL0, 0x1, 22),
 591         .ymirror = VOP_REG(RK3328_DSP_CTRL0, 0x1, 23),
 592
 593         .dsp_background = VOP_REG(RK3328_DSP_BG, 0xffffffff, 0),
 594
 595         .cfg_done = VOP_REG(RK3328_REG_CFG_DONE, 0x1, 0),
 596 };
 597
 598 static const struct vop_intr rk3328_vop_intr = {
 599         .intrs = rk3368_vop_intrs,
 600         .nintrs = ARRAY_SIZE(rk3368_vop_intrs),
 601         .line_flag_num[0] = VOP_REG(RK3328_LINE_FLAG, 0xffff, 0),
 602         .line_flag_num[1] = VOP_REG(RK3328_LINE_FLAG, 0xffff, 16),
 603         .status = VOP_REG_MASK(RK3328_INTR_STATUS0, 0xffff, 0),
 604         .enable = VOP_REG_MASK(RK3328_INTR_EN0, 0xffff, 0),
 605         .clear = VOP_REG_MASK(RK3328_INTR_CLEAR0, 0xffff, 0),
 606 };
 607
 608 static const struct vop_win_data rk3328_vop_win_data[] = {
 609         { .base = 0xd0, .phy = &rk3288_win01_data,
 610           .type = DRM_PLANE_TYPE_PRIMARY },
 611         { .base = 0x1d0, .phy = &rk3288_win01_data,
 612           .type = DRM_PLANE_TYPE_OVERLAY },
 613         { .base = 0x2d0, .phy = &rk3288_win01_data,
 614           .type = DRM_PLANE_TYPE_OVERLAY },
 615         { .base = 0x3d0, .phy = &rk3288_win01_data,
 616           .type = DRM_PLANE_TYPE_CURSOR },
 617 };
 618
 619 static const struct vop_data rk3328_vop = {
 620         .version = VOP_VERSION(3, 8),
 621         .feature = VOP_FEATURE_OUTPUT_10BIT,
 622         .max_input = {4096, 8192},
 623         .max_output = {4096, 2160},
 624         .intr = &rk3328_vop_intr,
 625         .ctrl = &rk3328_ctrl_data,
 626         .win = rk3328_vop_win_data,
 627         .win_size = ARRAY_SIZE(rk3328_vop_win_data),
 628 };
 629
 630 static const struct vop_scl_regs rk3066_win_scl = {
 631         .scale_yrgb_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 0x0),
 632         .scale_yrgb_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 16),
 633         .scale_cbcr_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 0x0),
 634         .scale_cbcr_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 16),
 635 };
 636
 637 static const struct vop_win_phy rk3036_win0_data = {
 638         .scl = &rk3066_win_scl,
 639         .data_formats = formats_win_full,
 640         .nformats = ARRAY_SIZE(formats_win_full),
 641         .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 0),
 642         .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 3),
 643         .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 15),
 644         .act_info = VOP_REG(RK3036_WIN0_ACT_INFO, 0x1fff1fff, 0),
 645         .dsp_info = VOP_REG(RK3036_WIN0_DSP_INFO, 0x0fff0fff, 0),
 646         .dsp_st = VOP_REG(RK3036_WIN0_DSP_ST, 0x1fff1fff, 0),
 647         .yrgb_mst = VOP_REG(RK3036_WIN0_YRGB_MST, 0xffffffff, 0),
 648         .uv_mst = VOP_REG(RK3036_WIN0_CBR_MST, 0xffffffff, 0),
 649         .yrgb_vir = VOP_REG(RK3036_WIN0_VIR, 0xffff, 0),
 650         .uv_vir = VOP_REG(RK3036_WIN0_VIR, 0x1fff, 16),
 651         .alpha_mode = VOP_REG(RK3036_DSP_CTRL0, 0x1, 18),
 652         .alpha_en = VOP_REG(RK3036_ALPHA_CTRL, 0x1, 0)
 653 };
 654
 655 static const struct vop_win_phy rk3036_win1_data = {
 656         .data_formats = formats_win_lite,
 657         .nformats = ARRAY_SIZE(formats_win_lite),
 658         .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 1),
 659         .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 6),
 660         .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 19),
 661         .act_info = VOP_REG(RK3036_WIN1_ACT_INFO, 0x1fff1fff, 0),
 662         .dsp_info = VOP_REG(RK3036_WIN1_DSP_INFO, 0x0fff0fff, 0),
 663         .dsp_st = VOP_REG(RK3036_WIN1_DSP_ST, 0x1fff1fff, 0),
 664         .yrgb_mst = VOP_REG(RK3036_WIN1_MST, 0xffffffff, 0),
 665         .yrgb_vir = VOP_REG(RK3036_WIN1_VIR, 0xffff, 0),
 666         .alpha_mode = VOP_REG(RK3036_DSP_CTRL0, 0x1, 19),
 667         .alpha_en = VOP_REG(RK3036_ALPHA_CTRL, 0x1, 1)
 668 };
 669
 670 static const struct vop_win_data rk3036_vop_win_data[] = {
 671         { .base = 0x00, .phy = &rk3036_win0_data,
 672           .type = DRM_PLANE_TYPE_PRIMARY },
 673         { .base = 0x00, .phy = &rk3036_win1_data,
 674           .type = DRM_PLANE_TYPE_CURSOR },
 675 };
 676
 677 static const int rk3036_vop_intrs[] = {
 678         DSP_HOLD_VALID_INTR,
 679         FS_INTR,
 680         LINE_FLAG_INTR,
 681         BUS_ERROR_INTR,
 682 };
 683
 684 static const struct vop_intr rk3036_intr = {
 685         .intrs = rk3036_vop_intrs,
 686         .nintrs = ARRAY_SIZE(rk3036_vop_intrs),
 687         .line_flag_num[0] = VOP_REG(RK3036_INT_STATUS, 0xfff, 12),
 688         .status = VOP_REG(RK3036_INT_STATUS, 0xf, 0),
 689         .enable = VOP_REG(RK3036_INT_STATUS, 0xf, 4),
 690         .clear = VOP_REG(RK3036_INT_STATUS, 0xf, 8),
 691 };
 692
 693 static const struct vop_ctrl rk3036_ctrl_data = {
 694         .standby = VOP_REG(RK3036_SYS_CTRL, 0x1, 30),
 695         .out_mode = VOP_REG(RK3036_DSP_CTRL0, 0xf, 0),
 696         .dsp_blank = VOP_REG(RK3036_DSP_CTRL1, 0x1, 24),
 697         .pin_pol = VOP_REG(RK3036_DSP_CTRL0, 0xf, 4),
 698         .dsp_layer_sel = VOP_REG(RK3036_DSP_CTRL0, 0x1, 8),
 699         .htotal_pw = VOP_REG(RK3036_DSP_HTOTAL_HS_END, 0x1fff1fff, 0),
 700         .hact_st_end = VOP_REG(RK3036_DSP_HACT_ST_END, 0x1fff1fff, 0),
 701         .vtotal_pw = VOP_REG(RK3036_DSP_VTOTAL_VS_END, 0x1fff1fff, 0),
 702         .vact_st_end = VOP_REG(RK3036_DSP_VACT_ST_END, 0x1fff1fff, 0),
 703         .cfg_done = VOP_REG(RK3036_REG_CFG_DONE, 0x1, 0),
 704 };
 705
 706 static const struct vop_data rk3036_vop = {
 707         .version = VOP_VERSION(2, 2),
 708         .max_input = {1920, 1080},
 709         .max_output = {1920, 1080},
 710         .ctrl = &rk3036_ctrl_data,
 711         .intr = &rk3036_intr,
 712         .win = rk3036_vop_win_data,
 713         .win_size = ARRAY_SIZE(rk3036_vop_win_data),
 714 };
 715
 716 static const struct of_device_id vop_driver_dt_match[] = {
 717         { .compatible = "rockchip,rk3036-vop",
 718           .data = &rk3036_vop },
 719         { .compatible = "rockchip,rk3288-vop",
 720           .data = &rk3288_vop },
 721         { .compatible = "rockchip,rk3368-vop",
 722           .data = &rk3368_vop },
 723         { .compatible = "rockchip,rk3366-vop",
 724           .data = &rk3366_vop },
 725         { .compatible = "rockchip,rk3399-vop-big",
 726           .data = &rk3399_vop_big },
 727         { .compatible = "rockchip,rk3399-vop-lit",
 728           .data = &rk3399_vop_lit },
 729         { .compatible = "rockchip,rk322x-vop",
 730           .data = &rk322x_vop },
 731         { .compatible = "rockchip,rk3328-vop",
 732           .data = &rk3328_vop },
 733         {},
 734 };
 735 MODULE_DEVICE_TABLE(of, vop_driver_dt_match);
 736
 737 static int vop_probe(struct platform_device *pdev)
 738 {
 739         struct device *dev = &pdev->dev;
 740
 741         if (!dev->of_node) {
 742                 dev_err(dev, "can't find vop devices\n");
 743                 return -ENODEV;
 744         }
 745
 746         return component_add(dev, &vop_component_ops);
 747 }
 748
 749 static int vop_remove(struct platform_device *pdev)
 750 {
 751         component_del(&pdev->dev, &vop_component_ops);
 752
 753         return 0;
 754 }
 755
 756 struct platform_driver vop_platform_driver = {
 757         .probe = vop_probe,
 758         .remove = vop_remove,
 759         .driver = {
 760                 .name = "rockchip-vop",
 761                 .owner = THIS_MODULE,
 762                 .of_match_table = of_match_ptr(vop_driver_dt_match),
 763         },
 764 };
 765
 766 module_platform_driver(vop_platform_driver);
 767
 768 MODULE_AUTHOR("Mark Yao <mark.yao@rock-chips.com>");
 769 MODULE_DESCRIPTION("ROCKCHIP VOP Driver");
 770 MODULE_LICENSE("GPL v2");