/* Found empty spot in free list */
if (idx == 0) {
- //store_32(&free_lists[t][i], node);
- free_lists[t][i] = node;
+ store_32(&free_lists[t][i], node);
+ //free_lists[t][i] = node;
return;
}
}
atomic_store_explicit(&q->nodes[node].next, tmp, relaxed);
while (!success) {
+
/**
@Begin
@Commit_point_clear: true
@Label: Enqueue_Clear
@End
*/
- /**** detected UL ****/
+ /**** UL & inadmissible ****/
tail = atomic_load_explicit(&q->tail, acquire);
- /**
- @Begin
- @Commit_point_define_check: true
- @Label: Enqueue_Read_Tail
- @End
- */
/****FIXME: miss ****/
next = atomic_load_explicit(&q->nodes[get_ptr(tail)].next, acquire);
//printf("miss1_enqueue\n");
if (get_ptr(next) == 0) { // == NULL
pointer value = MAKE_POINTER(node, get_count(next) + 1);
- /**** detected UL ****/
+ /**** SPEC Error (testcase1.c) ****/
// Second release can be just relaxed
success = atomic_compare_exchange_strong_explicit(&q->nodes[get_ptr(tail)].next,
&next, value, release, relaxed);
/**
@Begin
@Commit_point_define_check: success
- @Label: Enqueue_UpdateNext
+ @Label: EnqueueUpdateNext
@End
*/
}
if (!success) {
// This routine helps the other enqueue to update the tail
- /**** detected UL ****/
+ /**** UL & Inadmissible ****/
unsigned int ptr = get_ptr(atomic_load_explicit(&q->nodes[get_ptr(tail)].next, acquire));
pointer value = MAKE_POINTER(ptr,
get_count(tail) + 1);
}
}
}
- /**** dectected UL ****/
+ /**** UL & Inadmissible ****/
// Second release can be just relaxed
bool succ = atomic_compare_exchange_strong_explicit(&q->tail,
&tail,
MAKE_POINTER(node, get_count(tail) + 1),
release, relaxed);
- /**
- @Begin
- @Additional_ordering_point_define_check: true
- @Label: Enqueue_Additional_Tail_LoadOrCAS
- @End
- */
-
}
/**
@Label: Dequeue_Clear
@End
*/
- /**** detected correctness error ****/
+ /**** Inadmissible ****/
head = atomic_load_explicit(&q->head, acquire);
/**
@Begin
@Commit_point_define_check: true
- @Label: Dequeue_Read_Head
+ @Label: DequeueReadHead
@End
*/
- /** FIXME: A new bug has been found here!!! It should be acquire instead of
+
+ /** A new bug has been found here!!! It should be acquire instead of
* relaxed (it introduces a bug when there's two dequeuers and one
- * enqueuer)
+ * enqueuer) correctness bug!!
*/
+ /**** New bug ****/
tail = atomic_load_explicit(&q->tail, acquire);
- /**
- @Begin
- @Potential_commit_point_define: true
- @Label: Dequeue_Potential_Read_Tail
- @End
- */
- /**** Detected UL/DR (testcase1.c) ****/
+ /**** SPEC Error (testcase1.c) ****/
next = atomic_load_explicit(&q->nodes[get_ptr(head)].next, acquire);
/**
@Begin
- @Potential_commit_point_define: true
- @Label: Dequeue_Potential_LoadNext
+ @Potential_commit_point_define: true
+ @Label: DequeueReadNext
@End
*/
-
if (atomic_load_explicit(&q->head, relaxed) == head) {
if (get_ptr(head) == get_ptr(tail)) {
/* Check for uninitialized 'next' */
//MODEL_ASSERT(get_ptr(next) != POISON_IDX);
- if (get_ptr(next) == 0) { // NULL
- /**
- @Begin
- @Commit_point_define: true
- @Potential_commit_point_label: Dequeue_Potential_Read_Tail
- @Label: Dequeue_Read_Tail
- @End
- */
+ if (get_ptr(next) == 0) { // NULL
return false; // NULL
}
- /**** Detected UL (testcase1.c) ****/
+ /**** FIXME: miss ****/
// Second release can be just relaxed
bool succ = false;
succ = atomic_compare_exchange_strong_explicit(&q->tail,
} else {
//value = load_32(&q->nodes[get_ptr(next)].value);
value = q->nodes[get_ptr(next)].value;
- /****FIXME: correctness error ****/
+ /**** inadmissibility ****/
success = atomic_compare_exchange_strong_explicit(&q->head,
&head,
MAKE_POINTER(get_ptr(next), get_count(head) + 1),
release, relaxed);
+ /**
+ @Begin
+ @Commit_point_define_check: success
+ @Label: DequeueUpdateHead
+ @End
+ */
+
/**
@Begin
@Commit_point_define: success
- @Potential_commit_point_label: Dequeue_Potential_LoadNext
- @Label: Dequeue_LoadNext
+ @Potential_commit_point_label: DequeueReadNext
+ @Label: DequeueReadNextVerify
@End
*/
if (!success)