From 51c8be1f188633adb5deb3a34b13d205c0a141f1 Mon Sep 17 00:00:00 2001 From: Brian Norris Date: Thu, 13 Sep 2012 09:53:59 -0700 Subject: [PATCH] model: kill unneeded local variable The "Thread *th" variable is used only on a few control paths, and it is never reused. Might as well just calculate it on the fly. Also, it's recalculated and masked by another local variable at a deeper level of nesting. --- model.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/model.cc b/model.cc index b4a36559..4475455b 100644 --- a/model.cc +++ b/model.cc @@ -392,11 +392,9 @@ Thread * ModelChecker::check_current_action(ModelAction *curr) break; } - Thread *th = get_thread(curr); - bool updated = false; if (curr->is_read()) { - updated = process_read(curr, th, second_part_of_rmw); + updated = process_read(curr, get_thread(curr), second_part_of_rmw); } if (curr->is_write()) { @@ -415,7 +413,7 @@ Thread * ModelChecker::check_current_action(ModelAction *curr) } mo_graph->commitChanges(); - th->set_return_value(VALUE_NONE); + get_thread(curr)->set_return_value(VALUE_NONE); } if (updated) -- 2.34.1