c11tester.git
9 years agomymemory: kill system_malloc()
Brian Norris [Mon, 8 Oct 2012 20:11:13 +0000 (13:11 -0700)]
mymemory: kill system_malloc()

Not needed

9 years agosnapshot: use snapshot_space only in mprotect-based
Brian Norris [Mon, 8 Oct 2012 19:58:01 +0000 (12:58 -0700)]
snapshot: use snapshot_space only in mprotect-based

We don't need this heap for fork-based snapshotting, so clearly separate
the functionality here.

This also makes PageAlignedAdressUpdate() available only for
mprotect-based snapshotting.

9 years agosnapshot: don't need any snapshotting space for fork-based
Brian Norris [Mon, 8 Oct 2012 19:46:53 +0000 (12:46 -0700)]
snapshot: don't need any snapshotting space for fork-based

I have no idea why this was here in the first place. Somebody didn't
know what they were doing...

9 years agorename 'mySpace' to 'snapshot_space'
Brian Norris [Mon, 8 Oct 2012 19:38:53 +0000 (12:38 -0700)]
rename 'mySpace' to 'snapshot_space'

9 years agomymemory: make DontFree() static
Brian Norris [Mon, 8 Oct 2012 19:34:22 +0000 (12:34 -0700)]
mymemory: make DontFree() static

9 years agomymemory: reformat spacing
Brian Norris [Mon, 8 Oct 2012 19:30:06 +0000 (12:30 -0700)]
mymemory: reformat spacing

9 years agomymemory: kill system_free()
Brian Norris [Mon, 8 Oct 2012 19:21:15 +0000 (12:21 -0700)]
mymemory: kill system_free()

This function is not used

9 years agosnapshot: remove global 'basemySpace'
Brian Norris [Mon, 8 Oct 2012 19:13:07 +0000 (12:13 -0700)]
snapshot: remove global 'basemySpace'

Why was this here?

9 years agotest: linuxrwlocks: fixup spacing
Brian Norris [Mon, 8 Oct 2012 17:31:41 +0000 (10:31 -0700)]
test: linuxrwlocks: fixup spacing

9 years agomodel: remove todo
Brian Norris [Mon, 8 Oct 2012 17:25:29 +0000 (10:25 -0700)]
model: remove todo

9 years agomerge massive speedup with release sequence support...
Brian Demsky [Mon, 8 Oct 2012 08:21:35 +0000 (01:21 -0700)]
merge massive speedup with release sequence support...

Merge branch 'master' of ssh://demsky.eecs.uci.edu/home/git/model-checker

Conflicts:
schedule.cc
schedule.h

9 years agoadd support for sleep sets...
Brian Demsky [Mon, 8 Oct 2012 08:15:06 +0000 (01:15 -0700)]
add support for sleep sets...

9 years agotest: add "double release sequence" test
Brian Norris [Mon, 8 Oct 2012 06:30:48 +0000 (23:30 -0700)]
test: add "double release sequence" test

This test uses two separate load-acquire's to establish the same release
sequence. This can cause problems with the current release sequence
fixups, so that we find an execution where one synchronizes and the
other doesn't, even when reading from the same sequence.

9 years agoMerge branch 'norris'
Brian Norris [Mon, 8 Oct 2012 06:25:48 +0000 (23:25 -0700)]
Merge branch 'norris'

9 years agomodel: add todo synchronization comment
Brian Norris [Mon, 8 Oct 2012 06:24:21 +0000 (23:24 -0700)]
model: add todo synchronization comment

9 years agomodel: be sure trace is "final feasible" before continuing to fixup
Brian Norris [Mon, 8 Oct 2012 06:16:03 +0000 (23:16 -0700)]
model: be sure trace is "final feasible" before continuing to fixup

Release sequences fixup can break pretty badly if there are outstanding
promises. Solution: check for final-feasible traces before continuing to
fixup.

9 years agotests: add some normal loads/stores to test data races
Brian Norris [Mon, 8 Oct 2012 05:19:01 +0000 (22:19 -0700)]
tests: add some normal loads/stores to test data races

These tests had become less useful, since the model-checker would ignore
release sequence fixup in the absence of pending data races. So add some
normal loads and stores to our tests, inducing some data races and some
proper synchronization.

9 years agomodel: check data races during release sequence fixup
Brian Norris [Mon, 8 Oct 2012 05:17:12 +0000 (22:17 -0700)]
model: check data races during release sequence fixup

This solves two problems:

1. I wasn't even checking for resolved data races after fixing up
   release sequence(s)

2. Launching of release sequence fixups now requires that there be
   pending data races

9 years agomodel: add release sequence model_thread ASSERT()
Brian Norris [Sun, 7 Oct 2012 22:23:37 +0000 (15:23 -0700)]
model: add release sequence model_thread ASSERT()

This ASSERT() should ensure that model-checker threads are always
'future_ordered'.

9 years agomodel: launch release sequence fixup actions when necessary
Brian Norris [Sat, 6 Oct 2012 02:20:21 +0000 (19:20 -0700)]
model: launch release sequence fixup actions when necessary

This should complete the "release sequence fixup" step. The ModelChecker
will launch new fixup actions, associating them with the special
'model_thread'.

9 years agomodel: add special model-checker Thread to ModelChecker
Brian Norris [Sat, 6 Oct 2012 02:18:13 +0000 (19:18 -0700)]
model: add special model-checker Thread to ModelChecker

Note the change in take_step(), so that we base the "current thread" off
of the provided ModelAction, rather than thread_current() (i.e., the
Scheduler). This is because the Scheduler will never run the
model-checker thread.

9 years agoschedule: do not allow model-checker thread to enter scheduler
Brian Norris [Sat, 6 Oct 2012 01:29:45 +0000 (18:29 -0700)]
schedule: do not allow model-checker thread to enter scheduler

9 years agothreads: add constructor for model-checker thread
Brian Norris [Sat, 6 Oct 2012 00:50:37 +0000 (17:50 -0700)]
threads: add constructor for model-checker thread

This thread will never have its own stack, and it should never be
inserted into the Scheduler.

9 years agothreads: add flag for a special type of "model-checker thread"
Brian Norris [Sat, 6 Oct 2012 00:42:03 +0000 (17:42 -0700)]
threads: add flag for a special type of "model-checker thread"

Special model-checker thread(s) might be needed when producing special
model-checker ModelActions.

9 years agoaction: add Thread parameter to constructor
Brian Norris [Sat, 6 Oct 2012 00:39:49 +0000 (17:39 -0700)]
action: add Thread parameter to constructor

We will need to create ModelActions that are forced to associate with a
specific Thread (contrary to the Scheduler's knowledge), so add a
constructor parameter.

9 years agomodel: add process_relseq_fixup()
Brian Norris [Fri, 5 Oct 2012 07:07:10 +0000 (00:07 -0700)]
model: add process_relseq_fixup()

This performs the bulk of the release sequence finalization step.

9 years agocommon: improve backtrace function
Brian Norris [Sat, 6 Oct 2012 02:34:01 +0000 (19:34 -0700)]
common: improve backtrace function

Utilize freely-available backtrace function that helps make output more
readable. Previous implementation is kept for now, as it is simpler and
more well-tested.

9 years agoadd stacktrace header, under WTFPL
Brian Norris [Sat, 6 Oct 2012 02:28:19 +0000 (19:28 -0700)]
add stacktrace header, under WTFPL

Download:
http://idlebox.net/2008/0901-stacktrace-demangled/stacktrace.h

WTFPL:
http://sam.zoy.org/wtfpl/

9 years agomodel: wire up rest of release seq. resolution backtracking
Brian Norris [Sun, 7 Oct 2012 23:18:07 +0000 (16:18 -0700)]
model: wire up rest of release seq. resolution backtracking

I still need to actually initiate the special ModelAction fixups.

9 years agonodestack: add release sequence breakage backtracking
Brian Norris [Sun, 7 Oct 2012 23:12:00 +0000 (16:12 -0700)]
nodestack: add release sequence breakage backtracking

End-of-execution resolution of release sequences requires a search
procedure in which we test various attempts at breaking our pending
release sequences. This provides the NodeStack infrastructure.

9 years agoaction: add MODEL_FIXUP_RELSEQ action_type
Brian Norris [Fri, 5 Oct 2012 05:38:37 +0000 (22:38 -0700)]
action: add MODEL_FIXUP_RELSEQ action_type

This type will be used as a special model-checker action for fixing up
release sequences. Each action corresponds to "finalizing" one release
sequence: either force a particular write to break the sequence or else
allow the synchronization to occur.

Currently, this action_type won't do anything, as it's not hooked up in
ModelChecker.

9 years agomodel: disabled threads are "future ordered"
Brian Norris [Sun, 7 Oct 2012 22:04:08 +0000 (15:04 -0700)]
model: disabled threads are "future ordered"

If a Thread is not currently enabled, then it will synchronize with
another (currently-enabled) Thread if/when it wakes up. Thus, it
qualifies as "future ordered" within the release sequence code: it
cannot contribute future writes that will break current pending release
sequences.

9 years agomodel: use proper size_t printf format
Brian Norris [Sun, 7 Oct 2012 22:02:16 +0000 (15:02 -0700)]
model: use proper size_t printf format

9 years agoschedule: add is_enabled() function
Brian Norris [Sun, 7 Oct 2012 21:57:42 +0000 (14:57 -0700)]
schedule: add is_enabled() function

The release sequence functionality needs to check whether a Thread is
currently enabled (rather than finding this information in a particular
Node).

Also, rename the (private) 'is_enabled' field to avoid a name conflict.

9 years agoMerge branch 'master' of ssh://demsky.eecs.uci.edu/home/git/model-checker
Brian Demsky [Sat, 6 Oct 2012 01:50:24 +0000 (18:50 -0700)]
Merge branch 'master' of ssh://demsky.eecs.uci.edu/home/git/model-checker

9 years agocreate enumeration for enabled information...switch from bools to the enumeration
Brian Demsky [Sat, 6 Oct 2012 00:15:49 +0000 (17:15 -0700)]
create enumeration for enabled information...switch from bools to the enumeration

9 years agocyclegraph: fix indentation
Brian Norris [Sat, 6 Oct 2012 00:07:49 +0000 (17:07 -0700)]
cyclegraph: fix indentation

9 years agocyclegraph: flag cycles for reflexive edges
Brian Norris [Sat, 6 Oct 2012 00:03:01 +0000 (17:03 -0700)]
cyclegraph: flag cycles for reflexive edges

The cyclegraph shouldn't fail (i.e., ASSERT()) when reflexive edges are
added; instead, they should be declared as cycles.

9 years ago1) more comments
Brian Demsky [Fri, 5 Oct 2012 02:44:14 +0000 (19:44 -0700)]
1) more comments
2) rename is_synchronizing with
3) realize that reordering is only necessary if we create a synchronization...not needed to break one...

9 years agoMerge branch 'master' of ssh://demsky.eecs.uci.edu/home/git/model-checker
Brian Demsky [Fri, 5 Oct 2012 00:37:38 +0000 (17:37 -0700)]
Merge branch 'master' of ssh://demsky.eecs.uci.edu/home/git/model-checker

9 years agochanges
Brian Demsky [Fri, 5 Oct 2012 00:37:12 +0000 (17:37 -0700)]
changes

9 years agonodestack: destroy Nodes properly in ~NodeStack()
Brian Norris [Thu, 4 Oct 2012 21:59:44 +0000 (14:59 -0700)]
nodestack: destroy Nodes properly in ~NodeStack()

9 years agonodestack: use initializer list
Brian Norris [Thu, 4 Oct 2012 21:57:37 +0000 (14:57 -0700)]
nodestack: use initializer list

9 years agomodel: remove unnecessary boolean variable
Brian Norris [Thu, 4 Oct 2012 19:11:05 +0000 (12:11 -0700)]
model: remove unnecessary boolean variable

9 years agomodel: assign "pending" return values in release_seq_heads()
Brian Norris [Thu, 4 Oct 2012 19:42:13 +0000 (12:42 -0700)]
model: assign "pending" return values in release_seq_heads()

Now that the lazy pending release sequences list is improved, return
more information from release_seq_heads().

Note that this change also affects the behavior of the last double loop;
now, even after discovering write(s) from one thread that might break the
release sequence, I continue exploring other threads. This has some pros
and cons:

Con:
* may cause more work in exploring many threads without gaining any
  extra information

Pro:
* may help discover a write that *certainly* breaks the sequence,
  whereas previously, we might have exited with an uncertain status
* builds a more thorough, complete set of writes that might break the
  release sequence

The last point is the main intention, since we will require a complete
set for end-of-execution fixups. The others balance out to a net benefit
(and possibly a bugfix).

9 years agomodel: update pending release sequence list type
Brian Norris [Thu, 4 Oct 2012 19:15:14 +0000 (12:15 -0700)]
model: update pending release sequence list type

In working toward proper resolution of pending release sequences, I will
change the pending release sequence list again. This time, a single list
entry will have the ability to hold all important info regarding a
single release sequence. For now, I only utilize it to store the
'acquire' operation, so there should be no real change in behavior yet.

9 years agomodel: add release_seq structure definition
Brian Norris [Thu, 4 Oct 2012 18:15:39 +0000 (11:15 -0700)]
model: add release_seq structure definition

9 years agofix bug...can't mo_check_promises until we're done resolving promises for a write...
Brian Demsky [Thu, 4 Oct 2012 08:32:45 +0000 (01:32 -0700)]
fix bug...can't mo_check_promises until we're done resolving promises for a write back in time

9 years agolocal commit... bug that prunes too many executions
Brian Demsky [Thu, 4 Oct 2012 08:21:11 +0000 (01:21 -0700)]
local commit...  bug that prunes too many executions

9 years agoMerge branch 'master' of /home/git/model-checker
Brian Demsky [Thu, 4 Oct 2012 00:28:26 +0000 (17:28 -0700)]
Merge branch 'master' of /home/git/model-checker

9 years agofix low hanging fruit when profiling...
Brian Demsky [Thu, 4 Oct 2012 00:26:43 +0000 (17:26 -0700)]
fix low hanging fruit when profiling...

dump typo was turning off optimized version of checkpointing...option 2 is by far fastest
was spending most of the time freeing an oversized hashtable

9 years agofixup more id vs. thread_id_t
Brian Norris [Thu, 4 Oct 2012 00:12:59 +0000 (17:12 -0700)]
fixup more id vs. thread_id_t

9 years agoaction: return synchronization status for ModelAction::read_from()
Brian Norris [Tue, 25 Sep 2012 23:29:14 +0000 (16:29 -0700)]
action: return synchronization status for ModelAction::read_from()

The ModelChecker may need to know if any synchronization was performed in
read_from().

Note that the return status is not used yet.

9 years agoaction: remove clockvector flag from print() method
Brian Norris [Wed, 3 Oct 2012 23:29:59 +0000 (16:29 -0700)]
action: remove clockvector flag from print() method

We don't actually need to tell ModelAction::print() when to print the
associated clock vector. The introduction of the 'print_cv' boolean flag
was to fix a separate bug that has been fixed. Now the clock vector can
be printed unconditionally, when it exists.

9 years agomodel: rename release_seq_head() -> release_seq_heads()
Brian Norris [Wed, 3 Oct 2012 23:07:54 +0000 (16:07 -0700)]
model: rename release_seq_head() -> release_seq_heads()

It may return multiple heads, so make it plural.

9 years agomodel: do not assume THREAD_FINISH is always the last action
Brian Norris [Wed, 3 Oct 2012 22:36:26 +0000 (15:36 -0700)]
model: do not assume THREAD_FINISH is always the last action

It's possible that there will be special fixup ModelActions added, so
just use the Thread::is_complete() method to check for a completed
Thread.

9 years agofixup usage of int vs. thread_id_t
Brian Norris [Wed, 3 Oct 2012 22:26:52 +0000 (15:26 -0700)]
fixup usage of int vs. thread_id_t

9 years agomodel: add const qualifier to get_thread()
Brian Norris [Wed, 3 Oct 2012 22:08:28 +0000 (15:08 -0700)]
model: add const qualifier to get_thread()

9 years agomodel: rearrange conditionals, fixup take_step()
Brian Norris [Wed, 3 Oct 2012 21:50:30 +0000 (14:50 -0700)]
model: rearrange conditionals, fixup take_step()

9 years agoMerge remote-tracking branch 'origin/master'
Brian Norris [Wed, 3 Oct 2012 20:54:22 +0000 (13:54 -0700)]
Merge remote-tracking branch 'origin/master'

9 years agomodeltypes: move small typedefs to own header
Brian Norris [Wed, 3 Oct 2012 20:17:47 +0000 (13:17 -0700)]
modeltypes: move small typedefs to own header

To prevent some unnecessary inter-header dependencies, we can move some
simple typedefs to a modeltypes.h header.

9 years agomodel: don't include schedule.h
Brian Norris [Wed, 3 Oct 2012 20:16:49 +0000 (13:16 -0700)]
model: don't include schedule.h

9 years agonodestack: move has_priority() out of header
Brian Norris [Wed, 3 Oct 2012 20:50:51 +0000 (13:50 -0700)]
nodestack: move has_priority() out of header

9 years agomodel: move get_thread() implementations out of header
Brian Norris [Wed, 3 Oct 2012 20:37:02 +0000 (13:37 -0700)]
model: move get_thread() implementations out of header

9 years agomodel: move get_current_thread() implementation out of header
Brian Norris [Wed, 3 Oct 2012 20:16:00 +0000 (13:16 -0700)]
model: move get_current_thread() implementation out of header

9 years agoMerge branch 'master' of /home/git/model-checker
Brian Demsky [Wed, 3 Oct 2012 19:38:27 +0000 (12:38 -0700)]
Merge branch 'master' of /home/git/model-checker

9 years agoa number of fixes to add missing mo_graph edges to speed up detection of infeasible
Brian Demsky [Wed, 3 Oct 2012 19:37:53 +0000 (12:37 -0700)]
a number of fixes to add missing mo_graph edges to speed up detection of infeasible
traces

9 years agomodel: update switch_to_master() comment
Brian Norris [Wed, 3 Oct 2012 19:37:22 +0000 (12:37 -0700)]
model: update switch_to_master() comment

9 years agoMakefile: eliminate malloc.c warning
Brian Norris [Wed, 3 Oct 2012 19:13:03 +0000 (12:13 -0700)]
Makefile: eliminate malloc.c warning

malloc.c: In function ‘sys_trim’:
malloc.c:4289:20: warning: unused variable ‘newsize’ [-Wunused-variable]
malloc.c: In function ‘destroy_mspace’:
malloc.c:5452:13: warning: unused variable ‘base’ [-Wunused-variable]

9 years agomymemory: fix indentation for ModelAlloc
Brian Norris [Wed, 3 Oct 2012 19:06:20 +0000 (12:06 -0700)]
mymemory: fix indentation for ModelAlloc

9 years agorename 'MyAlloc' to 'ModelAlloc'
Brian Norris [Wed, 3 Oct 2012 18:50:35 +0000 (11:50 -0700)]
rename 'MyAlloc' to 'ModelAlloc'

9 years agomymemory: reword comments
Brian Norris [Wed, 3 Oct 2012 18:37:26 +0000 (11:37 -0700)]
mymemory: reword comments

9 years agosnapshot: rename 'SnapShot' -> 'Snapshot'
Brian Norris [Wed, 3 Oct 2012 18:29:01 +0000 (11:29 -0700)]
snapshot: rename 'SnapShot' -> 'Snapshot'

This capitalization always messes me up

9 years agocommon: remove excess semicolon
Brian Norris [Wed, 3 Oct 2012 18:26:17 +0000 (11:26 -0700)]
common: remove excess semicolon

9 years agomymemory: define SNAPSHOTALLOC appropriately
Brian Norris [Wed, 3 Oct 2012 18:15:05 +0000 (11:15 -0700)]
mymemory: define SNAPSHOTALLOC appropriately

SNAPSHOTALLOC can be filled in with meaningful allocators, rather than
using the global default allocators.

9 years agoreplace malloc/calloc/free with snapshot_{malloc/calloc/free}
Brian Norris [Wed, 3 Oct 2012 18:08:36 +0000 (11:08 -0700)]
replace malloc/calloc/free with snapshot_{malloc/calloc/free}

We need to explicitly declare when we are requesting snapshotting
memory, and we need to avoid using malloc, etc., directly. For now, this
has no functional change, as the 'snapshot_*' functions just call the
stdlib functions, but soon we may switch allocators to use a private
heap.

9 years agomymemory: make snapshot_{malloc,calloc,free} externally linkable
Brian Norris [Wed, 3 Oct 2012 18:05:36 +0000 (11:05 -0700)]
mymemory: make snapshot_{malloc,calloc,free} externally linkable

As we begin to use these functions, they can't be simply declared
statically in the header; they need to be linkable in hashtable.h, for
instance.

9 years agoaction: reword comments
Brian Norris [Wed, 3 Oct 2012 17:12:56 +0000 (10:12 -0700)]
action: reword comments

Why all the ...?

9 years agoextra file committed accidentally
Brian Demsky [Wed, 3 Oct 2012 10:04:21 +0000 (03:04 -0700)]
extra file committed accidentally

9 years agomissing change
Brian Demsky [Wed, 3 Oct 2012 10:03:02 +0000 (03:03 -0700)]
missing change

9 years agomspace_malloc will call into mmap if it runs out of memory... this does not play...
Brian Demsky [Wed, 3 Oct 2012 09:57:32 +0000 (02:57 -0700)]
mspace_malloc will call into mmap if it runs out of memory...  this does not play well with
snapshotting the mspace of course...

turn off the mmap option and give us a bigger heap...
add assertions to malloc/calloc/realloc if they return NULL (which is now possible with MMAP turned off)

9 years agoerror
Brian Demsky [Wed, 3 Oct 2012 08:28:12 +0000 (01:28 -0700)]
error

9 years agorandom memory leak fixes and memory access fixes
Brian Demsky [Wed, 3 Oct 2012 08:20:48 +0000 (01:20 -0700)]
random memory leak fixes and memory access fixes

9 years agomodel: debug print - pending release sequences
Brian Norris [Tue, 2 Oct 2012 01:15:12 +0000 (18:15 -0700)]
model: debug print - pending release sequences

9 years agotest: add a "pending release sequences" test
Brian Norris [Wed, 3 Oct 2012 01:52:43 +0000 (18:52 -0700)]
test: add a "pending release sequences" test

This helps test the end-of-execution "pending release sequence"
functionality, as well as other release-sequence-related code. It also
uncovered the regression that was just reverted prior to this.

9 years ago(bug) revert JOIN/LOCK simplification
Brian Norris [Wed, 3 Oct 2012 01:48:05 +0000 (18:48 -0700)]
(bug) revert JOIN/LOCK simplification

A test case throws an assertion when these changes are included. Maybe
I'll make a proper fix later, but for now, I mostly revert these.

Revert "model: remove obsolete ModelChecker::do_complete_join()"
This reverts commit cef10a2b49af5da16ffe59c5b9ddd210c668fbac.

Revert "model: unify JOIN- and LOCK-related sleep/wake code"
This reverts commit 620ae95ce4fed006d18a41b6ccfd949d7e77f677.

9 years agomodel: one release sequence may help resolve another
Brian Norris [Wed, 26 Sep 2012 00:00:53 +0000 (17:00 -0700)]
model: one release sequence may help resolve another

9 years agomodel: THREAD_FINISH triggers release sequence check
Brian Norris [Wed, 3 Oct 2012 01:09:40 +0000 (18:09 -0700)]
model: THREAD_FINISH triggers release sequence check

A THREAD_FINISH action may ensure that a Thread is no longer able to
break release sequences, so all pending release sequences should be
checked.

9 years agoMerge branch 'master' of ssh://demsky.eecs.uci.edu/home/git/model-checker
Brian Demsky [Wed, 3 Oct 2012 01:07:02 +0000 (18:07 -0700)]
Merge branch 'master' of ssh://demsky.eecs.uci.edu/home/git/model-checker

9 years agoa bug fix
Brian Demsky [Wed, 3 Oct 2012 01:06:46 +0000 (18:06 -0700)]
a bug fix

9 years agoassign sequence numbers after initial processing
Brian Norris [Wed, 3 Oct 2012 00:54:26 +0000 (17:54 -0700)]
assign sequence numbers after initial processing

When re-ordering the execution of JOIN and LOCK operations (e.g., when
they attempt to execute when not enabled), the sequence numbers became
out of order. Also, RMW operations would cause sequence numbers to jump
by 2 every time.

This fix arranges initialization such that a ModelAction is only
assigned a sequence number after it passes some initial checks to ensure
that it will be executed and utilized immediately. Otherwise, it will
either be discarded or held pending until it is enabled.

9 years agoaction: edit some spacing
Brian Norris [Wed, 3 Oct 2012 00:58:01 +0000 (17:58 -0700)]
action: edit some spacing

9 years agomodel: remove obsolete ModelChecker::do_complete_join()
Brian Norris [Wed, 3 Oct 2012 00:29:56 +0000 (17:29 -0700)]
model: remove obsolete ModelChecker::do_complete_join()

This function was folded into the one place it is used, now.

9 years agomodel: unify JOIN- and LOCK-related sleep/wake code
Brian Norris [Wed, 3 Oct 2012 00:28:02 +0000 (17:28 -0700)]
model: unify JOIN- and LOCK-related sleep/wake code

We might as well use similar code paths for JOIN and LOCK operations
that must wait on another thread to re-enable it. The side benefit here
is that the JOIN action is now placed at the correct sequence point in
the execution trace.

9 years agomodel: refactor mutex thread-blocking code
Brian Norris [Wed, 3 Oct 2012 00:14:46 +0000 (17:14 -0700)]
model: refactor mutex thread-blocking code

There are a few functions that are used in suboptimal ways.

* use the ModelChecker::get_thread(ModelAction *) version of overloaded
  'get_thread()' function

* the add/remove interfaces were used inconsistently previously; for
  "waking" we directly utilized Scheduler::add_thread, whereas the
  "sleeping" case used ModelChecker::remove_thread

* use the Scheduler::sleep and Scheduler::wake functions for sleep/wake
  instead of explicitly adding/removing

9 years agoaction: don't print clock vector when it is invalid
Brian Norris [Tue, 2 Oct 2012 19:33:21 +0000 (12:33 -0700)]
action: don't print clock vector when it is invalid

Due to clock vector snapshotting, a ModelAction may hold a pointer to
an inavlid ClockVector. This fix allows callers of ModelAction::print()
to prevent it from printing a corrupted ClockVector.

9 years agosmall hack to optimize our common case for snapshotting and set config option to...
Brian Demsky [Tue, 2 Oct 2012 21:54:59 +0000 (14:54 -0700)]
small hack to optimize our common case for snapshotting and set config option to turn this back on.

hack assumes that same pages will be dirty across different executions so just copies them and doesn't reprotect them

9 years agofix bug.... not quite perfect for linux locks, but runs to completion...
Brian Demsky [Tue, 2 Oct 2012 21:29:10 +0000 (14:29 -0700)]
fix bug....  not quite perfect for linux locks, but runs to completion...

Revert "model: revert broken bugfix"

This reverts commit ae7fcd2e5e499f72d9d1530bdc293f4fbc5f0644.

9 years agoclockvector: snapshot the whole object
Brian Norris [Tue, 2 Oct 2012 19:17:16 +0000 (12:17 -0700)]
clockvector: snapshot the whole object

9 years agomodel: revert broken bugfix
Brian Norris [Tue, 2 Oct 2012 18:16:12 +0000 (11:16 -0700)]
model: revert broken bugfix

This reverts parts of the following commit:

 commit 7ba211ec7d1cacbaa3ef2027f1a0f534888f1708

The bugfix broke our basic test case (userprog)