Add comment about the difference between ModelAction::is_write and FuncInst::is_write

diff --git a/funcinst.cc b/funcinst.cc
index a3a2874ec7ce2c0044956803b03caefacf23ba62..7f031d17d9060251992e7fd13c423e1abe6a9460 100644 (file)
--- a/funcinst.cc
+++ b/funcinst.cc
@@ -59,11 +59,14 @@ FuncInst * FuncInst::search_in_collision(ModelAction *act)
 }
 */
 
+/* Note: is_read() is equivalent to ModelAction::is_read() */
 bool FuncInst::is_read() const
 {
        return type == ATOMIC_READ || type == ATOMIC_RMWR || type == ATOMIC_RMWRCAS || type == ATOMIC_RMW;
 }
 
+/* Note: because of action type conversion in ModelExecution
+ * is_write() <==> pure writes (excluding rmw) */
 bool FuncInst::is_write() const
 {
        return type == ATOMIC_WRITE || type == ATOMIC_RMW || type == ATOMIC_INIT || type == ATOMIC_UNINIT || type == NONATOMIC_WRITE;

diff --git a/funcinst.h b/funcinst.h
index 95d92ff3e9580921dafd10e324b5d79b51f77d0c..6bbed2c88ca452c8af13ec31e72eb156f5c50e60 100644 (file)
--- a/funcinst.h
+++ b/funcinst.h
@@ -48,7 +48,11 @@ private:
         * location only stores the memory location when this FuncInst was constructed.
         */
        void * location;
+
+       /* NOTE: for rmw actions, func_inst and act may have different
+        * action types because of action type conversion in ModelExecution */
        action_type type;
+
        memory_order order;
        FuncNode * func_node;
 
@@ -66,4 +70,3 @@ private:
 };
 
 #endif /* __FUNCINST_H__ */
-