nodestack: re-insert falsely-declared "dead code"
authorBrian Norris <banorris@uci.edu>
Tue, 17 Jul 2012 05:44:40 +0000 (22:44 -0700)
committerBrian Norris <banorris@uci.edu>
Tue, 17 Jul 2012 05:48:31 +0000 (22:48 -0700)
commitd86cea5b9a14c8aac805c79422d387ddc8a064b6
tree1a56c079845a1d4af897292b824ce5d653837218
parent96db0d957f1b7ae8fa882dd282b0ede7badb26b7
nodestack: re-insert falsely-declared "dead code"

"remove dead code...  loop entrance condition is i<backtrack.size().  Therefore,
this branch can never be taken."

False.

While the entrance condition prevents 'i == backtrack.size()', the loop may
exit with 'i == backtrack.size()', since i++ is executed after the last
iteration. Since we do not expect or want this condition to occur, though, I
transform this to a documented ASSERT().
nodestack.cc