X-Git-Url: http://plrg.eecs.uci.edu/git/?p=c11tester.git;a=blobdiff_plain;f=clockvector.cc;h=162a7c2550db61c3845885349a01b76e6fd84838;hp=f411f50d64bcb9ca6c1b7eefe48f871bcc1c1bff;hb=2db2ef3b8bdabacc7784fd5a4e7e7520f1cd2298;hpb=c400af2b7dfb87ce64c86f2d2b6a37d02421b263

diff --git a/clockvector.cc b/clockvector.cc
index f411f50d..162a7c25 100644
--- a/clockvector.cc
+++ b/clockvector.cc
@@ -7,33 +7,47 @@
 #include "clockvector.h"
 #include "common.h"
 
+/**
+ * Constructs a new ClockVector, given a parent ClockVector and a first
+ * ModelAction. This constructor can assign appropriate default settings if no
+ * parent and/or action is supplied.
+ * @param parent is the previous ClockVector to inherit (i.e., clock from the
+ * same thread or the parent that created this thread)
+ * @param act is an action with which to update the ClockVector
+ */
 ClockVector::ClockVector(ClockVector *parent, ModelAction *act)
 {
 	num_threads = model->get_num_threads();
-	clock = (int *)MYMALLOC(num_threads * sizeof(int));
+	clock = (modelclock_t *)MYMALLOC(num_threads * sizeof(int));
 	memset(clock, 0, num_threads * sizeof(int));
 	if (parent)
-		std::memcpy(clock, parent->clock, parent->num_threads * sizeof(int));
+		std::memcpy(clock, parent->clock, parent->num_threads * sizeof(modelclock_t));
 
 	if (act)
 		clock[id_to_int(act->get_tid())] = act->get_seq_number();
 }
 
+/** @brief Destructor */
 ClockVector::~ClockVector()
 {
 	MYFREE(clock);
 }
 
+/**
+ * Merge a clock vector into this vector, using a pairwise vector. The
+ * resulting vector length will be the maximum length of the two being merged.
+ * @param cv is the ClockVector being merged into this vector.
+ */
 void ClockVector::merge(ClockVector *cv)
 {
-	int *clk = clock;
+	modelclock_t *clk = clock;
 	bool resize = false;
 
 	ASSERT(cv != NULL);
 
 	if (cv->num_threads > num_threads) {
 		resize = true;
-		clk = (int *)MYMALLOC(cv->num_threads * sizeof(int));
+		clk = (modelclock_t *)MYMALLOC(cv->num_threads * sizeof(modelclock_t));
 	}
 
 	/* Element-wise maximum */
@@ -49,19 +63,45 @@ void ClockVector::merge(ClockVector *cv)
 	clock = clk;
 }
 
-bool ClockVector::happens_before(ModelAction *act, thread_id_t id)
+/**
+ * Check whether this vector's thread has synchronized with another action's
+ * thread. This effectively checks the happens-before relation (or actually,
+ * happens after), but it's easier to compare two ModelAction events directly,
+ * using ModelAction::happens_before.
+ *
+ * @see ModelAction::happens_before
+ *
+ * @return true if this ClockVector's thread has synchronized with act's
+ * thread, false otherwise. That is, this function returns:
+ * <BR><CODE>act <= cv[act->tid]</CODE>
+ */
+bool ClockVector::synchronized_since(const ModelAction *act) const
 {
-	int i = id_to_int(id);
+	int i = id_to_int(act->get_tid());
 
 	if (i < num_threads)
-		return act->get_seq_number() < clock[i];
+		return act->get_seq_number() <= clock[i];
 	return false;
 }
 
-void ClockVector::print()
+/**
+ * Gets the clock corresponding to a given thread id from the clock
+ * vector. */
+
+modelclock_t ClockVector::getClock(thread_id_t thread) {
+	int threadid = id_to_int(thread);
+
+	if (threadid < num_threads)
+		return clock[threadid];
+	else
+		return 0;
+}
+
+/** @brief Formats and prints this ClockVector's data. */
+void ClockVector::print() const
 {
 	int i;
 	printf("CV: (");
 	for (i = 0; i < num_threads; i++)
-		printf("%2d%s", clock[i], (i == num_threads - 1) ? ")\n" : ", ");
+		printf("%2u%s", clock[i], (i == num_threads - 1) ? ")\n" : ", ");
 }