import IR.State;
import IR.SymbolTable;
import IR.TypeDescriptor;
+import IR.TypeExtension;
import IR.VarDescriptor;
+import IR.Flat.FlatNode;
import IR.Tree.ArrayAccessNode;
import IR.Tree.AssignmentNode;
import IR.Tree.BlockExpressionNode;
toanalyzeList.addAll(classtable.getValueSet());
Collections.sort(toanalyzeList, new Comparator<ClassDescriptor>() {
public int compare(ClassDescriptor o1, ClassDescriptor o2) {
- return o1.getClassName().compareTo(o2.getClassName());
+ return o1.getClassName().compareToIgnoreCase(o2.getClassName());
}
});
} else {
toanalyzeMethodList.addAll(methodtable.getValueSet());
Collections.sort(toanalyzeMethodList, new Comparator<MethodDescriptor>() {
public int compare(MethodDescriptor o1, MethodDescriptor o2) {
- return o1.getSymbol().compareTo(o2.getSymbol());
+ return o1.getSymbol().compareToIgnoreCase(o2.getSymbol());
}
});
} else {
while (!toAnalyzeMethodIsEmpty()) {
MethodDescriptor md = toAnalyzeMethodNext();
if (ssjava.needTobeAnnotated(md)) {
- System.out.println("SSJAVA: Checking assignments: " + md);
- checkMethodBody(cd, md);
+ if (state.SSJAVADEBUG) {
+ System.out.println("SSJAVA: Checking Flow-down Rules: " + md);
+ }
+ CompositeLocation calleePCLOC = ssjava.getPCLocation(md);
+ checkMethodBody(cd, md, calleePCLOC);
}
}
}
for (int i = 0; i < md.numParameters(); i++) {
// process annotations on method parameters
VarDescriptor vd = (VarDescriptor) md.getParameter(i);
- assignLocationOfVarDescriptor(vd, md, md.getParameterTable(), bn);
+ assignLocationOfVarDescriptor(vd, md, md.getParameterTable(), null);
paramList.add(d2loc.get(vd));
}
Vector<AnnotationDescriptor> methodAnnotations = md.getModifiers().getAnnotations();
+ CompositeLocation returnLocComp = null;
+
+ boolean hasReturnLocDeclaration = false;
+ if (methodAnnotations != null) {
+ for (int i = 0; i < methodAnnotations.size(); i++) {
+ AnnotationDescriptor an = methodAnnotations.elementAt(i);
+ if (an.getMarker().equals(ssjava.RETURNLOC)) {
+ // this case, developer explicitly defines method lattice
+ String returnLocDeclaration = an.getValue();
+ returnLocComp = parseLocationDeclaration(md, null, returnLocDeclaration);
+ hasReturnLocDeclaration = true;
+ } else if (an.getMarker().equals(ssjava.THISLOC)) {
+ String thisLoc = an.getValue();
+ ssjava.getMethodLattice(md).setThisLoc(thisLoc);
+ } else if (an.getMarker().equals(ssjava.GLOBALLOC)) {
+ String globalLoc = an.getValue();
+ ssjava.getMethodLattice(md).setGlobalLoc(globalLoc);
+ } else if (an.getMarker().equals(ssjava.PCLOC)) {
+ String pcLocDeclaration = an.getValue();
+ ssjava.setPCLocation(md, parseLocationDeclaration(md, null, pcLocDeclaration));
+ }
+ }
+ }
+
// second, check return location annotation
if (!md.getReturnType().isVoid()) {
- CompositeLocation returnLocComp = null;
-
- String rtrStr = ssjava.getMethodLattice(md).getReturnLoc();
- if (rtrStr != null) {
- returnLocComp = new CompositeLocation(new Location(md, rtrStr));
- } else {
- if (methodAnnotations != null) {
- for (int i = 0; i < methodAnnotations.size(); i++) {
- AnnotationDescriptor an = methodAnnotations.elementAt(i);
- if (an.getMarker().equals(ssjava.RETURNLOC)) {
- // this case, developer explicitly defines method lattice
- String returnLocDeclaration = an.getValue();
- returnLocComp = parseLocationDeclaration(md, null, returnLocDeclaration);
- }
- }
- } else {
- // if developer does not define method lattice
- // search return location in the method default lattice
- if (returnLocComp == null) {
- MethodLattice<String> methodDefaultLattice = ssjava.getMethodDefaultLattice(cd);
- if (methodDefaultLattice.getReturnLoc() != null) {
- returnLocComp =
- parseLocationDeclaration(md, null, methodDefaultLattice.getReturnLoc());
- }
- }
+ if (!hasReturnLocDeclaration) {
+ // if developer does not define method lattice
+ // search return location in the method default lattice
+ String rtrStr = ssjava.getMethodLattice(md).getReturnLoc();
+ if (rtrStr != null) {
+ returnLocComp = new CompositeLocation(new Location(md, rtrStr));
}
}
md2ReturnLoc.put(md, returnLocComp);
- // check this location
+ }
+
+ if (!md.getReturnType().isVoid()) {
MethodLattice<String> methodLattice = ssjava.getMethodLattice(md);
String thisLocId = methodLattice.getThisLoc();
- if (thisLocId == null) {
+ if ((!md.isStatic()) && thisLocId == null) {
throw new Error("Method '" + md + "' does not have the definition of 'this' location at "
+ md.getClassDesc().getSourceFileName());
}
CompositeLocation thisLoc = new CompositeLocation(new Location(md, thisLocId));
paramList.add(0, thisLoc);
-
- System.out.println("### ReturnLocGenerator=" + md);
- System.out.println("### md2ReturnLoc.get(md)=" + md2ReturnLoc.get(md));
- md2ReturnLocGen.put(md, new ReturnLocGenerator(md2ReturnLoc.get(md), paramList, md + " of "
- + cd.getSourceFileName()));
+ md2ReturnLocGen.put(md, new ReturnLocGenerator(md2ReturnLoc.get(md), md, paramList, md
+ + " of " + cd.getSourceFileName()));
}
// fourth, check declarations inside of method
checkDeclarationInBlockNode(md, nametable, ln.getBody());
}
- private void checkMethodBody(ClassDescriptor cd, MethodDescriptor md) {
+ private void checkMethodBody(ClassDescriptor cd, MethodDescriptor md,
+ CompositeLocation constraints) {
BlockNode bn = state.getMethodBody(md);
- checkLocationFromBlockNode(md, md.getParameterTable(), bn, null);
+ checkLocationFromBlockNode(md, md.getParameterTable(), bn, constraints);
}
private String generateErrorMessage(ClassDescriptor cd, TreeNode tn) {
checkLocationFromExpressionNode(md, nametable, returnExp, new CompositeLocation(),
constraint, false);
+ // System.out.println("# RETURN VALUE LOC=" + returnValueLoc +
+ // " with constraint=" + constraint);
+
+ // TODO: do we need to check here?
// if this return statement is inside branch, return value has an implicit
// flow from conditional location
- if (constraint != null) {
- Set<CompositeLocation> inputGLB = new HashSet<CompositeLocation>();
- inputGLB.add(returnValueLoc);
- inputGLB.add(constraint);
- returnValueLoc =
- CompositeLattice.calculateGLB(inputGLB, generateErrorMessage(md.getClassDesc(), rn));
- }
+ // if (constraint != null) {
+ // Set<CompositeLocation> inputGLB = new HashSet<CompositeLocation>();
+ // inputGLB.add(returnValueLoc);
+ // inputGLB.add(constraint);
+ // returnValueLoc =
+ // CompositeLattice.calculateGLB(inputGLB,
+ // generateErrorMessage(md.getClassDesc(), rn));
+ // }
// check if return value is equal or higher than RETRUNLOC of method
// declaration annotation
CompositeLocation condLoc =
checkLocationFromExpressionNode(md, nametable, ln.getCondition(),
new CompositeLocation(), constraint, false);
- addLocationType(ln.getCondition().getType(), (condLoc));
+ // addLocationType(ln.getCondition().getType(), (condLoc));
constraint = generateNewConstraint(constraint, condLoc);
checkLocationFromBlockNode(md, nametable, ln.getBody(), constraint);
// check 'for loop' case
BlockNode bn = ln.getInitializer();
bn.getVarTable().setParent(nametable);
+ // need to check initialization node
+ // checkLocationFromBlockNode(md, bn.getVarTable(), bn, constraint);
+ for (int i = 0; i < bn.size(); i++) {
+ BlockStatementNode bsn = bn.get(i);
+ checkLocationFromBlockStatementNode(md, bn.getVarTable(), bsn, constraint);
+ }
// calculate glb location of condition and update statements
CompositeLocation condLoc =
checkLocationFromExpressionNode(md, bn.getVarTable(), ln.getCondition(),
new CompositeLocation(), constraint, false);
- addLocationType(ln.getCondition().getType(), condLoc);
+ // addLocationType(ln.getCondition().getType(), condLoc);
constraint = generateNewConstraint(constraint, condLoc);
checkLocationFromExpressionNode(md, nametable, isn.getCondition(), new CompositeLocation(),
constraint, false);
- addLocationType(isn.getCondition().getType(), condLoc);
+ // addLocationType(isn.getCondition().getType(), condLoc);
constraint = generateNewConstraint(constraint, condLoc);
checkLocationFromBlockNode(md, nametable, isn.getTrueBlock(), constraint);
return new CompositeLocation();
}
+ private void checkOwnership(MethodDescriptor md, TreeNode tn, ExpressionNode srcExpNode) {
+
+ if (srcExpNode.kind() == Kind.NameNode || srcExpNode.kind() == Kind.FieldAccessNode) {
+ if (srcExpNode.getType().isPtr() && !srcExpNode.getType().isNull()) {
+ // first, check the linear type
+ // RHS reference should be owned by the current method
+ FieldDescriptor fd = getFieldDescriptorFromExpressionNode(srcExpNode);
+ boolean isOwned;
+ if (fd == null) {
+ // local var case
+ isOwned = ((SSJavaType) srcExpNode.getType().getExtension()).isOwned();
+ } else {
+ // field case
+ isOwned = ssjava.isOwnedByMethod(md, fd);
+ }
+ if (!isOwned) {
+ throw new Error(
+ "It is not allowed to create the reference alias from the reference not owned by the method at "
+ + generateErrorMessage(md.getClassDesc(), tn));
+ }
+
+ }
+ }
+
+ }
+
private CompositeLocation checkLocationFromDeclarationNode(MethodDescriptor md,
SymbolTable nametable, DeclarationNode dn, CompositeLocation constraint) {
CompositeLocation destLoc = d2loc.get(vd);
if (dn.getExpression() != null) {
+
+ checkOwnership(md, dn, dn.getExpression());
+
CompositeLocation expressionLoc =
checkLocationFromExpressionNode(md, nametable, dn.getExpression(),
new CompositeLocation(), constraint, false);
// addTypeLocation(dn.getExpression().getType(), expressionLoc);
if (expressionLoc != null) {
+
// checking location order
if (!CompositeLattice.isGreaterThan(expressionLoc, destLoc,
generateErrorMessage(md.getClassDesc(), dn))) {
private void checkDeclarationInSubBlockNode(MethodDescriptor md, SymbolTable nametable,
SubBlockNode sbn) {
- checkDeclarationInBlockNode(md, nametable.getParent(), sbn.getBlockNode());
+ checkDeclarationInBlockNode(md, nametable, sbn.getBlockNode());
}
private CompositeLocation checkLocationFromBlockExpressionNode(MethodDescriptor md,
SymbolTable nametable, BlockExpressionNode ben, CompositeLocation constraint) {
+
CompositeLocation compLoc =
checkLocationFromExpressionNode(md, nametable, ben.getExpression(), null, constraint, false);
// addTypeLocation(ben.getExpression().getType(), compLoc);
CompositeLocation condLoc =
checkLocationFromExpressionNode(md, nametable, tn.getCond(), new CompositeLocation(),
constraint, false);
- addLocationType(tn.getCond().getType(), condLoc);
+ // addLocationType(tn.getCond().getType(), condLoc);
CompositeLocation trueLoc =
checkLocationFromExpressionNode(md, nametable, tn.getTrueExpr(), new CompositeLocation(),
constraint, false);
- addLocationType(tn.getTrueExpr().getType(), trueLoc);
+ // addLocationType(tn.getTrueExpr().getType(), trueLoc);
CompositeLocation falseLoc =
checkLocationFromExpressionNode(md, nametable, tn.getFalseExpr(), new CompositeLocation(),
constraint, false);
- addLocationType(tn.getFalseExpr().getType(), falseLoc);
+ // addLocationType(tn.getFalseExpr().getType(), falseLoc);
// locations from true/false branches can be TOP when there are only literal
// values
// in this case, we don't need to check flow down rule!
+ // System.out.println("\n#tertiary cond=" + tn.getCond().printNode(0) +
+ // " Loc=" + condLoc);
+ // System.out.println("# true=" + tn.getTrueExpr().printNode(0) + " Loc=" +
+ // trueLoc);
+ // System.out.println("# false=" + tn.getFalseExpr().printNode(0) + " Loc="
+ // + falseLoc);
+
// check if condLoc is higher than trueLoc & falseLoc
if (!trueLoc.get(0).isTop()
&& !CompositeLattice.isGreaterThan(condLoc, trueLoc, generateErrorMessage(cd, tn))) {
&& !CompositeLattice.isGreaterThan(condLoc, falseLoc,
generateErrorMessage(cd, tn.getCond()))) {
throw new Error(
- "The location of the condition expression is lower than the true expression at "
+ "The location of the condition expression is lower than the false expression at "
+ cd.getSourceFileName() + ":" + tn.getCond().getNumLine());
}
glbInputSet.add(trueLoc);
glbInputSet.add(falseLoc);
- return CompositeLattice.calculateGLB(glbInputSet, generateErrorMessage(cd, tn));
+ if (glbInputSet.size() == 1) {
+ return trueLoc;
+ } else {
+ return CompositeLattice.calculateGLB(glbInputSet, generateErrorMessage(cd, tn));
+ }
+
}
private CompositeLocation checkLocationFromMethodInvokeNode(MethodDescriptor md,
SymbolTable nametable, MethodInvokeNode min, CompositeLocation loc,
CompositeLocation constraint) {
- CompositeLocation baseLocation = null;
- if (min.getExpression() != null) {
- baseLocation =
- checkLocationFromExpressionNode(md, nametable, min.getExpression(),
- new CompositeLocation(), constraint, false);
- } else {
+ ClassDescriptor cd = md.getClassDesc();
+ MethodDescriptor calleeMethodDesc = min.getMethod();
- if (min.getMethod().isStatic()) {
- String globalLocId = ssjava.getMethodLattice(md).getGlobalLoc();
- if (globalLocId == null) {
- throw new Error("Method lattice does not define global variable location at "
- + generateErrorMessage(md.getClassDesc(), min));
- }
- baseLocation = new CompositeLocation(new Location(md, globalLocId));
+ NameDescriptor baseName = min.getBaseName();
+ boolean isSystemout = false;
+ if (baseName != null) {
+ isSystemout = baseName.getSymbol().equals("System.out");
+ }
+
+ if (!ssjava.isSSJavaUtil(calleeMethodDesc.getClassDesc())
+ && !ssjava.isTrustMethod(calleeMethodDesc) && !calleeMethodDesc.getModifiers().isNative()
+ && !isSystemout) {
+
+ CompositeLocation baseLocation = null;
+ if (min.getExpression() != null) {
+ baseLocation =
+ checkLocationFromExpressionNode(md, nametable, min.getExpression(),
+ new CompositeLocation(), constraint, false);
} else {
- String thisLocId = ssjava.getMethodLattice(md).getThisLoc();
- baseLocation = new CompositeLocation(new Location(md, thisLocId));
+ if (min.getMethod().isStatic()) {
+ String globalLocId = ssjava.getMethodLattice(md).getGlobalLoc();
+ if (globalLocId == null) {
+ throw new Error("Method lattice does not define global variable location at "
+ + generateErrorMessage(md.getClassDesc(), min));
+ }
+ baseLocation = new CompositeLocation(new Location(md, globalLocId));
+ } else {
+ String thisLocId = ssjava.getMethodLattice(md).getThisLoc();
+ baseLocation = new CompositeLocation(new Location(md, thisLocId));
+ }
+ }
+
+ // System.out.println("\n#checkLocationFromMethodInvokeNode=" +
+ // min.printNode(0)
+ // + " baseLocation=" + baseLocation + " constraint=" + constraint);
+
+ // setup the location list of caller's arguments
+ List<CompositeLocation> callerArgList = new ArrayList<CompositeLocation>();
+
+ // setup the location list of callee's parameters
+ MethodLattice<String> calleeLattice = ssjava.getMethodLattice(calleeMethodDesc);
+ List<CompositeLocation> calleeParamList = new ArrayList<CompositeLocation>();
+
+ if (min.numArgs() > 0) {
+ if (!calleeMethodDesc.isStatic()) {
+ callerArgList.add(baseLocation);
+ }
+ for (int i = 0; i < min.numArgs(); i++) {
+ ExpressionNode en = min.getArg(i);
+ CompositeLocation callerArgLoc =
+ checkLocationFromExpressionNode(md, nametable, en, new CompositeLocation(),
+ constraint, false);
+ callerArgList.add(callerArgLoc);
+ }
+
+ if (!calleeMethodDesc.isStatic()) {
+ CompositeLocation calleeThisLoc =
+ new CompositeLocation(new Location(calleeMethodDesc, calleeLattice.getThisLoc()));
+ calleeParamList.add(calleeThisLoc);
+ }
+
+ for (int i = 0; i < calleeMethodDesc.numParameters(); i++) {
+ VarDescriptor calleevd = (VarDescriptor) calleeMethodDesc.getParameter(i);
+ CompositeLocation calleeLoc = d2loc.get(calleevd);
+ calleeParamList.add(calleeLoc);
+ }
+ }
+
+ if (constraint != null) {
+ // check whether the PC location is lower than one of the
+ // argument locations. If it is lower, the callee has to have @PCLOC
+ // annotation that declares the program counter that is higher than
+ // corresponding parameter
+
+ CompositeLocation calleePCLOC = ssjava.getPCLocation(calleeMethodDesc);
+
+ for (int idx = 0; idx < callerArgList.size(); idx++) {
+ CompositeLocation argLocation = callerArgList.get(idx);
+
+ // need to check that param is higher than PCLOC
+ if (!argLocation.get(0).isTop()
+ && CompositeLattice.compare(argLocation, constraint, true,
+ generateErrorMessage(cd, min)) == ComparisonResult.GREATER) {
+
+ CompositeLocation paramLocation = calleeParamList.get(idx);
+
+ int paramCompareResult =
+ CompositeLattice.compare(calleePCLOC, paramLocation, true,
+ generateErrorMessage(cd, min));
+
+ if (paramCompareResult == ComparisonResult.GREATER) {
+ throw new Error(
+ "The program counter location "
+ + constraint
+ + " is lower than the argument(idx="
+ + idx
+ + ") location "
+ + argLocation
+ + ". Need to specify that the initial PC location of the callee, which is currently set to "
+ + calleePCLOC + ", is lower than " + paramLocation + " in the method "
+ + calleeMethodDesc.getSymbol() + ":" + min.getNumLine());
+ }
+
+ }
+
+ }
+
+ }
+
+ checkCalleeConstraints(md, nametable, min, baseLocation, constraint);
+
+ // checkCallerArgumentLocationConstraints(md, nametable, min,
+ // baseLocation, constraint);
+
+ if (!min.getMethod().getReturnType().isVoid()) {
+ // If method has a return value, compute the highest possible return
+ // location in the caller's perspective
+ CompositeLocation ceilingLoc =
+ computeCeilingLocationForCaller(md, nametable, min, baseLocation, constraint);
+ return ceilingLoc;
}
}
- checkCalleeConstraints(md, nametable, min, baseLocation, constraint);
+ return new CompositeLocation(Location.createTopLocation(md));
+
+ }
+
+ private CompositeLocation translateCallerLocToCalleeLoc(MethodDescriptor calleeMD,
+ CompositeLocation calleeBaseLoc, CompositeLocation constraint) {
- if (!min.getMethod().getReturnType().isVoid()) {
- // If method has a return value, compute the highest possible return
- // location in the caller's perspective
- CompositeLocation ceilingLoc =
- computeCeilingLocationForCaller(md, nametable, min, baseLocation, constraint);
- return ceilingLoc;
+ CompositeLocation calleeConstraint = new CompositeLocation();
+
+ // if (constraint.startsWith(calleeBaseLoc)) {
+ // if the first part of constraint loc is matched with callee base loc
+ Location thisLoc = new Location(calleeMD, ssjava.getMethodLattice(calleeMD).getThisLoc());
+ calleeConstraint.addLocation(thisLoc);
+ for (int i = calleeBaseLoc.getSize(); i < constraint.getSize(); i++) {
+ calleeConstraint.addLocation(constraint.get(i));
}
- return new CompositeLocation();
+ // }
+ return calleeConstraint;
+ }
+
+ private void checkCallerArgumentLocationConstraints(MethodDescriptor md, SymbolTable nametable,
+ MethodInvokeNode min, CompositeLocation callerBaseLoc, CompositeLocation constraint) {
+ // if parameter location consists of THIS and FIELD location,
+ // caller should pass an argument that is comparable to the declared
+ // parameter location
+ // and is not lower than the declared parameter location in the field
+ // lattice.
+
+ MethodDescriptor calleemd = min.getMethod();
+
+ List<CompositeLocation> callerArgList = new ArrayList<CompositeLocation>();
+ List<CompositeLocation> calleeParamList = new ArrayList<CompositeLocation>();
+
+ MethodLattice<String> calleeLattice = ssjava.getMethodLattice(calleemd);
+ Location calleeThisLoc = new Location(calleemd, calleeLattice.getThisLoc());
+
+ for (int i = 0; i < min.numArgs(); i++) {
+ ExpressionNode en = min.getArg(i);
+ CompositeLocation callerArgLoc =
+ checkLocationFromExpressionNode(md, nametable, en, new CompositeLocation(), constraint,
+ false);
+ callerArgList.add(callerArgLoc);
+ }
+
+ // setup callee params set
+ for (int i = 0; i < calleemd.numParameters(); i++) {
+ VarDescriptor calleevd = (VarDescriptor) calleemd.getParameter(i);
+ CompositeLocation calleeLoc = d2loc.get(calleevd);
+ calleeParamList.add(calleeLoc);
+ }
+
+ String errorMsg = generateErrorMessage(md.getClassDesc(), min);
+
+ // System.out.println("checkCallerArgumentLocationConstraints=" +
+ // min.printNode(0));
+ // System.out.println("base location=" + callerBaseLoc + " constraint=" +
+ // constraint);
+
+ for (int i = 0; i < calleeParamList.size(); i++) {
+ CompositeLocation calleeParamLoc = calleeParamList.get(i);
+ if (calleeParamLoc.get(0).equals(calleeThisLoc) && calleeParamLoc.getSize() > 1) {
+
+ // callee parameter location has field information
+ CompositeLocation callerArgLoc = callerArgList.get(i);
+
+ CompositeLocation paramLocation =
+ translateCalleeParamLocToCaller(md, calleeParamLoc, callerBaseLoc, errorMsg);
+
+ Set<CompositeLocation> inputGLBSet = new HashSet<CompositeLocation>();
+ if (constraint != null) {
+ inputGLBSet.add(callerArgLoc);
+ inputGLBSet.add(constraint);
+ callerArgLoc =
+ CompositeLattice.calculateGLB(inputGLBSet,
+ generateErrorMessage(md.getClassDesc(), min));
+ }
+
+ if (!CompositeLattice.isGreaterThan(callerArgLoc, paramLocation, errorMsg)) {
+ throw new Error("Caller argument '" + min.getArg(i).printNode(0) + " : " + callerArgLoc
+ + "' should be higher than corresponding callee's parameter : " + paramLocation
+ + " at " + errorMsg);
+ }
+
+ }
+ }
+
+ }
+
+ private CompositeLocation translateCalleeParamLocToCaller(MethodDescriptor md,
+ CompositeLocation calleeParamLoc, CompositeLocation callerBaseLocation, String errorMsg) {
+
+ CompositeLocation translate = new CompositeLocation();
+
+ for (int i = 0; i < callerBaseLocation.getSize(); i++) {
+ translate.addLocation(callerBaseLocation.get(i));
+ }
+
+ for (int i = 1; i < calleeParamLoc.getSize(); i++) {
+ translate.addLocation(calleeParamLoc.get(i));
+ }
+
+ // System.out.println("TRANSLATED=" + translate + " from calleeParamLoc=" +
+ // calleeParamLoc);
+
+ return translate;
}
private CompositeLocation computeCeilingLocationForCaller(MethodDescriptor md,
argList.add(callerArg);
}
- System.out.println("\n## computeReturnLocation=" + min.getMethod() + " argList=" + argList);
- CompositeLocation compLoc = md2ReturnLocGen.get(min.getMethod()).computeReturnLocation(argList);
- DeltaLocation delta = new DeltaLocation(compLoc, 1);
- System.out.println("##computeReturnLocation=" + delta);
+ // System.out.println("\n## computeReturnLocation=" + min.getMethod() +
+ // " argList=" + argList);
+ CompositeLocation ceilLoc = md2ReturnLocGen.get(min.getMethod()).computeReturnLocation(argList);
+ // System.out.println("## ReturnLocation=" + ceilLoc);
- return delta;
+ return ceilLoc;
}
private void checkCalleeConstraints(MethodDescriptor md, SymbolTable nametable,
MethodInvokeNode min, CompositeLocation callerBaseLoc, CompositeLocation constraint) {
+ // System.out.println("checkCalleeConstraints=" + min.printNode(0));
+
MethodDescriptor calleemd = min.getMethod();
MethodLattice<String> calleeLattice = ssjava.getMethodLattice(calleemd);
for (int i = 0; i < calleemd.numParameters(); i++) {
VarDescriptor calleevd = (VarDescriptor) calleemd.getParameter(i);
CompositeLocation calleeLoc = d2loc.get(calleevd);
+ // System.out.println("calleevd=" + calleevd + " loc=" + calleeLoc);
calleeParamList.add(calleeLoc);
}
continue CHECK;
}
+ // System.out.println("calleeLoc1=" + calleeLoc1);
+ // System.out.println("calleeLoc2=" + calleeLoc2 +
+ // "calleeParamList=" + calleeParamList);
+
int callerResult =
CompositeLattice.compare(callerLoc1, callerLoc2, true,
generateErrorMessage(md.getClassDesc(), min));
+ // System.out.println("callerResult=" + callerResult);
int calleeResult =
CompositeLattice.compare(calleeLoc1, calleeLoc2, true,
generateErrorMessage(md.getClassDesc(), min));
+ // System.out.println("calleeResult=" + calleeResult);
+
+ if (callerResult == ComparisonResult.EQUAL) {
+ if (ssjava.isSharedLocation(callerLoc1.get(callerLoc1.getSize() - 1))
+ && ssjava.isSharedLocation(callerLoc2.get(callerLoc2.getSize() - 1))) {
+ // if both of them are shared locations, promote them to
+ // "GREATER relation"
+ callerResult = ComparisonResult.GREATER;
+ }
+ }
if (calleeResult == ComparisonResult.GREATER
&& callerResult != ComparisonResult.GREATER) {
CompositeLocation arrayLoc =
checkLocationFromExpressionNode(md, nametable, aan.getExpression(),
new CompositeLocation(), constraint, isLHS);
+
// addTypeLocation(aan.getExpression().getType(), arrayLoc);
CompositeLocation indexLoc =
checkLocationFromExpressionNode(md, nametable, aan.getIndex(), new CompositeLocation(),
// addTypeLocation(on.getRight().getType(), rightLoc);
}
- System.out.println("\n# OP NODE=" + on.printNode(0));
- System.out.println("# left loc=" + leftLoc + " from " + on.getLeft().getClass());
- if (on.getRight() != null) {
- System.out.println("# right loc=" + rightLoc + " from " + on.getRight().getClass());
- }
+ // System.out.println("\n# OP NODE=" + on.printNode(0));
+ // System.out.println("# left loc=" + leftLoc + " from " +
+ // on.getLeft().getClass());
+ // if (on.getRight() != null) {
+ // System.out.println("# right loc=" + rightLoc + " from " +
+ // on.getRight().getClass());
+ // }
Operation op = on.getOp();
inputSet.add(rightLoc);
CompositeLocation glbCompLoc =
CompositeLattice.calculateGLB(inputSet, generateErrorMessage(cd, on));
- System.out.println("# glbCompLoc=" + glbCompLoc);
return glbCompLoc;
default:
VarDescriptor vd = (VarDescriptor) d;
// localLoc = d2loc.get(vd);
// the type of var descriptor has a composite location!
- loc = ((CompositeLocation) vd.getType().getExtension()).clone();
+ loc = ((SSJavaType) vd.getType().getExtension()).getCompLoc().clone();
} else if (d instanceof FieldDescriptor) {
// the type of field descriptor has a location!
FieldDescriptor fd = (FieldDescriptor) d;
loc.addLocation(fieldLoc);
} else if (d == null) {
// access static field
- ClassDescriptor cd = nn.getClassDesc();
+ FieldDescriptor fd = nn.getField();
MethodLattice<String> localLattice = ssjava.getMethodLattice(md);
String globalLocId = localLattice.getGlobalLoc();
+ generateErrorMessage(md.getClassDesc(), nn));
}
loc.addLocation(new Location(md, globalLocId));
+
+ Location fieldLoc = (Location) fd.getType().getExtension();
+ loc.addLocation(fieldLoc);
+
return loc;
}
}
}
+ if (left instanceof ArrayAccessNode) {
+ ArrayAccessNode aan = (ArrayAccessNode) left;
+ left = aan.getExpression();
+ }
+
loc = checkLocationFromExpressionNode(md, nametable, left, loc, constraint, false);
+ // System.out.println("### checkLocationFromFieldAccessNode=" +
+ // fan.printNode(0));
+ // System.out.println("### left=" + left.printNode(0));
+
if (!left.getType().isPrimitive()) {
+
+ if (fd.getSymbol().equals("length")) {
+ // array.length access, return the location of the array
+ return loc;
+ }
+
Location fieldLoc = getFieldLocation(fd);
loc.addLocation(fieldLoc);
}
-
return loc;
}
private Location getFieldLocation(FieldDescriptor fd) {
+ // System.out.println("### getFieldLocation=" + fd);
+ // System.out.println("### fd.getType().getExtension()=" +
+ // fd.getType().getExtension());
+
Location fieldLoc = (Location) fd.getType().getExtension();
// handle the case that method annotation checking skips checking field
}
+ private FieldDescriptor getFieldDescriptorFromExpressionNode(ExpressionNode en) {
+
+ if (en.kind() == Kind.NameNode) {
+ NameNode nn = (NameNode) en;
+ if (nn.getField() != null) {
+ return nn.getField();
+ }
+
+ if (nn.getName() != null && nn.getName().getBase() != null) {
+ return getFieldDescriptorFromExpressionNode(nn.getExpression());
+ }
+
+ } else if (en.kind() == Kind.FieldAccessNode) {
+ FieldAccessNode fan = (FieldAccessNode) en;
+ return fan.getField();
+ }
+
+ return null;
+ }
+
private CompositeLocation checkLocationFromAssignmentNode(MethodDescriptor md,
SymbolTable nametable, AssignmentNode an, CompositeLocation loc, CompositeLocation constraint) {
- System.out.println("\n# ASSIGNMENTNODE=" + an.printNode(0));
+ // System.out.println("\n# ASSIGNMENTNODE=" + an.printNode(0));
ClassDescriptor cd = md.getClassDesc();
CompositeLocation srcLocation;
if (!postinc) {
+
+ checkOwnership(md, an, an.getSrc());
+
rhsLocation =
checkLocationFromExpressionNode(md, nametable, an.getSrc(), new CompositeLocation(),
constraint, false);
- System.out.println("dstLocation=" + destLocation);
- System.out.println("rhsLocation=" + rhsLocation);
- System.out.println("constraint=" + constraint);
-
srcLocation = rhsLocation;
- if (!rhsLocation.get(rhsLocation.getSize() - 1).isTop()) {
- if (constraint != null) {
- inputGLBSet.add(rhsLocation);
- inputGLBSet.add(constraint);
- srcLocation = CompositeLattice.calculateGLB(inputGLBSet, generateErrorMessage(cd, an));
- }
+ // if (!rhsLocation.get(rhsLocation.getSize() - 1).isTop()) {
+ if (constraint != null) {
+ inputGLBSet.add(rhsLocation);
+ inputGLBSet.add(constraint);
+ srcLocation = CompositeLattice.calculateGLB(inputGLBSet, generateErrorMessage(cd, an));
}
+ // }
+
+ // System.out.println("dstLocation=" + destLocation);
+ // System.out.println("rhsLocation=" + rhsLocation);
+ // System.out.println("srcLocation=" + srcLocation);
+ // System.out.println("constraint=" + constraint);
if (!CompositeLattice.isGreaterThan(srcLocation, destLocation, generateErrorMessage(cd, an))) {
+
+ String context = "";
+ if (constraint != null) {
+ context = " and the current context constraint is " + constraint;
+ }
+
throw new Error("The value flow from " + srcLocation + " to " + destLocation
- + " does not respect location hierarchy on the assignment " + an.printNode(0) + " at "
- + cd.getSourceFileName() + "::" + an.getNumLine());
+ + " does not respect location hierarchy on the assignment " + an.printNode(0) + context
+ + " at " + cd.getSourceFileName() + "::" + an.getNumLine());
+ }
+
+ if (srcLocation.equals(destLocation)) {
+ // keep it for definitely written analysis
+ Set<FlatNode> flatNodeSet = ssjava.getBuildFlat().getFlatNodeSet(an);
+ for (Iterator iterator = flatNodeSet.iterator(); iterator.hasNext();) {
+ FlatNode fn = (FlatNode) iterator.next();
+ ssjava.addSameHeightWriteFlatNode(fn);
+ }
+
}
} else {
srcLocation = rhsLocation;
}
- System.out.println("srcLocation=" + srcLocation);
- System.out.println("rhsLocation=" + rhsLocation);
- System.out.println("constraint=" + constraint);
+ // System.out.println("srcLocation=" + srcLocation);
+ // System.out.println("rhsLocation=" + rhsLocation);
+ // System.out.println("constraint=" + constraint);
if (!CompositeLattice.isGreaterThan(srcLocation, destLocation, generateErrorMessage(cd, an))) {
- throw new Error("Location " + destLocation
- + " is not allowed to have the value flow that moves within the same location at "
- + cd.getSourceFileName() + "::" + an.getNumLine());
+
+ if (srcLocation.equals(destLocation)) {
+ throw new Error("Location " + srcLocation
+ + " is not allowed to have the value flow that moves within the same location at '"
+ + an.printNode(0) + "' of " + cd.getSourceFileName() + "::" + an.getNumLine());
+ } else {
+ throw new Error("The value flow from " + srcLocation + " to " + destLocation
+ + " does not respect location hierarchy on the assignment " + an.printNode(0)
+ + " at " + cd.getSourceFileName() + "::" + an.getNumLine());
+ }
+
+ }
+
+ if (srcLocation.equals(destLocation)) {
+ // keep it for definitely written analysis
+ Set<FlatNode> flatNodeSet = ssjava.getBuildFlat().getFlatNodeSet(an);
+ for (Iterator iterator = flatNodeSet.iterator(); iterator.hasNext();) {
+ FlatNode fn = (FlatNode) iterator.next();
+ ssjava.addSameHeightWriteFlatNode(fn);
+ }
}
}
// currently enforce every variable to have corresponding location
if (annotationVec.size() == 0) {
- throw new Error("Location is not assigned to variable " + vd.getSymbol() + " in the method "
- + md.getSymbol() + " of the class " + cd.getSymbol());
+ throw new Error("Location is not assigned to variable '" + vd.getSymbol()
+ + "' in the method '" + md + "' of the class " + cd.getSymbol() + " at "
+ + generateErrorMessage(cd, n));
}
- if (annotationVec.size() > 1) { // variable can have at most one location
- throw new Error(vd.getSymbol() + " has more than one location.");
- }
+ int locDecCount = 0;
+ for (int i = 0; i < annotationVec.size(); i++) {
+ AnnotationDescriptor ad = annotationVec.elementAt(i);
- AnnotationDescriptor ad = annotationVec.elementAt(0);
+ if (ad.getType() == AnnotationDescriptor.SINGLE_ANNOTATION) {
- if (ad.getType() == AnnotationDescriptor.SINGLE_ANNOTATION) {
+ if (ad.getMarker().equals(SSJavaAnalysis.LOC)) {
+ locDecCount++;
+ if (locDecCount > 1) {// variable can have at most one location
+ throw new Error(vd.getSymbol() + " has more than one location declaration.");
+ }
+ String locDec = ad.getValue(); // check if location is defined
- if (ad.getMarker().equals(SSJavaAnalysis.LOC)) {
- String locDec = ad.getValue(); // check if location is defined
+ if (locDec.startsWith(SSJavaAnalysis.DELTA)) {
+ DeltaLocation deltaLoc = parseDeltaDeclaration(md, n, locDec);
+ d2loc.put(vd, deltaLoc);
+ addLocationType(vd.getType(), deltaLoc);
+ } else {
+ CompositeLocation compLoc = parseLocationDeclaration(md, n, locDec);
- if (locDec.startsWith(SSJavaAnalysis.DELTA)) {
- DeltaLocation deltaLoc = parseDeltaDeclaration(md, n, locDec);
- d2loc.put(vd, deltaLoc);
- addLocationType(vd.getType(), deltaLoc);
- } else {
- CompositeLocation compLoc = parseLocationDeclaration(md, n, locDec);
+ Location lastElement = compLoc.get(compLoc.getSize() - 1);
+ if (ssjava.isSharedLocation(lastElement)) {
+ ssjava.mapSharedLocation2Descriptor(lastElement, vd);
+ }
- Location lastElement = compLoc.get(compLoc.getSize() - 1);
- if (ssjava.isSharedLocation(lastElement)) {
- ssjava.mapSharedLocation2Descriptor(lastElement, vd);
+ d2loc.put(vd, compLoc);
+ addLocationType(vd.getType(), compLoc);
}
- d2loc.put(vd, compLoc);
- addLocationType(vd.getType(), compLoc);
}
-
}
}
Descriptor d = state.getClassSymbolTable().get(className);
if (d == null) {
- System.out.println("state.getClassSymbolTable()=" + state.getClassSymbolTable());
+ // System.out.println("state.getClassSymbolTable()=" +
+ // state.getClassSymbolTable());
throw new Error("The class in the location declaration '" + decl + "' does not exist at "
+ msg);
}
SSJavaLattice<String> localLattice = CompositeLattice.getLatticeByDescriptor(md);
Location localLoc = new Location(md, localLocId);
if (localLattice == null || (!localLattice.containsKey(localLocId))) {
- System.out.println("locDec=" + locDec);
throw new Error("Location " + localLocId
+ " is not defined in the local variable lattice at "
+ md.getClassDesc().getSourceFileName() + "::" + (n != null ? n.getNumLine() : md) + ".");
private void addLocationType(TypeDescriptor type, CompositeLocation loc) {
if (type != null) {
- type.setExtension(loc);
+ TypeExtension te = type.getExtension();
+ SSJavaType ssType;
+ if (te != null) {
+ ssType = (SSJavaType) te;
+ ssType.setCompLoc(loc);
+ } else {
+ ssType = new SSJavaType(loc);
+ type.setExtension(ssType);
+ }
}
}
public static boolean isGreaterThan(CompositeLocation loc1, CompositeLocation loc2, String msg) {
- System.out.println("\nisGreaterThan=" + loc1 + " " + loc2 + " msg=" + msg);
+ // System.out.println("\nisGreaterThan=" + loc1 + " " + loc2 + " msg=" +
+ // msg);
int baseCompareResult = compareBaseLocationSet(loc1, loc2, true, false, msg);
if (baseCompareResult == ComparisonResult.EQUAL) {
if (compareDelta(loc1, loc2) == ComparisonResult.GREATER) {
public static int compare(CompositeLocation loc1, CompositeLocation loc2, boolean ignore,
String msg) {
- System.out.println("compare=" + loc1 + " " + loc2);
+ // System.out.println("compare=" + loc1 + " " + loc2);
int baseCompareResult = compareBaseLocationSet(loc1, loc2, false, ignore, msg);
if (baseCompareResult == ComparisonResult.EQUAL) {
public static CompositeLocation calculateGLB(Set<CompositeLocation> inputSet, String errMsg) {
- System.out.println("Calculating GLB=" + inputSet);
+ // System.out.println("Calculating GLB=" + inputSet);
CompositeLocation glbCompLoc = new CompositeLocation();
// calculate GLB of the first(priority) element
}
}
- System.out.println("GLB=" + glbCompLoc);
+ // System.out.println("GLB=" + glbCompLoc);
return glbCompLoc;
}
public static final int PARAMISSAME = 1;
public static final int IGNORE = 2;
- Hashtable<Integer, Integer> paramIdx2paramType;
+ private Hashtable<Integer, Integer> paramIdx2paramType;
- public ReturnLocGenerator(CompositeLocation returnLoc, List<CompositeLocation> params, String msg) {
- // creating mappings
- paramIdx2paramType = new Hashtable<Integer, Integer>();
- for (int i = 0; i < params.size(); i++) {
- CompositeLocation param = params.get(i);
- int compareResult = CompositeLattice.compare(param, returnLoc, true, msg);
+ private CompositeLocation declaredReturnLoc = null;
- int type;
- if (compareResult == ComparisonResult.GREATER) {
- type = 0;
- } else if (compareResult == ComparisonResult.EQUAL) {
- type = 1;
- } else {
- type = 2;
+ public ReturnLocGenerator(CompositeLocation returnLoc, MethodDescriptor md,
+ List<CompositeLocation> params, String msg) {
+
+ CompositeLocation thisLoc = params.get(0);
+ if (returnLoc.get(0).equals(thisLoc.get(0)) && returnLoc.getSize() > 1) {
+ // if the declared return location consists of THIS and field location,
+ // return location for the caller's side has to have same field element
+ this.declaredReturnLoc = returnLoc;
+ } else {
+ // creating mappings
+ paramIdx2paramType = new Hashtable<Integer, Integer>();
+ for (int i = 0; i < params.size(); i++) {
+ CompositeLocation param = params.get(i);
+ int compareResult = CompositeLattice.compare(param, returnLoc, true, msg);
+
+ int type;
+ if (compareResult == ComparisonResult.GREATER) {
+ type = 0;
+ } else if (compareResult == ComparisonResult.EQUAL) {
+ type = 1;
+ } else {
+ type = 2;
+ }
+ paramIdx2paramType.put(new Integer(i), new Integer(type));
}
- paramIdx2paramType.put(new Integer(i), new Integer(type));
}
}
public CompositeLocation computeReturnLocation(List<CompositeLocation> args) {
- // compute the highest possible location in caller's side
- assert paramIdx2paramType.keySet().size() == args.size();
-
- Set<CompositeLocation> inputGLB = new HashSet<CompositeLocation>();
- for (int i = 0; i < args.size(); i++) {
- int type = (paramIdx2paramType.get(new Integer(i))).intValue();
- CompositeLocation argLoc = args.get(i);
- if (type == PARAMISHIGHER) {
- // return loc is lower than param
- DeltaLocation delta = new DeltaLocation(argLoc, 1);
- inputGLB.add(delta);
- } else if (type == PARAMISSAME) {
- // return loc is equal or lower than param
- inputGLB.add(argLoc);
+ if (declaredReturnLoc != null) {
+ // when developer specify that the return value is [THIS,field]
+ // needs to translate to the caller's location
+ CompositeLocation callerLoc = new CompositeLocation();
+ CompositeLocation callerBaseLocation = args.get(0);
+
+ for (int i = 0; i < callerBaseLocation.getSize(); i++) {
+ callerLoc.addLocation(callerBaseLocation.get(i));
+ }
+ for (int i = 1; i < declaredReturnLoc.getSize(); i++) {
+ callerLoc.addLocation(declaredReturnLoc.get(i));
+ }
+ return callerLoc;
+ } else {
+ // compute the highest possible location in caller's side
+ assert paramIdx2paramType.keySet().size() == args.size();
+
+ Set<CompositeLocation> inputGLB = new HashSet<CompositeLocation>();
+ for (int i = 0; i < args.size(); i++) {
+ int type = (paramIdx2paramType.get(new Integer(i))).intValue();
+ CompositeLocation argLoc = args.get(i);
+ if (type == PARAMISHIGHER || type == PARAMISSAME) {
+ // return loc is equal to or lower than param
+ inputGLB.add(argLoc);
+ }
+ }
+
+ // compute GLB of arguments subset that are same or higher than return
+ // location
+ if (inputGLB.isEmpty()) {
+ CompositeLocation rtr =
+ new CompositeLocation(Location.createTopLocation(args.get(0).get(0).getDescriptor()));
+ return rtr;
+ } else {
+ CompositeLocation glb = CompositeLattice.calculateGLB(inputGLB, "");
+ return glb;
}
}
- // compute GLB of arguments subset that are same or higher than return
- // location
- CompositeLocation glb = CompositeLattice.calculateGLB(inputGLB, "");
- return glb;
}
}
projects / IRC.git / blobdiff