a bug fix...
[IRC.git] / Robust / src / Analysis / SSJava / BuildLattice.java
index b306a4fc00cf9abbd8d1cd1ccf8970fd5d41a302..61a083274e84e97c7968442d8bc6d5d502d343f8 100644 (file)
@@ -6,18 +6,28 @@ import java.util.Iterator;
 import java.util.Map;
 import java.util.Set;
 
+import IR.ClassDescriptor;
 import IR.Descriptor;
 import IR.MethodDescriptor;
+import IR.NameDescriptor;
 import Util.Pair;
 
 public class BuildLattice {
 
   private LocationInference infer;
   private Map<HNode, TripleItem> mapSharedNodeToTripleItem;
+  private Map<HNode, Integer> mapHNodeToHighestIndex;
+
+  private Map<Descriptor, Map<TripleItem, String>> mapDescToIntermediateLocMap;
+
+  private Map<Pair<HNode, HNode>, Integer> mapItemToHighestIndex;
 
   public BuildLattice(LocationInference infer) {
     this.infer = infer;
     this.mapSharedNodeToTripleItem = new HashMap<HNode, TripleItem>();
+    this.mapHNodeToHighestIndex = new HashMap<HNode, Integer>();
+    this.mapItemToHighestIndex = new HashMap<Pair<HNode, HNode>, Integer>();
+    this.mapDescToIntermediateLocMap = new HashMap<Descriptor, Map<TripleItem, String>>();
   }
 
   public SSJavaLattice<String> buildLattice(Descriptor desc) {
@@ -25,6 +35,10 @@ public class BuildLattice {
     HierarchyGraph inputGraph = infer.getSkeletonCombinationHierarchyGraph(desc);
     LocationSummary locSummary = infer.getLocationSummary(desc);
 
+    HierarchyGraph naiveGraph = infer.getSimpleHierarchyGraph(desc);
+
+    // I don't think we need to keep the below if statement anymore
+    // because hierarchy graph does not have any composite location
     Set<HNode> nodeSetWithCompositeLocation = new HashSet<HNode>();
     if (desc instanceof MethodDescriptor) {
       FlowGraph flowGraph = infer.getFlowGraph((MethodDescriptor) desc);
@@ -48,19 +62,62 @@ public class BuildLattice {
 
     }
 
+    // /////////////////////////////////////////////////////////////////////////////////////
+    // lattice generation for the native approach
+
+    if (infer.state.SSJAVA_INFER_NAIVE_WRITEDOTS) {
+      BasisSet naiveBasisSet = naiveGraph.computeBasisSet(nodeSetWithCompositeLocation);
+
+      Family naiveFamily = generateFamily(naiveBasisSet);
+      Map<Set<Integer>, Set<Set<Integer>>> naive_mapImSucc =
+          coveringGraph(naiveBasisSet, naiveFamily);
+
+      SSJavaLattice<String> naive_lattice =
+          buildLattice(desc, naiveBasisSet, naiveGraph, null, naive_mapImSucc);
+      LocationInference.numLocationsNaive += naive_lattice.getKeySet().size();
+      infer.addNaiveLattice(desc, naive_lattice);
+    }
+
+    // /////////////////////////////////////////////////////////////////////////////////////
+
+    // lattice generation for the proposed approach
     BasisSet basisSet = inputGraph.computeBasisSet(nodeSetWithCompositeLocation);
-    debug_print(inputGraph);
+    // debug_print(inputGraph);
 
     Family family = generateFamily(basisSet);
     Map<Set<Integer>, Set<Set<Integer>>> mapImSucc = coveringGraph(basisSet, family);
 
-    SSJavaLattice<String> lattice = buildLattice(basisSet, inputGraph, locSummary, mapImSucc);
+    SSJavaLattice<String> lattice = buildLattice(desc, basisSet, inputGraph, locSummary, mapImSucc);
     return lattice;
 
   }
 
-  private SSJavaLattice<String> buildLattice(BasisSet basisSet, HierarchyGraph inputGraph,
-      LocationSummary locSummary, Map<Set<Integer>, Set<Set<Integer>>> mapImSucc) {
+  public void setIntermediateLocMap(Descriptor desc, Map<TripleItem, String> map) {
+    mapDescToIntermediateLocMap.put(desc, map);
+  }
+
+  public Map<TripleItem, String> getIntermediateLocMap(Descriptor desc) {
+    if (!mapDescToIntermediateLocMap.containsKey(desc)) {
+      mapDescToIntermediateLocMap.put(desc, new HashMap<TripleItem, String>());
+    }
+    return mapDescToIntermediateLocMap.get(desc);
+  }
+
+  private Descriptor getParent(Descriptor desc) {
+    if (desc instanceof MethodDescriptor) {
+      MethodDescriptor md = (MethodDescriptor) desc;
+      ClassDescriptor cd = md.getClassDesc();
+      return infer.getParentMethodDesc(cd, md);
+    } else {
+      return ((ClassDescriptor) desc).getSuperDesc();
+    }
+  }
+
+  private SSJavaLattice<String> buildLattice(Descriptor desc, BasisSet basisSet,
+      HierarchyGraph inputGraph, LocationSummary locSummary,
+      Map<Set<Integer>, Set<Set<Integer>>> mapImSucc) {
+
+    System.out.println("\nBuild Lattice:" + inputGraph.getName());
 
     SSJavaLattice<String> lattice =
         new SSJavaLattice<String>(SSJavaAnalysis.TOP, SSJavaAnalysis.BOTTOM);
@@ -74,16 +131,27 @@ public class BuildLattice {
       String higherName = generateElementName(basisSet, inputGraph, mapFToLocName, higher);
 
       HNode higherNode = inputGraph.getHNode(higherName);
+
+      if (higherNode == null) {
+        NameDescriptor d = new NameDescriptor(higherName);
+        higherNode = inputGraph.getHNode(d);
+        higherNode.setSkeleton(true);
+      }
+
       if (higherNode != null && higherNode.isSharedNode()) {
         lattice.addSharedLoc(higherName);
       }
       Set<Descriptor> descSet = inputGraph.getDescSetOfNode(higherNode);
       // System.out.println("higherName=" + higherName + "  higherNode=" + higherNode + "  descSet="
       // + descSet);
-      for (Iterator iterator2 = descSet.iterator(); iterator2.hasNext();) {
-        Descriptor d = (Descriptor) iterator2.next();
-        locSummary.addMapHNodeNameToLocationName(d.getSymbol(), higherName);
+
+      if (locSummary != null) {
+        for (Iterator iterator2 = descSet.iterator(); iterator2.hasNext();) {
+          Descriptor d = (Descriptor) iterator2.next();
+          locSummary.addMapHNodeNameToLocationName(d.getSymbol(), higherName);
+        }
       }
+
       // locSummary.addMapHNodeNameToLocationName(higherName, higherName);
 
       Set<Set<Integer>> lowerSet = mapImSucc.get(higher);
@@ -92,6 +160,17 @@ public class BuildLattice {
 
         String lowerName = generateElementName(basisSet, inputGraph, mapFToLocName, lower);
         HNode lowerNode = inputGraph.getHNode(lowerName);
+
+        if (lowerNode == null && !lowerName.equals(SSJavaAnalysis.BOTTOM)) {
+          NameDescriptor d = new NameDescriptor(lowerName);
+          lowerNode = inputGraph.getHNode(d);
+          lowerNode.setSkeleton(true);
+        }
+
+        if (lowerNode != null && !inputGraph.isDirectlyConnectedTo(higherNode, lowerNode)) {
+          inputGraph.addEdge(higherNode, lowerNode);
+        }
+
         if (lowerNode != null && lowerNode.isSharedNode()) {
           lattice.addSharedLoc(lowerName);
         }
@@ -99,9 +178,11 @@ public class BuildLattice {
         Set<Descriptor> lowerDescSet = inputGraph.getDescSetOfNode(lowerNode);
         // System.out.println("lowerName=" + lowerName + "  lowerNode=" + lowerNode + "  descSet="
         // + lowerDescSet);
-        for (Iterator iterator3 = lowerDescSet.iterator(); iterator3.hasNext();) {
-          Descriptor d = (Descriptor) iterator3.next();
-          locSummary.addMapHNodeNameToLocationName(d.getSymbol(), lowerName);
+        if (locSummary != null) {
+          for (Iterator iterator3 = lowerDescSet.iterator(); iterator3.hasNext();) {
+            Descriptor d = (Descriptor) iterator3.next();
+            locSummary.addMapHNodeNameToLocationName(d.getSymbol(), lowerName);
+          }
         }
         // locSummary.addMapHNodeNameToLocationName(lowerName, lowerName);
 
@@ -116,6 +197,7 @@ public class BuildLattice {
 
     }
 
+    inputGraph.removeRedundantEdges();
     return lattice;
   }
 
@@ -143,6 +225,279 @@ public class BuildLattice {
   public SSJavaLattice<String> insertIntermediateNodesToStraightLine(Descriptor desc,
       SSJavaLattice<String> skeletonLattice) {
 
+    SSJavaLattice<String> lattice = skeletonLattice.clone();
+    LocationSummary locSummary = infer.getLocationSummary(desc);
+
+    Descriptor parentDesc = getParent(desc);
+    if (parentDesc != null) {
+      SSJavaLattice<String> parentLattice = infer.getLattice(parentDesc);
+
+      Map<String, Set<String>> parentMap = parentLattice.getTable();
+      Set<String> parentKeySet = parentMap.keySet();
+      for (Iterator iterator = parentKeySet.iterator(); iterator.hasNext();) {
+        String parentKey = (String) iterator.next();
+        Set<String> parentValueSet = parentMap.get(parentKey);
+        for (Iterator iterator2 = parentValueSet.iterator(); iterator2.hasNext();) {
+          String value = (String) iterator2.next();
+          lattice.put(parentKey, value);
+        }
+      }
+
+      Set<String> parentSharedLocSet = parentLattice.getSharedLocSet();
+      for (Iterator iterator = parentSharedLocSet.iterator(); iterator.hasNext();) {
+        String parentSharedLoc = (String) iterator.next();
+        lattice.addSharedLoc(parentSharedLoc);
+      }
+    }
+
+    HierarchyGraph hierarchyGraph = infer.getSimpleHierarchyGraph(desc);
+    HierarchyGraph scGraph = infer.getSkeletonCombinationHierarchyGraph(desc);
+
+    Set<HNode> hierarchyGraphNodeSet = hierarchyGraph.getNodeSet();
+    for (Iterator iterator = hierarchyGraphNodeSet.iterator(); iterator.hasNext();) {
+      HNode hNode = (HNode) iterator.next();
+      if (!hNode.isSkeleton()) {
+        // here we need to insert an intermediate node for the hNode
+        System.out.println("local node=" + hNode);
+
+        // 1) find the lowest node m in the lattice that is above hnode in the lattice
+        // 2) count the number of non-shared nodes d between the hnode and the node m
+        int numNonSharedNodes;
+
+        HNode SCNode;
+        if (hNode.isDirectCombinationNode()) {
+          // this node itself is the lowest node m. it is the first node of the chain
+          Set<HNode> combineSet = hierarchyGraph.getCombineSetByCombinationNode(hNode);
+          SCNode = scGraph.getCombinationNode(combineSet);
+          numNonSharedNodes = -1;
+        } else {
+
+          Set<HNode> aboveSet = new HashSet<HNode>();
+          if (hNode.isCombinationNode()) {
+            Set<HNode> combineSkeletonNodeSet =
+                hierarchyGraph.getCombineSetByCombinationNode(hNode);
+
+            aboveSet.addAll(hierarchyGraph
+                .getFirstNodeOfCombinationNodeChainSet(combineSkeletonNodeSet));
+            SCNode = scGraph.getCombinationNode(combineSkeletonNodeSet);
+          } else {
+            System.out.println("   #######hierarchyGraph.getSkeleteNodeSetReachTo(" + hNode + ")="
+                + hierarchyGraph.getSkeleteNodeSetReachTo(hNode));
+
+            aboveSet.addAll(hierarchyGraph.getSkeleteNodeSetReachTo(hNode));
+            // assert aboveSet.size() == 1;
+            SCNode = aboveSet.iterator().next();
+          }
+
+          // update above set w.r.t the hierarchy graph with SC nodes
+          // because the skeleton nodes in the origianl hierarchy graph may merged to a new node
+          Set<HNode> endSet = new HashSet<HNode>();
+          for (Iterator iterator2 = aboveSet.iterator(); iterator2.hasNext();) {
+            HNode aboveNode = (HNode) iterator2.next();
+            endSet.add(scGraph.getCurrentHNode(aboveNode));
+          }
+          numNonSharedNodes = hierarchyGraph.countNonSharedNode(hNode, endSet);
+
+          System.out.println("   node=" + hNode + " above=" + endSet + " distance="
+              + numNonSharedNodes + "   SCNode=" + SCNode);
+        }
+
+        // 3) convert the node m into a chain of nodes with the last node in the chain having m’s
+        // outgoing edges.
+        Set<String> outgoingElements = skeletonLattice.get(SCNode.getName());
+        System.out.println("   SCNODE outgoing=" + outgoingElements);
+
+        // 4) If hnode is not a shared location, check if there already exists a local variable
+        // node that has distance d below m along this chain. If such a node
+        // does not exist, insert it.
+        String locName =
+            getNewLocation(lattice, SCNode.getName(), outgoingElements, numNonSharedNodes,
+                hNode.isSharedNode());
+        System.out.println("       locName=" + locName);
+        locSummary.addMapHNodeNameToLocationName(hNode.getName(), locName);
+
+      }
+    }
+
+    return lattice;
+  }
+
+  public String getNewLocation(SSJavaLattice<String> lattice, String start, Set<String> endSet,
+      int dist, boolean isShared) {
+    System.out.println("       getNewLocation:: start=" + start + "  endSet=" + endSet + " dist="
+        + dist + " isShared=" + isShared);
+    if (dist == -1) {
+      return start;
+    }
+    return recur_getNewLocation(lattice, start, endSet, dist, isShared);
+  }
+
+  private String recur_getNewLocation(SSJavaLattice<String> lattice, String cur,
+      Set<String> endSet, int dist, boolean isShared) {
+    System.out.println("H");
+    Set<String> connectedSet = lattice.get(cur);
+    if (connectedSet == null) {
+      connectedSet = new HashSet<String>();
+    }
+
+    System.out.println("       recur_getNewLocation cur=" + cur + " dist=" + dist
+        + " connectedSet=" + connectedSet + " endSet=" + endSet);
+
+    if (dist == 0 && isShared) {
+      // if the node is shared,
+      // check if there already exists a shared node that has distance d + 1 on the chain
+      connectedSet = lattice.get(cur);
+      if (connectedSet.equals(endSet)) {
+        // need to insert a new shared location
+      } else {
+        assert connectedSet.size() == 1;
+        String below = connectedSet.iterator().next();
+        if (lattice.isSharedLoc(below)) {
+          return below;
+        }
+      }
+
+      // need to insert a new shared location
+      String newLocName = "ILOC" + (LocationInference.locSeed++);
+      for (Iterator iterator = connectedSet.iterator(); iterator.hasNext();) {
+        String outNode = (String) iterator.next();
+        lattice.put(newLocName, outNode);
+      }
+      connectedSet.clear();
+      lattice.put(cur, newLocName);
+
+      System.out.println("       INSERT NEW SHARED NODE=" + newLocName + " above=" + cur
+          + " below=" + lattice.get(newLocName));
+
+      lattice.addSharedLoc(newLocName);
+
+      return newLocName;
+
+    }
+
+    String next;
+    if (connectedSet.equals(endSet)) {
+      // need to insert a new location
+      String newLocName = "ILOC" + (LocationInference.locSeed++);
+      connectedSet.clear();
+      lattice.put(cur, newLocName);
+      System.out.println("NEW RELATION=" + lattice.get(cur));
+      for (Iterator iterator = endSet.iterator(); iterator.hasNext();) {
+        String endNode = (String) iterator.next();
+        lattice.put(newLocName, endNode);
+      }
+      next = newLocName;
+      System.out.println("       INSERT NEW NODE=" + newLocName + " above=" + cur + " below="
+          + endSet);
+    } else {
+      assert connectedSet.size() == 1;
+      next = connectedSet.iterator().next();
+    }
+    System.out.println("              next=" + next);
+
+    // if (dist == 0) {
+
+    // if (isShared) {
+
+    // // if the node is shared,
+    // // check if there already exists a shared node that has distance d + 1 on the chain
+    //
+    // connectedSet = lattice.get(next);
+    //
+    // if (connectedSet.equals(endSet)) {
+    // // need to insert a new shared location
+    // } else {
+    // assert connectedSet.size() != 1;
+    // String below = connectedSet.iterator().next();
+    // if (lattice.isSharedLoc(below)) {
+    // return below;
+    // }
+    // }
+    //
+    // // need to insert a new shared location
+    // String newLocName = "ILOC" + (LocationInference.locSeed++);
+    // for (Iterator iterator = connectedSet.iterator(); iterator.hasNext();) {
+    // String outNode = (String) iterator.next();
+    // lattice.put(newLocName, outNode);
+    // }
+    // connectedSet.clear();
+    // lattice.put(next, newLocName);
+    //
+    // System.out.println("       INSERT NEW SHARED NODE=" + newLocName + " above=" + next
+    // + " below=" + lattice.get(newLocName));
+    //
+    // lattice.addSharedLoc(newLocName);
+    //
+    // next = newLocName;
+    //
+    // }
+    //
+    // return next;
+
+    // } else {
+
+    if (dist == 0) {
+      return next;
+    } else {
+      if (!lattice.isSharedLoc(next)) {
+        dist--;
+      }
+      return recur_getNewLocation(lattice, next, endSet, dist, isShared);
+    }
+
+    // }
+
+    // ///////////////////////////////////////////////
+
+    // if (dist == 0) {
+    // return cur;
+    // } else if (connectedSet.equals(endSet)) {
+    // // need to insert a new location
+    // String newLocName = "ILOC" + (LocationInference.locSeed++);
+    // connectedSet.clear();
+    // lattice.put(cur, newLocName);
+    // for (Iterator iterator = endSet.iterator(); iterator.hasNext();) {
+    // String endNode = (String) iterator.next();
+    // lattice.put(newLocName, endNode);
+    // }
+    // return recur_getNewLocation(lattice, newLocName, endSet, --dist, isShared);
+    // } else {
+    // assert connectedSet.size() != 1;
+    // String next = connectedSet.iterator().next();
+    // return recur_getNewLocation(lattice, next, endSet, --dist, isShared);
+    // }
+
+  }
+
+  public SSJavaLattice<String> insertIntermediateNodesToStraightLine2(Descriptor desc,
+      SSJavaLattice<String> skeletonLattice) {
+    // copy nodes/edges from the parent method/class if possible
+    SSJavaLattice<String> lattice = skeletonLattice.clone();
+
+    Descriptor parentDesc = getParent(desc);
+    if (parentDesc != null) {
+      SSJavaLattice<String> parentLattice = infer.getLattice(parentDesc);
+
+      Map<String, Set<String>> parentMap = parentLattice.getTable();
+      Set<String> parentKeySet = parentMap.keySet();
+      for (Iterator iterator = parentKeySet.iterator(); iterator.hasNext();) {
+        String parentKey = (String) iterator.next();
+        Set<String> parentValueSet = parentMap.get(parentKey);
+        for (Iterator iterator2 = parentValueSet.iterator(); iterator2.hasNext();) {
+          String value = (String) iterator2.next();
+          lattice.put(parentKey, value);
+        }
+      }
+
+      Set<String> parentSharedLocSet = parentLattice.getSharedLocSet();
+      for (Iterator iterator = parentSharedLocSet.iterator(); iterator.hasNext();) {
+        String parentSharedLoc = (String) iterator.next();
+        lattice.addSharedLoc(parentSharedLoc);
+      }
+    }
+
+    // ////
+
     // perform DFS that starts from each skeleton/combination node and ends by another
     // skeleton/combination node
 
@@ -152,19 +507,18 @@ public class BuildLattice {
     HierarchyGraph scGraph = infer.getSkeletonCombinationHierarchyGraph(desc);
     LocationSummary locSummary = infer.getLocationSummary(desc);
 
-    SSJavaLattice<String> lattice = skeletonLattice.clone();
-
     Set<HNode> visited = new HashSet<HNode>();
 
     Set<HNode> nodeSet = simpleGraph.getNodeSet();
 
-    Map<TripleItem, String> mapIntermediateLoc = new HashMap<TripleItem, String>();
+    Map<TripleItem, String> mapIntermediateLoc = getIntermediateLocMap(desc);
+    // Map<TripleItem, String> mapIntermediateLoc = new HashMap<TripleItem, String>();
 
     // System.out.println("*insert=" + desc);
     // System.out.println("***nodeSet=" + nodeSet);
     for (Iterator iterator = nodeSet.iterator(); iterator.hasNext();) {
       HNode node = (HNode) iterator.next();
-      // System.out.println("node=" + node);
+      System.out.println("node=" + node);
 
       if (node.isSkeleton() && (!visited.contains(node))) {
         visited.add(node);
@@ -175,7 +529,12 @@ public class BuildLattice {
 
           if (!outNode.isSkeleton()) {
             if (outNode.isCombinationNode()) {
-              expandCombinationNode(desc, lattice, visited, mapIntermediateLoc, locSummary, outNode);
+              if (visited.containsAll(simpleGraph.getIncomingNodeSet(outNode))) {
+                // if (needToExpandCombinationNode(desc, outNode)) {
+                expandCombinationNode(desc, lattice, visited, mapIntermediateLoc, locSummary,
+                    outNode);
+                // }
+              }
             } else {
               // we have a node that is neither combination or skeleton node
               // System.out.println("%%%skeleton node=" + node + "  outNode=" + outNode);
@@ -190,16 +549,18 @@ public class BuildLattice {
               // startNode = node;
               // }
 
-              Set<HNode> endNodeSetFromSimpleGraph =
-                  simpleGraph.getDirectlyReachableSkeletonCombinationNodeFrom(outNode, null);
+              // TODO
+              // Set<HNode> endNodeSetFromSimpleGraph =
+              // simpleGraph.getDirectlyReachableSkeletonCombinationNodeFrom(outNode, null);
+              // Set<HNode> endCombNodeSet = new HashSet<HNode>();
+              // for (Iterator iterator3 = endNodeSetFromSimpleGraph.iterator();
+              // iterator3.hasNext();) {
+              // HNode endNode = (HNode) iterator3.next();
+              // endCombNodeSet.add(getCombinationNodeInSCGraph(desc, endNode));
+              // }
+
+              Set<HNode> endCombNodeSet = scGraph.getOutgoingNodeSet(startNode);
 
-              // System.out.println("endNodeSetFromSimpleGraph=" + endNodeSetFromSimpleGraph
-              // + "   from=" + outNode);
-              Set<HNode> endCombNodeSet = new HashSet<HNode>();
-              for (Iterator iterator3 = endNodeSetFromSimpleGraph.iterator(); iterator3.hasNext();) {
-                HNode endNode = (HNode) iterator3.next();
-                endCombNodeSet.add(getCombinationNodeInSCGraph(desc, endNode));
-              }
               // System.out.println("endCombNodeSet=" + endCombNodeSet);
               visited.add(outNode);
               if (endCombNodeSet.size() > 0) {
@@ -259,7 +620,8 @@ public class BuildLattice {
       HNode sharedNode = (HNode) iterator.next();
       TripleItem item = mapSharedNodeToTripleItem.get(sharedNode);
       String nonSharedLocName = mapIntermediateLoc.get(item);
-      // System.out.println("sharedNode=" + sharedNode + "    locName=" + nonSharedLocName);
+
+      System.out.println("sharedNode=" + sharedNode + "    locName=" + nonSharedLocName);
 
       String newLocName;
       if (locSummary.getHNodeNameSetByLatticeLoationName(nonSharedLocName) != null
@@ -272,8 +634,8 @@ public class BuildLattice {
         Set<String> belowElementSet = new HashSet<String>();
         belowElementSet.addAll(lattice.get(nonSharedLocName));
 
-        // System.out.println("nonSharedLocName=" + nonSharedLocName + "   belowElementSet="
-        // + belowElementSet + "  newLocName=" + newLocName);
+        System.out.println("nonSharedLocName=" + nonSharedLocName + "   belowElementSet="
+            + belowElementSet + "  newLocName=" + newLocName);
 
         lattice.insertNewLocationBetween(nonSharedLocName, belowElementSet, newLocName);
       } else {
@@ -311,16 +673,46 @@ public class BuildLattice {
     return aboveSet;
   }
 
+  private boolean needToExpandCombinationNode(Descriptor desc, HNode cnode) {
+
+    System.out.println("needToExpandCombinationNode?=" + cnode);
+
+    HierarchyGraph simpleGraph = infer.getSimpleHierarchyGraph(desc);
+    // HNode combinationNodeInSCGraph = getCombinationNodeInSCGraph(desc, cnode);
+    Set<HNode> combineSkeletonNodeSet = simpleGraph.getCombineSetByCombinationNode(cnode);
+    Set<HNode> combinationNodeSetInSimpleGraph =
+        simpleGraph.getCombinationNodeSetByCombineNodeSet(combineSkeletonNodeSet);
+    System.out.println("---combinationNodeSetInSimpleGraph=" + combinationNodeSetInSimpleGraph);
+    Set<HNode> inNodeSetToCNode = simpleGraph.getIncomingNodeSet(cnode);
+    System.out.println("------inNodeSetToCNode=" + inNodeSetToCNode);
+    for (Iterator iterator = combinationNodeSetInSimpleGraph.iterator(); iterator.hasNext();) {
+      HNode nodeBelongToTheSameCombinationNode = (HNode) iterator.next();
+      if (inNodeSetToCNode.contains(nodeBelongToTheSameCombinationNode)) {
+        // the combination node 'cnode' is not the highest location among the same combination node
+        return false;
+      }
+    }
+
+    return true;
+  }
+
   private void expandCombinationNode(Descriptor desc, SSJavaLattice<String> lattice,
       Set<HNode> visited, Map<TripleItem, String> mapIntermediateLoc, LocationSummary locSummary,
       HNode cnode) {
 
-    // System.out.println("expandCombinationNode=" + cnode);
     // expand the combination node 'outNode'
     // here we need to expand the corresponding combination location in the lattice
     HNode combinationNodeInSCGraph = getCombinationNodeInSCGraph(desc, cnode);
 
+    System.out.println("expandCombinationNode=" + cnode + "  cnode in scgraph="
+        + combinationNodeInSCGraph);
+
+    if (combinationNodeInSCGraph == null) {
+      return;
+    }
+
     HierarchyGraph simpleGraph = infer.getSimpleHierarchyGraph(desc);
+    HierarchyGraph scGraph = infer.getSkeletonCombinationHierarchyGraph(desc);
 
     Set<HNode> combineSkeletonNodeSet = simpleGraph.getCombineSetByCombinationNode(cnode);
 
@@ -331,14 +723,17 @@ public class BuildLattice {
 
     // System.out.println("combinationNodeSet=" + combinationNodeSet);
 
-    Set<HNode> endNodeSetFromSimpleGraph =
-        simpleGraph.getDirectlyReachableSkeletonCombinationNodeFrom(cnode, combinationNodeSet);
+    // TODO
+    // Set<HNode> endNodeSetFromSimpleGraph =
+    // simpleGraph.getDirectlyReachableSkeletonCombinationNodeFrom(cnode, combinationNodeSet);
     // System.out.println("-endNodeSetFromSimpleGraph=" + endNodeSetFromSimpleGraph);
-    Set<HNode> endCombNodeSet = new HashSet<HNode>();
-    for (Iterator iterator3 = endNodeSetFromSimpleGraph.iterator(); iterator3.hasNext();) {
-      HNode endNode = (HNode) iterator3.next();
-      endCombNodeSet.add(getCombinationNodeInSCGraph(desc, endNode));
-    }
+    // Set<HNode> endCombNodeSet = new HashSet<HNode>();
+    // for (Iterator iterator3 = endNodeSetFromSimpleGraph.iterator(); iterator3.hasNext();) {
+    // HNode endNode = (HNode) iterator3.next();
+    // endCombNodeSet.add(getCombinationNodeInSCGraph(desc, endNode));
+    // }
+
+    Set<HNode> endCombNodeSet = scGraph.getOutgoingNodeSet(combinationNodeInSCGraph);
     visited.add(cnode);
 
     // follows the straight line up to another skeleton/combination node
@@ -471,7 +866,6 @@ public class BuildLattice {
       int idx, LocationSummary locSummary, HNode curNode) {
 
     TripleItem item = new TripleItem(startNode, endNodeSet, idx);
-    // System.out.println("item=" + item);
     if (!mapIntermediateLoc.containsKey(item)) {
       // need to create a new intermediate location in the lattice
       String newLocName = "ILOC" + (LocationInference.locSeed++);
@@ -501,13 +895,14 @@ public class BuildLattice {
     }
 
     String locName = mapIntermediateLoc.get(item);
-    HierarchyGraph graph = infer.getSimpleHierarchyGraph(desc);
+    HierarchyGraph simpleHierarchyGraph = infer.getSimpleHierarchyGraph(desc);
 
     if (curNode.isSharedNode()) {
       // if the current node is shared location, add a shared location to the lattice later
+      System.out.println("###SHARED ITEM=" + item);
       mapSharedNodeToTripleItem.put(curNode, item);
     } else {
-      Set<Descriptor> descSet = graph.getDescSetOfNode(curNode);
+      Set<Descriptor> descSet = simpleHierarchyGraph.getDescSetOfNode(curNode);
       for (Iterator iterator = descSet.iterator(); iterator.hasNext();) {
         Descriptor d = (Descriptor) iterator.next();
         locSummary.addMapHNodeNameToLocationName(d.getSymbol(), locName);
@@ -515,24 +910,39 @@ public class BuildLattice {
       locSummary.addMapHNodeNameToLocationName(curNode.getName(), locName);
     }
 
-    // System.out.println("-TripleItem=" + item);
-    // System.out.println("-curNode=" + curNode.getName() + " S=" + curNode.isSharedNode()
-    // + " locName=" + locName);
+    System.out.println("-TripleItem normal=" + item);
+    System.out.println("-curNode=" + curNode.getName() + " S=" + curNode.isSharedNode()
+        + " locName=" + locName + "  isC=" + curNode.isCombinationNode());
 
-    Set<HNode> outSet = graph.getOutgoingNodeSet(curNode);
+    Set<HNode> outSet = simpleHierarchyGraph.getOutgoingNodeSet(curNode);
     for (Iterator iterator2 = outSet.iterator(); iterator2.hasNext();) {
       HNode outNode = (HNode) iterator2.next();
 
-      Set<HNode> inNodeSetToOutNode = graph.getIncomingNodeSet(outNode);
+      Set<HNode> incomingHNodeSetToOutNode = simpleHierarchyGraph.getIncomingNodeSet(outNode);
+      System.out.println("outNode=" + outNode);
+      System.out.println("---incomingHNodeSetToOutNode=" + incomingHNodeSetToOutNode);
 
-      if (visited.containsAll(inNodeSetToOutNode)) {
-        if (!outNode.isSkeleton() && !outNode.isCombinationNode() && !visited.contains(outNode)) {
+      if (!outNode.isSkeleton() && !outNode.isCombinationNode() && !visited.contains(outNode)) {
+        Pair<HNode, HNode> pair = new Pair(startNode, outNode);
+        if (visited.containsAll(simpleHierarchyGraph.getIncomingNodeSet(outNode))) {
           visited.add(outNode);
+          int newidx = getCurrentHighestIndex(pair, idx + 1);
+          // int newidx = getCurrentHighestIndex(outNode, idx + 1);
           recurDFSNormalNode(desc, lattice, startNode, endNodeSet, visited, mapIntermediateLoc,
-              idx + 1, locSummary, outNode);
-        } else if (!outNode.isSkeleton() && outNode.isCombinationNode()
-            && !visited.contains(outNode)) {
+              newidx, locSummary, outNode);
+          // recurDFSNormalNode(desc, lattice, startNode, endNodeSet, visited, mapIntermediateLoc,
+          // idx + 1, locSummary, outNode);
+        } else {
+          updateHighestIndex(pair, idx + 1);
+          // updateHighestIndex(outNode, idx + 1);
+          System.out.println("NOT RECUR");
+        }
+      } else if (!outNode.isSkeleton() && outNode.isCombinationNode() && !visited.contains(outNode)) {
+        if (needToExpandCombinationNode(desc, outNode)) {
+          System.out.println("NEED TO");
           expandCombinationNode(desc, lattice, visited, mapIntermediateLoc, locSummary, outNode);
+        } else {
+          System.out.println("NOT NEED TO");
         }
       }
 
@@ -578,13 +988,14 @@ public class BuildLattice {
     // return;
     // }
 
-    HierarchyGraph graph = infer.getSimpleHierarchyGraph(desc);
+    HierarchyGraph simpleHierarchyGraph = infer.getSimpleHierarchyGraph(desc);
     String locName = mapIntermediateLoc.get(item);
     if (curNode.isSharedNode()) {
       // if the current node is shared location, add a shared location to the lattice later
+      System.out.println("###SHARED ITEM=" + item);
       mapSharedNodeToTripleItem.put(curNode, item);
     } else {
-      Set<Descriptor> descSet = graph.getDescSetOfNode(curNode);
+      Set<Descriptor> descSet = simpleHierarchyGraph.getDescSetOfNode(curNode);
       for (Iterator iterator = descSet.iterator(); iterator.hasNext();) {
         Descriptor d = (Descriptor) iterator.next();
         locSummary.addMapHNodeNameToLocationName(d.getSymbol(), locName);
@@ -592,38 +1003,112 @@ public class BuildLattice {
       locSummary.addMapHNodeNameToLocationName(curNode.getName(), locName);
     }
 
-    // System.out.println("-TripleItem=" + item);
-    // System.out.println("-curNode=" + curNode.getName() + " S=" + curNode.isSharedNode()
-    // + " locName=" + locName);
+    System.out.println("-TripleItem=" + item);
+    System.out.println("-curNode=" + curNode.getName() + " S=" + curNode.isSharedNode()
+        + " locName=" + locName);
 
-    Set<HNode> outSet = graph.getOutgoingNodeSet(curNode);
+    Set<HNode> outSet = simpleHierarchyGraph.getOutgoingNodeSet(curNode);
     for (Iterator iterator2 = outSet.iterator(); iterator2.hasNext();) {
       HNode outNode = (HNode) iterator2.next();
-      // System.out.println("recurDFS outNode=" + outNode);
-      // System.out.println("---cur combinationNodeInSCGraph=" + combinationNodeInSCGraph);
-      // System.out.println("---outNode combinationNodeInSCGraph="
-      // + getCombinationNodeInSCGraph(desc, outNode));
-
-      Set<HNode> inNodeSetToOutNode = graph.getIncomingNodeSet(outNode);
-
-      if (visited.containsAll(inNodeSetToOutNode)) {
-        if (!outNode.isSkeleton() && !visited.contains(outNode)) {
-          if (outNode.isCombinationNode()) {
-            // check whether the next combination node is different from the current node
-            if (combinationNodeInSCGraph.equals(getCombinationNodeInSCGraph(desc, outNode))) {
+      System.out.println("---recurDFS outNode=" + outNode);
+      System.out.println("---cur combinationNodeInSCGraph=" + combinationNodeInSCGraph);
+      System.out.println("---outNode combinationNodeInSCGraph="
+          + getCombinationNodeInSCGraph(desc, outNode));
+
+      if (!outNode.isSkeleton() && !visited.contains(outNode)) {
+        if (outNode.isCombinationNode()) {
+
+          Set<HNode> combineSkeletonNodeSet =
+              simpleHierarchyGraph.getCombineSetByCombinationNode(outNode);
+          Set<HNode> incomingHNodeSetToOutNode = simpleHierarchyGraph.getIncomingNodeSet(outNode);
+          // extract nodes belong to the same combine node
+          Set<HNode> incomingCombinedHNodeSet = new HashSet<HNode>();
+          for (Iterator iterator = incomingHNodeSetToOutNode.iterator(); iterator.hasNext();) {
+            HNode inNode = (HNode) iterator.next();
+            if (combineSkeletonNodeSet.contains(inNode)) {
+              incomingCombinedHNodeSet.add(inNode);
+            }
+          }
+          System.out.println("-----incomingCombinedHNodeSet=" + incomingCombinedHNodeSet);
+
+          // check whether the next combination node is different from the current node
+          if (combinationNodeInSCGraph.equals(getCombinationNodeInSCGraph(desc, outNode))) {
+            Pair<HNode, HNode> pair = new Pair(combinationNodeInSCGraph, outNode);
+            if (visited.containsAll(incomingCombinedHNodeSet)) {
               visited.add(outNode);
+              System.out.println("-------curIdx=" + (idx + 1));
+
+              int newIdx = getCurrentHighestIndex(pair, idx + 1);
+              // int newIdx = getCurrentHighestIndex(outNode, idx + 1);
+              System.out.println("-------newIdx=" + newIdx);
               recurDFS(desc, lattice, combinationNodeInSCGraph, endNodeSet, visited,
-                  mapIntermediateLoc, idx + 1, locSummary, outNode);
+                  mapIntermediateLoc, newIdx, locSummary, outNode);
+              // recurDFS(desc, lattice, combinationNodeInSCGraph, endNodeSet, visited,
+              // mapIntermediateLoc, idx + 1, locSummary, outNode);
             } else {
+              updateHighestIndex(pair, idx + 1);
+              // updateHighestIndex(outNode, idx + 1);
+              System.out.println("-----NOT RECUR!");
+            }
+          } else {
+            if (needToExpandCombinationNode(desc, outNode)) {
+              System.out.println("NEED TO");
               expandCombinationNode(desc, lattice, visited, mapIntermediateLoc, locSummary, outNode);
+            } else {
+              System.out.println("NOT NEED TO");
             }
-          }
 
+          }
         }
       }
+      // }
+
+    }
 
+  }
+
+  private int getCurrentHighestIndex(Pair<HNode, HNode> pair, int curIdx) {
+    int recordedIdx = getCurrentHighestIndex(pair);
+    if (recordedIdx > curIdx) {
+      return recordedIdx;
+    } else {
+      return curIdx;
     }
+  }
+
+  private int getCurrentHighestIndex(HNode node, int curIdx) {
+    int recordedIdx = getCurrentHighestIndex(node);
+    if (recordedIdx > curIdx) {
+      return recordedIdx;
+    } else {
+      return curIdx;
+    }
+  }
 
+  private int getCurrentHighestIndex(Pair<HNode, HNode> pair) {
+    if (!mapItemToHighestIndex.containsKey(pair)) {
+      mapItemToHighestIndex.put(pair, new Integer(-1));
+    }
+    return mapItemToHighestIndex.get(pair).intValue();
+  }
+
+  private void updateHighestIndex(Pair<HNode, HNode> pair, int idx) {
+    if (idx > getCurrentHighestIndex(pair)) {
+      mapItemToHighestIndex.put(pair, new Integer(idx));
+    }
+  }
+
+  private int getCurrentHighestIndex(HNode node) {
+    if (!mapHNodeToHighestIndex.containsKey(node)) {
+      mapHNodeToHighestIndex.put(node, new Integer(-1));
+    }
+    return mapHNodeToHighestIndex.get(node).intValue();
+  }
+
+  private void updateHighestIndex(HNode node, int idx) {
+    if (idx > getCurrentHighestIndex(node)) {
+      mapHNodeToHighestIndex.put(node, new Integer(idx));
+    }
   }
 
   private String generateElementName(BasisSet basisSet, HierarchyGraph inputGraph,
@@ -759,8 +1244,8 @@ public class BuildLattice {
 
   private void debug_print(HierarchyGraph inputGraph) {
     System.out.println("\nBuild Lattice:" + inputGraph.getName());
-    // System.out.println("Node2Index:\n" + inputGraph.getMapHNodeToUniqueIndex());
-    // System.out.println("Node2Basis:\n" + inputGraph.getMapHNodeToBasis());
+    System.out.println("Node2Index:\n" + inputGraph.getMapHNodeToUniqueIndex());
+    System.out.println("Node2Basis:\n" + inputGraph.getMapHNodeToBasis());
   }
 
 }