From f801b8fe7ace6306b653f5ea68c378f35e9f2d6d Mon Sep 17 00:00:00 2001 From: Richard Trieu Date: Mon, 1 Jul 2013 23:42:53 +0000 Subject: [PATCH] Fix up some asserts that are within an if statement. This removes the need for assert(0 && "text"). git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@185396 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/TableGen/Record.h | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/include/llvm/TableGen/Record.h b/include/llvm/TableGen/Record.h index 5bf4f4fc5d5..e17cddd9af9 100644 --- a/include/llvm/TableGen/Record.h +++ b/include/llvm/TableGen/Record.h @@ -1798,10 +1798,12 @@ struct LessRecordRegister { return LHSPart.second.size() < RHSPart.second.size(); unsigned LHSVal, RHSVal; - if (LHSPart.second.getAsInteger(10, LHSVal)) - assert(0 && "Unable to convert LHS to integer."); - if (RHSPart.second.getAsInteger(10, RHSVal)) - assert(0 && "Unable to convert RHS to integer."); + + bool LHSFailed = LHSPart.second.getAsInteger(10, LHSVal); (void)LHSFailed; + assert(!LHSFailed && "Unable to convert LHS to integer."); + bool RHSFailed = RHSPart.second.getAsInteger(10, RHSVal); (void)RHSFailed; + assert(!RHSFailed && "Unable to convert RHS to integer."); + if (LHSVal != RHSVal) return LHSVal < RHSVal; } -- 2.34.1