From f69d5d73986dce2941fff432a212e04ae855407f Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Sat, 26 Jan 2008 01:43:44 +0000 Subject: [PATCH] If we have a function like this: void bork() { int *address = 0; *address = 0; } It's compiled into LLVM code that looks like this: define void @bork() noreturn nounwind { entry: unreachable } This is bad on some platforms (like PPC) because it will generate the label for the function but no body. The label could end up being associated with some non-code related stuff, like a section. This places a "trap" instruction if the SimplifyCFG pass removed all code from the function leaving only one "unreachable" instruction. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46387 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Scalar/SimplifyCFG.cpp | 15 ++++++++++++++- test/CFrontend/2008-01-25-EmptyFunction.c | 7 +++++++ 2 files changed, 21 insertions(+), 1 deletion(-) create mode 100644 test/CFrontend/2008-01-25-EmptyFunction.c diff --git a/lib/Transforms/Scalar/SimplifyCFG.cpp b/lib/Transforms/Scalar/SimplifyCFG.cpp index 3d1a5bea97c..9d0757a7146 100644 --- a/lib/Transforms/Scalar/SimplifyCFG.cpp +++ b/lib/Transforms/Scalar/SimplifyCFG.cpp @@ -26,6 +26,7 @@ #include "llvm/Transforms/Utils/Local.h" #include "llvm/Constants.h" #include "llvm/Instructions.h" +#include "llvm/Intrinsics.h" #include "llvm/Module.h" #include "llvm/ParameterAttributes.h" #include "llvm/Support/CFG.h" @@ -154,8 +155,20 @@ static bool RemoveUnreachableBlocks(Function &F) { bool Changed = MarkAliveBlocks(F.begin(), Reachable); // If there are unreachable blocks in the CFG... - if (Reachable.size() == F.size()) + if (Reachable.size() == F.size()) { + if (F.size() == 1) { + // If the function has only one block with an "unreachable" instruction, + // then we should create *some* code for it. Issue a "trap" instead. + BasicBlock &BB = F.front(); + + if (BB.size() == 1 && dyn_cast(&BB.front())) + new CallInst(Intrinsic::getDeclaration(F.getParent(), + Intrinsic::trap), + "", &BB.front()); + } + return Changed; + } assert(Reachable.size() < F.size()); NumSimpl += F.size()-Reachable.size(); diff --git a/test/CFrontend/2008-01-25-EmptyFunction.c b/test/CFrontend/2008-01-25-EmptyFunction.c new file mode 100644 index 00000000000..896738ee063 --- /dev/null +++ b/test/CFrontend/2008-01-25-EmptyFunction.c @@ -0,0 +1,7 @@ +// RUN: %llvmgcc -O2 -S -o - -emit-llvm %s | grep llvm.trap +// RUN: %llvmgcc -O2 -S -o - -emit-llvm %s | grep unreachable + +void bork() { + int *address = 0; + *address = 0; +} -- 2.34.1