From f0edaf8e00d7977407738b770f1d7adc7f1b25b8 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Tue, 1 Dec 2015 18:46:19 +0000 Subject: [PATCH] Use a forwarding constructor instead of an init method. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@254435 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/Linker/Linker.h | 1 - lib/Linker/LinkModules.cpp | 15 +++++---------- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/include/llvm/Linker/Linker.h b/include/llvm/Linker/Linker.h index 3f6c7b6c694..7ac457856a1 100644 --- a/include/llvm/Linker/Linker.h +++ b/include/llvm/Linker/Linker.h @@ -93,7 +93,6 @@ public: unsigned Flags = Flags::None); private: - void init(Module *M, DiagnosticHandlerFunction DiagnosticHandler); Module *Composite; IdentifiedStructTypeSet IdentifiedStructTypes; diff --git a/lib/Linker/LinkModules.cpp b/lib/Linker/LinkModules.cpp index c57c70e322a..9aff43f3199 100644 --- a/lib/Linker/LinkModules.cpp +++ b/lib/Linker/LinkModules.cpp @@ -2032,7 +2032,7 @@ bool Linker::IdentifiedStructTypeSet::hasType(StructType *Ty) { return *I == Ty; } -void Linker::init(Module *M, DiagnosticHandlerFunction DiagnosticHandler) { +Linker::Linker(Module *M, DiagnosticHandlerFunction DiagnosticHandler) { this->Composite = M; this->DiagnosticHandler = DiagnosticHandler; @@ -2046,15 +2046,10 @@ void Linker::init(Module *M, DiagnosticHandlerFunction DiagnosticHandler) { } } -Linker::Linker(Module *M, DiagnosticHandlerFunction DiagnosticHandler) { - init(M, DiagnosticHandler); -} - -Linker::Linker(Module *M) { - init(M, [this](const DiagnosticInfo &DI) { - Composite->getContext().diagnose(DI); - }); -} +Linker::Linker(Module *M) + : Linker(M, [this](const DiagnosticInfo &DI) { + Composite->getContext().diagnose(DI); + }) {} void Linker::deleteModule() { delete Composite; -- 2.34.1