From e10c0b9d66910dd1dbe2914877ae71ac5dea941f Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Mon, 18 Feb 2008 17:50:16 +0000 Subject: [PATCH] Transforming -A + -B --> -(A + B) isn't safe for FP, thanks to Dale for noticing this! git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@47276 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Scalar/InstructionCombining.cpp | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/Transforms/Scalar/InstructionCombining.cpp b/lib/Transforms/Scalar/InstructionCombining.cpp index 9d0990f51b8..f89d1f2aeee 100644 --- a/lib/Transforms/Scalar/InstructionCombining.cpp +++ b/lib/Transforms/Scalar/InstructionCombining.cpp @@ -2092,10 +2092,12 @@ Instruction *InstCombiner::visitAdd(BinaryOperator &I) { // -A + B --> B - A // -A + -B --> -(A + B) if (Value *LHSV = dyn_castNegVal(LHS)) { - if (Value *RHSV = dyn_castNegVal(RHS)) { - Instruction *NewAdd = BinaryOperator::createAdd(LHSV, RHSV, "sum"); - InsertNewInstBefore(NewAdd, I); - return BinaryOperator::createNeg(NewAdd); + if (LHS->getType()->isIntOrIntVector()) { + if (Value *RHSV = dyn_castNegVal(RHS)) { + Instruction *NewAdd = BinaryOperator::createAdd(LHSV, RHSV, "sum"); + InsertNewInstBefore(NewAdd, I); + return BinaryOperator::createNeg(NewAdd); + } } return BinaryOperator::createSub(RHS, LHSV); -- 2.34.1