From ce906524898ea4c7b99131bd9d79446c996f6022 Mon Sep 17 00:00:00 2001 From: Nick Kledzik Date: Tue, 16 Sep 2014 22:03:13 +0000 Subject: [PATCH] [llvm-objdump] improve error reporting of bad mach-o ordinals git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217909 91177308-0d34-0410-b5e6-96231b3b80d8 --- tools/llvm-objdump/MachODump.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/llvm-objdump/MachODump.cpp b/tools/llvm-objdump/MachODump.cpp index 871e7d16ece..602e8002800 100644 --- a/tools/llvm-objdump/MachODump.cpp +++ b/tools/llvm-objdump/MachODump.cpp @@ -2446,9 +2446,15 @@ static StringRef ordinalName(const object::MachOObjectFile *Obj, int Ordinal) { case MachO::BIND_SPECIAL_DYLIB_FLAT_LOOKUP: return "flat-namespace"; default: - Obj->getLibraryShortNameByIndex(Ordinal-1, DylibName); - return DylibName; + if (Ordinal > 0) { + std::error_code EC = Obj->getLibraryShortNameByIndex(Ordinal-1, + DylibName); + if (EC) + return "<>"; + return DylibName; + } } + return "<>"; } //===----------------------------------------------------------------------===// -- 2.34.1