From c265f066971a3df6b0ec546311e63a3efe812e40 Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Thu, 2 Jan 2014 19:04:59 +0000 Subject: [PATCH] Make llvm::Regex non-copyable but movable. Based on a patch by Maciej Piechotka. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198334 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/Support/Regex.h | 14 ++++++++++++++ lib/Support/Regex.cpp | 6 ++++-- unittests/Support/RegexTest.cpp | 15 +++++++++++++++ 3 files changed, 33 insertions(+), 2 deletions(-) diff --git a/include/llvm/Support/Regex.h b/include/llvm/Support/Regex.h index 21677dcfa16..5f1031ef361 100644 --- a/include/llvm/Support/Regex.h +++ b/include/llvm/Support/Regex.h @@ -17,6 +17,7 @@ #ifndef LLVM_SUPPORT_REGEX_H #define LLVM_SUPPORT_REGEX_H +#include "llvm/Support/Compiler.h" #include struct llvm_regex; @@ -45,6 +46,19 @@ namespace llvm { /// Compiles the given regular expression \p Regex. Regex(StringRef Regex, unsigned Flags = NoFlags); + Regex(const Regex &) LLVM_DELETED_FUNCTION; + Regex &operator=(Regex regex) { + std::swap(preg, regex.preg); + std::swap(error, regex.error); + return *this; + } +#if LLVM_HAS_RVALUE_REFERENCES + Regex(Regex &®ex) { + preg = regex.preg; + error = regex.error; + regex.preg = NULL; + } +#endif ~Regex(); /// isValid - returns the error encountered during regex compilation, or diff --git a/lib/Support/Regex.cpp b/lib/Support/Regex.cpp index eb94745d9e3..1115534427c 100644 --- a/lib/Support/Regex.cpp +++ b/lib/Support/Regex.cpp @@ -33,8 +33,10 @@ Regex::Regex(StringRef regex, unsigned Flags) { } Regex::~Regex() { - llvm_regfree(preg); - delete preg; + if (preg) { + llvm_regfree(preg); + delete preg; + } } bool Regex::isValid(std::string &Error) { diff --git a/unittests/Support/RegexTest.cpp b/unittests/Support/RegexTest.cpp index 30ea2c5b274..c3a8085accd 100644 --- a/unittests/Support/RegexTest.cpp +++ b/unittests/Support/RegexTest.cpp @@ -140,4 +140,19 @@ TEST_F(RegexTest, IsValid) { EXPECT_EQ("invalid character range", Error); } +#if LLVM_HAS_RVALUE_REFERENCES +TEST_F(RegexTest, MoveConstruct) { + Regex r1("^[0-9]+$"); + Regex r2(std::move(r1)); + EXPECT_TRUE(r2.match("916")); +} + +TEST_F(RegexTest, MoveAssign) { + Regex r1("^[0-9]+$"); + Regex r2("abc"); + r2 = std::move(r1); + EXPECT_TRUE(r2.match("916")); +} +#endif + } -- 2.34.1